A test about entropy fails on RISCV-64

[dinosaure]

During #266, I saw this error:

/src: (run (shell "opam exec -- dune build --only-packages=mirage-crypto,mirage-crypto-rng,mirage-crypto-rng-mirage,mirage-crypto-pk,mirage-crypto-ec @install @check @runtest && rm -rf _build"))
File "tests/dune", line 34, characters 7-19:
34 |  (name test_entropy)
^^^^^^^^^^^^
(cd _build/default/tests && ./test_entropy.exe)
7ed1 aedd Fatal error: exception Failure("same data from timer at 2")
(cd _build/default/tests && ./test_symmetric_runner.exe)
accel:
................................................................
Ran: 64 tests in: 0.25 seconds.
OK
(cd _build/default/tests && ./test_random_runner.exe)
.........
Ran: 9 tests in: 0.15 seconds.
OK
(cd _build/default/tests && ./test_entropy_collection.exe)
reseeding:
000000  00c8 7afc 7cfc 7efc  7ffc 80fc 81fc 82fc  ..z.|.~.........
000010  83fc 84fc 86fc 87fc  88fc 89fc 8afc 8bfc  ................
000020  8dfc 8efc 8ffc 90fc  92fc 93fc 94fc 95fc  ................
000030  97fc 98fc 99fc 9bfc  9cfc 9dfc 9ffc a0fc  ................
000040  a1fc a3fc a4fc a6fc  a7fc a8fc aafc abfc  ................
000050  adfc aefc b0fc b1fc  b3fc b4fc b6fc b7fc  ................
000060  b9fc bbfc bcfc befc  bffc c1fc c3fc c4fc  ................
000070  c6fc c8fc c9fc cbfc  cdfc cffc d0fc d2fc  ................
000080  d4fc d6fc d7fc d9fc  dbfc ddfc dffc e1fc  ................
000090  e3fc e5fc e6fc e8fc  eafc ecfc eefc f0fc  ................
0000a0  f2fc f4fc f6fc f9fc  fbfc fdfc fffc 01fd  ................
0000b0  03fd 05fd 08fd 0afd  0cfd 0efd 11fd 13fd  ................
0000c0  15fd 17fd 1afd 1cfd  1ffd 01c8 22fd 24fd  ............".$.
0000d0  27fd 29fd 2cfd 2efd  31fd 34fd 36fd 39fd  '.).,...1.4.6.9.
0000e0  3bfd 3efd 41fd 43fd  46fd 49fd 4bfd 4efd  ;.>.A.C.F.I.K.N.
0000f0  51fd 54fd 57fd 5afd  5cfd 5ffd 62fd 65fd  Q.T.W.Z.\._.b.e.
000100  68fd 6bfd 6efd 71fd  74fd 77fd 7bfd 7efd  h.k.n.q.t.w.{.~.
000110  81fd 84fd 87fd 8bfd  8efd 91fd 94fd 98fd  ................
000120  9bfd 9ffd a2fd a6fd  a9fd adfd b0fd b4fd  ................
000130  b7fd bbfd bffd c2fd  c6fd cafd cefd d1fd  ................
000140  d5fd d9fd ddfd e1fd  e5fd e9fd edfd f1fd  ................
000150  f5fd f9fd fefd 02fe  06fe 0afe 0ffe 13fe  ................
000160  17fe 1cfe 20fe 25fe  29fe 2efe 32fe 37fe  .... .%.)...2.7.
000170  3cfe 40fe 45fe 4afe  4ffe 54fe 59fe 5efe  <.@.E.J.O.T.Y.^.
000180  63fe 68fe 6dfe 72fe  77fe 7cfe 81fe 87fe  c.h.m.r.w.|.....
000190  8dfe 92fe 02c8 98fe  9efe a3fe a9fe aefe  ................
0001a0  b4fe bafe c0fe c5fe  cbfe d1fe d7fe ddfe  ................
0001b0  e3fe e9fe effe f5fe  fcfe 02ff 08ff 0fff  ................
0001c0  15ff 1cff 22ff 29ff  2fff 36ff 3dff 44ff  ....".)./.6.=.D.
0001d0  4aff 51ff 58ff 5fff  66ff 6eff 75ff 7cff  J.Q.X._.f.n.u.|.
0001e0  83ff 8bff 92ff 9aff  a1ff a9ff b0ff b8ff  ................
0001f0  c0ff c8ff d1ff d9ff  e1ff e9ff f1ff f9ff  ................
000200  0200 0200 0200 0200  0200 0200 0200 0300  ................
000210  0300 0300 0300 0300  0300 0300 0300 0400  ................
000220  0400 0400 0400 0400  0400 0400 0500 0500  ................
000230  0500 0500 0500 0500  0600 0600 0600 0600  ................
000240  0600 0600 0600 0700  0700 0700 0700 0700  ................
000250  0700 0700 0700 0800  0800 0800 0800 03c8  ................
000260  2c00 2c00 2d00 2d00  2e00 2e00 2f00 2f00  ,.,.-.-....././.
000270  3000 3000 3000 3100  3100 3200 3200 3300  0.0.0.1.1.2.2.3.
000280  3300 3400 3400 3500  3500 3600 3600 3700  3.4.4.5.5.6.6.7.
000290  3700 3800 3800 3900  3a00 3a00 3b00 3b00  7.8.8.9.:.:.;.;.
0002a0  3c00 3c00 3d00 3d00  3e00 3f00 3f00 4000  <.<.=.=.>.?.?.@.
0002b0  4000 4100 4200 4200  4300 4300 4400 4500  @.A.B.B.C.C.D.E.
0002c0  4500 4600 4700 4700  4800 4900 4900 4a00  E.F.G.G.H.I.I.J.
0002d0  4b00 4b00 4c00 4d00  4d00 4e00 4f00 4f00  K.K.L.M.M.N.O.O.
0002e0  5000 5100 5200 5200  5300 5400 5500 5500  P.Q.R.R.S.T.U.U.
0002f0  5600 5700 5800 5800  5900 5a00 5b00 5c00  V.W.X.X.Y.Z.[.\.
000300  5d00 5d00 5e00 5f00  6000 6100 6200 6200  ].].^._.`.a.b.b.
000310  6300 6400 6500 6600  6700 6800 6900 6a00  c.d.e.f.g.h.i.j.
000320  6b00 6c00 6c00 6d00                       k.l.l.m.


entropy sources: [0] timer
accumulate: (src: [0] timer) 0a2b bddd

The bug appears only on debian 14 (OCaml 4.14) RISCV-64. I made this issue just to keep it in our mind.

[hannesm]

There's from the dune file:

(test
 (name test_entropy)
 (modules test_entropy)
 (package mirage-crypto-rng)
 (libraries mirage-crypto-rng ohex)
 (enabled_if (and (<> %{architecture} "arm64") (<> %{architecture} "riscv64"))))
 ; see https://github.com/mirage/mirage-crypto/issues/216

but it seems this enabled_if doesn't work as I thought it would...

[reynir]

If I search for dune files with %{architecture} and riscv64 I only get this repo as result:
https://github.com/search?q=path%3Adune+%22%25%7Barchitecture%7D%22+riscv64&type=code
If I search the same but riscv instead of riscv64 I get more results:
https://github.com/search?q=path%3Adune+%22%25%7Barchitecture%7D%22+riscv&type=code

Could it be that it should be (and (= %{architecture} "riscv") %{arch_sixtyfour})?

The logic might be that riscv64 is an extension to riscv rather than a different architecture.