Avoid recreating ref content (#1)

This removes the default value for apiHost but most importantly avoids
recreating a killswitch when the hook is rerun

Author: charlesdemers

README.md

@@ -47,7 +47,7 @@ const { isOk } = useKillswitch({
   the correct behavior to your users.
 
 - `apiHost`
-  The host of the killswitch back-end. Defaults to: `https://killswitch.mirego.com`
+  The host of the killswitch back-end.
 
 - `useNativeUI`
   Use native alerts to display messages. Defaults to `true`

example/src/App.tsx

@@ -11,6 +11,7 @@ export default function App() {
       'a351227e97198cb4d71e6433ef7afcc185b49b8c364874b5129aacd08b576f59',
     language: 'fr',
     version: '0.10.0',
+    apiHost: 'https://killswitch.mirego.com',
   });
 
   return (

src/use-killswitch.ts

@@ -1,4 +1,4 @@
-import { useEffect, useRef, useState } from 'react';
+import { useCallback, useEffect, useRef, useState } from 'react';
 import usePrevious from './hooks/use-previous';
 import { useAppState } from './hooks/use-app-state';
 import Killswitch from './killswitch';
@@ -8,7 +8,7 @@ interface UseKillswitchOptions {
   androidApiKey: string;
   language: string;
   version: string;
-  apiHost?: string;
+  apiHost: string;
   useNativeUI?: boolean;
   timeout?: number;
 }
@@ -18,23 +18,35 @@ export function useKillswitch({
   androidApiKey,
   language,
   version,
-  apiHost = 'https://killswitch.mirego.com',
+  apiHost,
   useNativeUI = true,
   timeout = 2000,
 }: UseKillswitchOptions) {
-  const killswitch = useRef(
-    new Killswitch({ iosApiKey, androidApiKey, apiHost, useNativeUI, timeout })
-  );
-
+  const killswitchRef = useRef<Killswitch | null>(null);
   const appState = useAppState();
   const previousAppState = usePrevious(appState);
-
   const [isOk, setIsOk] = useState<boolean | null>(null);
 
+  const getKillswitch = useCallback(() => {
+    if (killswitchRef.current !== null) return killswitchRef.current;
+
+    const killswitch = new Killswitch({
+      iosApiKey,
+      androidApiKey,
+      apiHost,
+      useNativeUI,
+      timeout,
+    });
+
+    killswitchRef.current = killswitch;
+
+    return killswitch;
+  }, [androidApiKey, apiHost, iosApiKey, timeout, useNativeUI]);
+
   useEffect(() => {
     async function run() {
       if (previousAppState !== 'active' && appState === 'active') {
-        const { isOk: newIsOk } = await killswitch.current.check(
+        const { isOk: newIsOk } = await getKillswitch().check(
           language,
           version
         );
@@ -44,7 +56,7 @@ export function useKillswitch({
     }
 
     run();
-  }, [appState, language, previousAppState, version]);
+  }, [appState, getKillswitch, language, previousAppState, version]);
 
-  return { isOk, killswitch: killswitch.current };
+  return { isOk, killswitch: getKillswitch() };
 }