Skip to content

Commit 1cc19f7

Browse files
committed
Minor code quality improvements
1 parent 03dc717 commit 1cc19f7

File tree

35 files changed

+40
-58
lines changed

35 files changed

+40
-58
lines changed

_installer/Classes/Installer.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,7 @@ protected static function initStepControllers(): void
228228
$step_name = array_shift( $steps );
229229

230230
$step_base_path = static::getBasePath() . 'Step/' . $step_name . '/';
231-
232-
/** @noinspection PhpIncludeInspection */
231+
233232
require_once $step_base_path . 'Controller.php';
234233

235234
$class_name = __NAMESPACE__ . '\\Installer_Step_' . $step_name . '_Controller';

_installer/views/button/next.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ namespace JetApplication\Installer;
44
use Jet\Tr;
55
?>
66
<button type="submit" class="btn btn-primary">
7-
<?=Tr::_( 'Continue', [] );?> <i class="fa fa-chevron-right"></i>
7+
<?=Tr::_( 'Continue' );?> <i class="fa fa-chevron-right"></i>
88
</button>

_installer/views/form/field/input/hidden.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ if( $field->getLastErrorCode() ) {
1414
$r->addCustomCssClass( 'is-invalid' );
1515
}
1616
?>
17-
<input type="hidden" name="<?= $field->getTagNameValue() ?>" id="<?= $field->getId() ?>" value="<?= $field->getValue() ?>" <?php if( $r->getJsActions() ) echo $r->getJsActions() ?>/>
17+
<input type="hidden" name="<?= $field->getTagNameValue() ?>" id="<?= $field->getId() ?>" value="<?= $field->getValue() ?>"/>

_profiler/views/result.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ function formatQuery(string $query, array $query_data = []) : string
8282
* @param Debug_Profiler_Run_Block $block
8383
* @param int $level
8484
*/
85-
function showRunBlock( Debug_Profiler_Run_Block $block, int $level=0)
85+
function showRunBlock( Debug_Profiler_Run_Block $block, int $level=0) : void
8686
{
8787
$id = $block->getId();
8888
$is_root = $block->getIsRoot();

_tools/cli/init/init_modules.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
* @param Exception $e
2525
* @param int $error_code
2626
*/
27-
function handleException( Exception $e, int $error_code = 100)
27+
function handleException( Exception $e, int $error_code = 100) : void
2828
{
2929
echo 'ERROR' . PHP_EOL;
3030
echo $e->getMessage();
@@ -33,7 +33,7 @@ function handleException( Exception $e, int $error_code = 100)
3333
}
3434

3535

36-
function ok()
36+
function ok() : void
3737
{
3838
echo 'OK' . PHP_EOL . PHP_EOL;
3939
exit(0);

_tools/studio/application/Classes/Application.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,7 @@ public static function handleAction( ?string $part = null ): void
247247
if( !IO_File::exists( $controller ) ) {
248248
return;
249249
}
250-
251-
/** @noinspection PhpIncludeInspection */
250+
252251
require $controller;
253252
}
254253

_tools/studio/application/Classes/ClassParser.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function __construct( string $script_data )
8282
/**
8383
* @param string $script_data
8484
*/
85-
public function setScriptData( string $script_data )
85+
public function setScriptData( string $script_data ) : void
8686
{
8787
//debug_print_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
8888
//echo 'setScriptData:'.PHP_EOL;

_tools/studio/application/Classes/DataModel/Class.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public function getDefinition(): DataModel_Definition_Model_Main|DataModel_Defin
139139
/**
140140
* @param DataModel_Definition_Model_Main|DataModel_Definition_Model_Related_1to1|DataModel_Definition_Model_Related_1toN $definition
141141
*/
142-
public function setDefinition( DataModel_Definition_Model_Main|DataModel_Definition_Model_Related_1to1|DataModel_Definition_Model_Related_1toN $definition )
142+
public function setDefinition( DataModel_Definition_Model_Main|DataModel_Definition_Model_Related_1to1|DataModel_Definition_Model_Related_1toN $definition ) : void
143143
{
144144
$definition->setClass( $this );
145145

_tools/studio/application/Classes/DataModel/Definition/Model/Interface.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ public function getExternalRelations(): array;
6262

6363
/**
6464
* @return DataModel_Definition_Property_Interface[]|\Jet\DataModel_Definition_Property[]
65-
* @noinspection PhpDocSignatureInspection
6665
*/
6766
public function getProperties(): array;
6867

_tools/studio/application/Classes/DataModel/Definition/Model/Trait.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ public function getExtendsScope(): array
155155

156156
/**
157157
* @return DataModel_Definition_Property_Interface[]|\Jet\DataModel_Definition_Property[]
158-
* @noinspection PhpDocSignatureInspection
159158
*/
160159
public function getProperties(): array
161160
{

0 commit comments

Comments
 (0)