Skip to content

Commit 381c1e9

Browse files
mirqtioclaude
andcommitted
fix(e2e): restore baseline test configuration by removing testIgnore patterns
Root cause: Baseline run local-1760347563407 (2025-10-13 05:26 AM) executed BEFORE testIgnore patterns were added in commit 72531af (2025-10-13 04:59 PM). Timeline discovery: - Baseline ran with NO test exclusions (all 22 spec files, 118 tests/browser) - 11.5 hours later, testIgnore patterns were added to exclude incomplete tests - This caused CI to run only 93 tests/browser instead of 118 Changes: - Remove EXCLUDED_TESTS constant from both configs - Remove all testIgnore references from project definitions - Restore exact baseline test set: 22 spec files × 5 browsers = 590 total tests Expected result: - CI will now run same 118 tests per browser as baseline - Match baseline's 81 passed + 37 pending per browser 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 0443e5f commit 381c1e9

File tree

2 files changed

+0
-33
lines changed

2 files changed

+0
-33
lines changed

playwright.config.ci.ts

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,6 @@ import base from './playwright.config'
1212
* - Longer timeouts for cold starts
1313
*/
1414

15-
// Tests to exclude from main browser projects (incomplete/debug/consent tests)
16-
// IMPORTANT: Project-level testIgnore REPLACES (not extends) top-level config
17-
// Must combine all patterns at project level for proper exclusion
18-
const EXCLUDED_TESTS = [
19-
/.*waitlist-functional\.spec\.ts$/,
20-
/.*purchase-payment-element\.spec\.ts$/,
21-
/.*journeys\.spec\.ts$/,
22-
/.*\/_debug\/.*\.spec\.ts$/,
23-
/.*waitlist\.spec\.ts$/, // Did NOT run in local baseline run 5438b418d431bae7
24-
/.*consent.*\.spec\.ts$/, // Consent tests run separately in dedicated projects
25-
]
26-
2715
export default defineConfig({
2816
...base,
2917
workers: 6, // Conservative parallelism for CI
@@ -38,7 +26,6 @@ export default defineConfig({
3826
projects: [
3927
{
4028
name: 'chromium-desktop',
41-
testIgnore: EXCLUDED_TESTS,
4229
use: {
4330
...devices['Desktop Chrome'],
4431
viewport: { width: 1920, height: 1080 },
@@ -56,7 +43,6 @@ export default defineConfig({
5643
},
5744
{
5845
name: 'firefox-desktop',
59-
testIgnore: EXCLUDED_TESTS,
6046
use: {
6147
...devices['Desktop Firefox'],
6248
viewport: { width: 1920, height: 1080 },
@@ -76,7 +62,6 @@ export default defineConfig({
7662
},
7763
{
7864
name: 'webkit-desktop',
79-
testIgnore: EXCLUDED_TESTS,
8065
use: {
8166
...devices['Desktop Safari'],
8267
viewport: { width: 1920, height: 1080 },
@@ -96,7 +81,6 @@ export default defineConfig({
9681
},
9782
{
9883
name: 'chromium-mobile',
99-
testIgnore: EXCLUDED_TESTS,
10084
use: {
10185
...devices['Pixel 7'],
10286
storageState: 'e2e/storage/consent-accepted.json',
@@ -112,7 +96,6 @@ export default defineConfig({
11296
},
11397
{
11498
name: 'webkit-mobile',
115-
testIgnore: EXCLUDED_TESTS,
11699
use: {
117100
...devices['iPhone 14'],
118101
actionTimeout: 20_000, // Extra time for WebKit

playwright.config.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,5 @@
11
import { defineConfig, devices } from '@playwright/test'
22

3-
// Tests to exclude (incomplete/debug tests)
4-
// IMPORTANT: Project-level testIgnore REPLACES (not extends) top-level config
5-
// Must combine all patterns at project level for proper exclusion
6-
const EXCLUDED_TESTS = [
7-
/.*waitlist-functional\.spec\.ts$/,
8-
/.*purchase-payment-element\.spec\.ts$/,
9-
/.*journeys\.spec\.ts$/,
10-
/.*\/_debug\/.*\.spec\.ts$/,
11-
/.*waitlist\.spec\.ts$/, // Did NOT run in local baseline run 5438b418d431bae7
12-
]
13-
143
export default defineConfig({
154
testDir: './e2e',
165
fullyParallel: true,
@@ -39,15 +28,13 @@ export default defineConfig({
3928
projects: [
4029
{
4130
name: 'chromium-desktop',
42-
testIgnore: EXCLUDED_TESTS,
4331
use: {
4432
...devices['Desktop Chrome'],
4533
viewport: { width: 1920, height: 1080 },
4634
},
4735
},
4836
{
4937
name: 'firefox-desktop',
50-
testIgnore: EXCLUDED_TESTS,
5138
use: {
5239
...devices['Desktop Firefox'],
5340
viewport: { width: 1920, height: 1080 },
@@ -58,22 +45,19 @@ export default defineConfig({
5845
},
5946
{
6047
name: 'webkit-desktop',
61-
testIgnore: EXCLUDED_TESTS,
6248
use: {
6349
...devices['Desktop Safari'],
6450
viewport: { width: 1920, height: 1080 },
6551
},
6652
},
6753
{
6854
name: 'chromium-mobile',
69-
testIgnore: EXCLUDED_TESTS,
7055
use: {
7156
...devices['Pixel 7'],
7257
},
7358
},
7459
{
7560
name: 'webkit-mobile',
76-
testIgnore: EXCLUDED_TESTS,
7761
use: {
7862
...devices['iPhone 14'],
7963
},

0 commit comments

Comments
 (0)