fix invalid-assignment rule (#420)

DamianCzajkowski · web-flow · commit c057a518b327 · 2026-03-12T13:58:58.000+01:00
diff --git a/ariadne_codegen/client_generators/client.py b/ariadne_codegen/client_generators/client.py
@@ -1,5 +1,5 @@
 import ast
-from typing import Optional, Union
+from typing import Optional, Union, cast
 
 from graphql import OperationDefinitionNode, OperationType
 
@@ -330,7 +330,7 @@ def create_combine_variables_method(self):
         method_def = generate_method_definition(
             name="_combine_variables",
             arguments=args,
-            body=method_body,
+            body=cast(list[ast.stmt], method_body),
             decorator_list=[],
             return_type=returns,
         )
@@ -416,7 +416,7 @@ def create_build_variable_definitions_method(self):
                     ),
                 ]
             ),
-            body=method_body,
+            body=cast(list[ast.stmt], method_body),
             return_type=generate_subscript(
                 generate_name("list"), generate_name("VariableDefinitionNode")
             ),
@@ -509,7 +509,7 @@ def create_build_operation_ast_method(self):
                     ),
                 ]
             ),
-            body=method_body,
+            body=cast(list[ast.stmt], method_body),
             return_type=generate_name("DocumentNode"),
         )
 
@@ -607,7 +607,7 @@ def create_execute_custom_operation_method(self, async_client: bool):
                     generate_arg("operation_name", annotation=generate_name("str")),
                 ]
             ),
-            body=method_body,
+            body=cast(list[ast.stmt], method_body),
             return_type=generate_subscript(
                 generate_name(DICT),
                 generate_tuple([generate_name("str"), generate_name("Any")]),
diff --git a/ariadne_codegen/client_generators/custom_arguments.py b/ariadne_codegen/client_generators/custom_arguments.py
@@ -323,4 +323,4 @@ def generate_clear_arguments_section(
         arguments_keyword = [
             generate_keyword(arg="arguments", value=generate_name("cleared_arguments"))
         ]
-        return arguments_body, arguments_keyword
+        return (cast(list[ast.stmt], arguments_body), arguments_keyword)
diff --git a/ariadne_codegen/client_generators/dependencies/async_base_client.py b/ariadne_codegen/client_generators/dependencies/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/ariadne_codegen/client_generators/dependencies/async_base_client_open_telemetry.py b/ariadne_codegen/client_generators/dependencies/async_base_client_open_telemetry.py
@@ -407,15 +407,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/ariadne_codegen/codegen.py b/ariadne_codegen/codegen.py
@@ -393,7 +393,7 @@ def generate_async_for(
     return ast.AsyncFor(
         target=target,
         iter=iter_,
-        body=body or [ast.Pass()],
+        body=cast(list[ast.stmt], body or [ast.Pass()]),
         orelse=orelse or [],
         lineno=lineno,
     )
diff --git a/pyproject.toml b/pyproject.toml
@@ -48,7 +48,7 @@ test = [
   "websockets>=14.2",
   "opentelemetry-api",
 ]
-types = ["ty"]
+types = ["ty>=0.0.20,<0.1.0"]
 subscriptions = ["websockets>=15"]
 opentelemetry = ["opentelemetry-api"]
 
diff --git a/tests/main/clients/client_forward_refs/expected_client/async_base_client.py b/tests/main/clients/client_forward_refs/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/client_forward_refs_shorter_results/expected_client/async_base_client.py b/tests/main/clients/client_forward_refs_shorter_results/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/custom_config_file/expected_client/async_base_client.py b/tests/main/clients/custom_config_file/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/custom_files_names/expected_client/async_base_client.py b/tests/main/clients/custom_files_names/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/custom_query_builder/expected_client/async_base_client.py b/tests/main/clients/custom_query_builder/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/custom_scalars/expected_client/async_base_client.py b/tests/main/clients/custom_scalars/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/example/expected_client/async_base_client.py b/tests/main/clients/example/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/extended_models/expected_client/async_base_client.py b/tests/main/clients/extended_models/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/fragments_on_abstract_types/expected_client/async_base_client.py b/tests/main/clients/fragments_on_abstract_types/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/inline_fragments/expected_client/async_base_client.py b/tests/main/clients/inline_fragments/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/interface_as_fragment/expected_client/async_base_client.py b/tests/main/clients/interface_as_fragment/expected_client/async_base_client.py
@@ -335,15 +335,19 @@ async def _send_subscribe(
         operation_name: Optional[str] = None,
         variables: Optional[dict[str, Any]] = None,
     ) -> None:
-        payload: dict[str, Any] = {
-            "id": operation_id,
-            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
-            "payload": {"query": query, "operationName": operation_name},
+        payload_inner: dict[str, Any] = {
+            "query": query,
+            "operationName": operation_name,
         }
         if variables:
-            payload["payload"]["variables"] = self._convert_dict_to_json_serializable(
+            payload_inner["variables"] = self._convert_dict_to_json_serializable(
                 variables
             )
+        payload: dict[str, Any] = {
+            "id": operation_id,
+            "type": GraphQLTransportWSMessageType.SUBSCRIBE.value,
+            "payload": payload_inner,
+        }
         await websocket.send(json.dumps(payload))
 
     async def _handle_ws_message(
diff --git a/tests/main/clients/multiple_fragments/expected_client/async_base_client.py b/tests/main/clients/multiple_fragments/expected_client/async_base_client.py
diff --git a/tests/main/clients/only_used_inputs_and_enums/expected_client/async_base_client.py b/tests/main/clients/only_used_inputs_and_enums/expected_client/async_base_client.py
diff --git a/tests/main/clients/operations/expected_client/async_base_client.py b/tests/main/clients/operations/expected_client/async_base_client.py
diff --git a/tests/main/clients/remote_schema/expected_client/async_base_client.py b/tests/main/clients/remote_schema/expected_client/async_base_client.py
diff --git a/tests/main/clients/shorter_results/expected_client/async_base_client.py b/tests/main/clients/shorter_results/expected_client/async_base_client.py
diff --git a/tests/main/custom_operation_builder/graphql_client/async_base_client.py b/tests/main/custom_operation_builder/graphql_client/async_base_client.py
diff --git a/tests/test_schema.py b/tests/test_schema.py

Original file line number	Diff line number	Diff line change
`@@ -323,4 +323,4 @@ def generate_clear_arguments_section(`
`323`	`323`	`arguments_keyword = [`
`324`	`324`	`generate_keyword(arg="arguments", value=generate_name("cleared_arguments"))`
`325`	`325`	`]`
`326`		`- return arguments_body, arguments_keyword`
	`326`	`+ return (cast(list[ast.stmt], arguments_body), arguments_keyword)`
Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ def generate_async_for(`
`393`	`393`	`return ast.AsyncFor(`
`394`	`394`	`target=target,`
`395`	`395`	`iter=iter_,`
`396`		`- body=body or [ast.Pass()],`
	`396`	`+ body=cast(list[ast.stmt], body or [ast.Pass()]),`
`397`	`397`	`orelse=orelse or [],`
`398`	`398`	`lineno=lineno,`
`399`	`399`	`)`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ test = [`
`48`	`48`	`"websockets>=14.2",`
`49`	`49`	`"opentelemetry-api",`
`50`	`50`	`]`
`51`		`-types = ["ty"]`
	`51`	`+types = ["ty>=0.0.20,<0.1.0"]`
`52`	`52`	`subscriptions = ["websockets>=15"]`
`53`	`53`	`opentelemetry = ["opentelemetry-api"]`
`54`	`54`