[3.14] pythonGH-140058: Clear key and value if PyTuple_New fails in dictiter_iternextitem (pythonGH-140059) (python#140107)

miss-islington · sergey-miryanov · web-flow · commit 2142f4efcffc · 2025-10-14T19:10:30.000+05:30
pythonGH-140058: Clear key and value if `PyTuple_New` fails in `dictiter_iternextitem` (pythonGH-140059) (cherry picked from commit ded59f7) Co-authored-by: Sergey Miryanov <sergey.miryanov@gmail.com>
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -5670,8 +5670,11 @@ dictiter_iternextitem(PyObject *self)
         }
         else {
             result = PyTuple_New(2);
-            if (result == NULL)
+            if (result == NULL) {
+                Py_DECREF(key);
+                Py_DECREF(value);
                 return NULL;
+            }
             PyTuple_SET_ITEM(result, 0, key);
             PyTuple_SET_ITEM(result, 1, value);
         }

Original file line number	Diff line number	Diff line change
`@@ -5670,8 +5670,11 @@ dictiter_iternextitem(PyObject *self)`
`5670`	`5670`	`}`
`5671`	`5671`	`else {`
`5672`	`5672`	`result = PyTuple_New(2);`
`5673`		`- if (result == NULL)`
	`5673`	`+ if (result == NULL) {`
	`5674`	`+ Py_DECREF(key);`
	`5675`	`+ Py_DECREF(value);`
`5674`	`5676`	`return NULL;`
	`5677`	`+ }`
`5675`	`5678`	`PyTuple_SET_ITEM(result, 0, key);`
`5676`	`5679`	`PyTuple_SET_ITEM(result, 1, value);`
`5677`	`5680`	`}`