[3.12] pythongh-126565: Skip zipfile.Path.exists check in write mode (pythonGH-126576) (python#126643)

pythongh-126565: Skip `zipfile.Path.exists` check in write mode (pythonGH-126576)

When `zipfile.Path.open` is called, the implementation will check
whether the path already exists in the ZIP file. However, this check is
only required when the ZIP file is in read mode. By swapping arguments
of the `and` operator, the short-circuiting will prevent the check from
being run in write mode.

This change will improve the performance of `open()`, because checking
whether a file exists is slow in write mode, especially when the archive
has many members.
(cherry picked from commit 160758a)

Co-authored-by: Jan Hicken <[email protected]>

Author: miss-islington

Lib/zipfile/_path/__init__.py

@@ -303,7 +303,7 @@ def open(self, mode='r', *args, pwd=None, **kwargs):
         if self.is_dir():
             raise IsADirectoryError(self)
         zip_mode = mode[0]
-        if not self.exists() and zip_mode == 'r':
+        if zip_mode == 'r' and not self.exists():
             raise FileNotFoundError(self)
         stream = self.root.open(self.at, zip_mode, pwd=pwd)
         if 'b' in mode:

Misc/NEWS.d/next/Library/2024-11-08-11-06-14.gh-issue-126565.dFFO22.rst

@@ -0,0 +1 @@
+Improve performances of :meth:`zipfile.Path.open` for non-reading modes.