Skip to content

Commit 8f322ad

Browse files
[3.14] pythongh-139951: Tests on tuple GC tracking (pythonGH-140575) (python#140701)
1 parent 52338ec commit 8f322ad

File tree

2 files changed

+37
-6
lines changed

2 files changed

+37
-6
lines changed

Lib/test/test_capi/test_tuple.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ class TupleSubclass(tuple):
1414

1515

1616
class CAPITest(unittest.TestCase):
17+
def _not_tracked(self, t):
18+
self.assertFalse(gc.is_tracked(t), t)
19+
20+
def _tracked(self, t):
21+
self.assertTrue(gc.is_tracked(t), t)
22+
1723
def test_check(self):
1824
# Test PyTuple_Check()
1925
check = _testlimitedcapi.tuple_check
@@ -52,11 +58,14 @@ def test_tuple_new(self):
5258
self.assertEqual(tup1, ())
5359
self.assertEqual(size(tup1), 0)
5460
self.assertIs(type(tup1), tuple)
61+
self._not_tracked(tup1)
62+
5563
tup2 = tuple_new(1)
5664
self.assertIs(type(tup2), tuple)
5765
self.assertEqual(size(tup2), 1)
5866
self.assertIsNot(tup2, tup1)
5967
self.assertTrue(checknull(tup2, 0))
68+
self._tracked(tup2)
6069

6170
self.assertRaises(SystemError, tuple_new, -1)
6271
self.assertRaises(SystemError, tuple_new, PY_SSIZE_T_MIN)
@@ -70,6 +79,10 @@ def test_tuple_pack(self):
7079
self.assertEqual(pack(1, [1]), ([1],))
7180
self.assertEqual(pack(2, [1], [2]), ([1], [2]))
7281

82+
self._tracked(pack(1, [1]))
83+
self._tracked(pack(2, [1], b'abc'))
84+
self._not_tracked(pack(2, 42, b'abc'))
85+
7386
self.assertRaises(SystemError, pack, PY_SSIZE_T_MIN)
7487
self.assertRaises(SystemError, pack, -1)
7588
self.assertRaises(MemoryError, pack, PY_SSIZE_T_MAX)

Lib/test/test_tuple.py

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,12 +290,18 @@ def test_repr(self):
290290
self.assertEqual(repr(a0), "()")
291291
self.assertEqual(repr(a2), "(0, 1, 2)")
292292

293+
# Checks that t is not tracked without any GC collections.
294+
def _not_tracked_instantly(self, t):
295+
self.assertFalse(gc.is_tracked(t), t)
296+
297+
# Checks that t is not tracked after GC collection.
293298
def _not_tracked(self, t):
294299
# Nested tuples can take several collections to untrack
295300
gc.collect()
296301
gc.collect()
297302
self.assertFalse(gc.is_tracked(t), t)
298303

304+
# Checks that t continues to be tracked even after GC collection.
299305
def _tracked(self, t):
300306
self.assertTrue(gc.is_tracked(t), t)
301307
gc.collect()
@@ -307,13 +313,19 @@ def test_track_literals(self):
307313
# Test GC-optimization of tuple literals
308314
x, y, z = 1.5, "a", []
309315

310-
self._not_tracked(())
311-
self._not_tracked((1,))
312-
self._not_tracked((1, 2))
313-
self._not_tracked((1, 2, "a"))
314-
self._not_tracked((1, 2, (None, True, False, ()), int))
315-
self._not_tracked((object(),))
316+
# We check that those objects aren't tracked at all.
317+
# It's essential for the GC performance, see gh-139951.
318+
self._not_tracked_instantly(())
319+
self._not_tracked_instantly((1,))
320+
self._not_tracked_instantly((1, 2))
321+
self._not_tracked_instantly((1, 2, "a"))
322+
self._not_tracked_instantly((1, 2) * 5)
323+
self._not_tracked_instantly((12, 10**10, 'a_' * 100))
324+
self._not_tracked_instantly((object(),))
325+
316326
self._not_tracked(((1, x), y, (2, 3)))
327+
self._not_tracked((1, 2, (None, True, False, ()), int))
328+
self._not_tracked((object(), ()))
317329

318330
# Tuples with mutable elements are always tracked, even if those
319331
# elements are not tracked right now.
@@ -343,6 +355,12 @@ def check_track_dynamic(self, tp, always_track):
343355
self._tracked(tp(tuple([obj]) for obj in [x, y, z]))
344356
self._tracked(tuple(tp([obj]) for obj in [x, y, z]))
345357

358+
t = tp([1, x, y, z])
359+
self.assertEqual(type(t), tp)
360+
self._tracked(t)
361+
self.assertEqual(type(t[:]), tuple)
362+
self._tracked(t[:])
363+
346364
@support.cpython_only
347365
def test_track_dynamic(self):
348366
# Test GC-optimization of dynamically constructed tuples.

0 commit comments

Comments
 (0)