Skip to content

Commit 6c6b28a

Browse files
authored
Merge pull request #607 from bosh/remove_special_apostrophes
replace special apostrophe and single quote characters with ascii '
2 parents 25e66a4 + ec8481e commit 6c6b28a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

86 files changed

+367
-364
lines changed

docs/code/BCP_Protocol/ball_end.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
## ball_end (BCP command)
33

4-
Indicates the ball has ended. Note that this does not necessarily mean that the next players turn will start, as this player may have an extra ball which means theyll shoot again.
4+
Indicates the ball has ended. Note that this does not necessarily mean that the next player's turn will start, as this player may have an extra ball which means they'll shoot again.
55

66
## Origin
77
Pin controller

docs/code/BCP_Protocol/goodbye.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
# goodbye (BCP command)
3-
Lets one side tell the other than its shutting down.
3+
Lets one side tell the other than it's shutting down.
44

55
## Origin
66
Pin controller or media controller

docs/code/BCP_Protocol/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ This document describes the Backbox Control Protocol, (or “BCP”), a simple,
77

88
BCP is how the MPF core engine and the MPF media controller communicate.
99

10-
BCP transmits semantically relevant information and attempts to isolate specific behaviors and identifiers on both sides. i.e., the pin controller is responsible for telling the media controller “start multiball mode”. The pin controller doesnt care what the media controller does with that information, and the media controller doesnt care what happened on the pin controller that caused the multiball mode to start.
10+
BCP transmits semantically relevant information and attempts to isolate specific behaviors and identifiers on both sides. i.e., the pin controller is responsible for telling the media controller “start multiball mode”. The pin controller doesn't care what the media controller does with that information, and the media controller doesn't care what happened on the pin controller that caused the multiball mode to start.
1111

1212
BCP is versioned to prevent conflicts. Future versions of the BCP will be designed to be backward compatible to every degree possible. The reference implementation uses a raw TCP socket for communication. On localhost the latency is usually sub-millisecond and on LANs it is under 10 milliseconds. That means that the effect of messages is generally under 1/100th of a second, which should be considered instantaneous from the perspective of human perception.
1313

14-
It is important to note that this document specifies the details of the protocol itself, not necessarily the behaviors of any specific implementations it connects. Thus, there wont be details about fonts or sounds or images or videos or shaders here; those are up to specific implementation being driven.
14+
It is important to note that this document specifies the details of the protocol itself, not necessarily the behaviors of any specific implementations it connects. Thus, there won't be details about fonts or sounds or images or videos or shaders here; those are up to specific implementation being driven.
1515

1616
!!! warning "Infinite Loops Possible"
1717

docs/code/BCP_Protocol/mode_start.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
# mode_start (BCP command)
3-
A game mode has just started. The mode is passed via the name parameter, and the modes priority is passed as an integer via the priority.
3+
A game mode has just started. The mode is passed via the name parameter, and the mode's priority is passed as an integer via the priority.
44

55
## Origin
66
Pin controller

docs/code/BCP_Protocol/player_turn_start.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
# player_turn_start (BCP command)
3-
A new players turn has begun. If a player has an extra ball, this command will not be sent between balls. However, a new ball_start command will be sent when the same players additional balls start.
3+
A new player's turn has begun. If a player has an extra ball, this command will not be sent between balls. However, a new ball_start command will be sent when the same player's additional balls start.
44

55
## Origin
66
Pin controller

docs/code/BCP_Protocol/player_variable.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
# player_variable (BCP command)
33

4-
This is a generic “catch all” which sends player-specific variables to the media controller any time they change. Since the pin controller will most likely track hundreds of variables per player (with many being internal things that the media controller doesnt care about), its recommended that the pin controller has a way to filter which player variables are sent to the media controller. Also note the parameter player_num indicates which player this variable is for (starting with 1 for the first player). While its usually the case that the player_variable command will be sent for the player whose turn it is, thats not always the case. (For example, when a second player is added during the first players ball, the second players default variables will be initialized at 0 and a player_variable event for player 2 will be sent even though player 1 is up.
4+
This is a generic “catch all” which sends player-specific variables to the media controller any time they change. Since the pin controller will most likely track hundreds of variables per player (with many being internal things that the media controller doesn't care about), it's recommended that the pin controller has a way to filter which player variables are sent to the media controller. Also note the parameter player_num indicates which player this variable is for (starting with 1 for the first player). While it's usually the case that the player_variable command will be sent for the player whose turn it is, that's not always the case. (For example, when a second player is added during the first player's ball, the second player's default variables will be initialized at 0 and a player_variable event for player 2 will be sent even though player 1 is up.
55

66
## Origin
77
Pin controller
@@ -30,7 +30,7 @@ This is the previous value of the player variable.
3030
### change
3131
Type: Varies depending upon the variable type.
3232

33-
If the player variable just changed, this will be the amount of the change. If its not possible to determine a numeric change (for example, if this player variable is a string), then this change value will be set to the boolean True.
33+
If the player variable just changed, this will be the amount of the change. If it's not possible to determine a numeric change (for example, if this player variable is a string), then this change value will be set to the boolean True.
3434

3535
## Response
3636
None

docs/code/BCP_Protocol/switch.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ followed very quickly by
1111
switch?name=start&state=0
1212
```
1313

14-
When sent from the pin controller to the media controller, this is used to send switch inputs to things like video modes, high score name entry, and service menu navigation. Note that the pin controller should not send the state of every switch change at all times, as the media controller doesnt need it and that would add lots of unnecessary commands. Instead the pin controller should only send switches based on some mode of operation that needs them. (For example, when the video mode starts, the pin controller would start sending the switch states of the flipper buttons, and when the video mode ends, it would stop.)
14+
When sent from the pin controller to the media controller, this is used to send switch inputs to things like video modes, high score name entry, and service menu navigation. Note that the pin controller should not send the state of every switch change at all times, as the media controller doesn't need it and that would add lots of unnecessary commands. Instead the pin controller should only send switches based on some mode of operation that needs them. (For example, when the video mode starts, the pin controller would start sending the switch states of the flipper buttons, and when the video mode ends, it would stop.)
1515

1616
## Origin
1717
Pin controller or media controller

docs/code/Writing_Tests/RunUnitTests.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ Once MPF is installed, you can run some automated tests to make sure that everyt
77
python3 -m unittest discover mpf/tests
88
```
99

10-
When you do this, you should see a bunch of dots on the screen (one for each test thats run), and then when its done, you should see a message showing how many tests were run and that they were successful. The whole process should take less a minute or so.
10+
When you do this, you should see a bunch of dots on the screen (one for each test that's run), and then when it's done, you should see a message showing how many tests were run and that they were successful. The whole process should take less a minute or so.
1111

12-
(If you see any messages about some tests taking more than 0.5s, thats ok.)
12+
(If you see any messages about some tests taking more than 0.5s, that's ok.)
1313

1414
The important thing is that when the tests are done, you should have a message like this:
1515

@@ -21,11 +21,11 @@ OK
2121
C:\>
2222
```
2323

24-
Note that the number of tests is changing all the time, so it probably wont be exactly 587. And also the time they took to run will be different depending on how fast your computer is.
24+
Note that the number of tests is changing all the time, so it probably won't be exactly 587. And also the time they took to run will be different depending on how fast your computer is.
2525

26-
These tests are the actual tests that the developers of MPF use to test MPF itself. We wrote all these tests to make sure that updates and changes we add to MPF dont break things. :) So if these tests pass, you know your MPF installation is solid.
26+
These tests are the actual tests that the developers of MPF use to test MPF itself. We wrote all these tests to make sure that updates and changes we add to MPF don't break things. :) So if these tests pass, you know your MPF installation is solid.
2727

28-
Remember though that MPF is actually two separate parts, the MPF game engine and the MPF media controller. The command you run just tested the game engine, so now lets test the media controller. To do this, run the following command (basically the same thing as last time but with an “mc” added to the end, like this):
28+
Remember though that MPF is actually two separate parts, the MPF game engine and the MPF media controller. The command you run just tested the game engine, so now let's test the media controller. To do this, run the following command (basically the same thing as last time but with an “mc” added to the end, like this):
2929

3030
``` console
3131
python3 -m unittest discover mpfmc/tests
@@ -35,11 +35,11 @@ python3 -m unittest discover mpfmc/tests
3535

3636
When you run the MPF-MC tests, you should see a graphical window pop up on the screen, and many of the tests will put graphics and words in that window. Also, some of the tests include audio, so if your speakers are on you should hear some sounds at some point.
3737

38-
These tests take significantly longer (maybe 8x) than the MPF tests, but when theyre done, that graphical window should close, and youll see all the dots in your command window and a note that all the tests were successful.
38+
These tests take significantly longer (maybe 8x) than the MPF tests, but when they're done, that graphical window should close, and you'll see all the dots in your command window and a note that all the tests were successful.
3939

4040
Notes about the MPF-MC tests:
4141

42-
* These tests create a window on the screen and then just re-use the same window for all tests (to save time). So dont worry if it looks like the window content is scaled weird or blurry or doesnt fill the entire window.
42+
* These tests create a window on the screen and then just re-use the same window for all tests (to save time). So don't worry if it looks like the window content is scaled weird or blurry or doesn't fill the entire window.
4343
* Many of these tests are used to test internal workings of the media controller itself, so there will be lots of time when the pop up window is blank or appears frozen since the tests are testing non-visual things.
44-
* The animation and transition tests include testing functionality to stop, restart, pause, and skip frames. So if things look “jerky” in the tests, dont worry, that doesnt mean your computer is slow, its just how the tests work! :)
44+
* The animation and transition tests include testing functionality to stop, restart, pause, and skip frames. So if things look “jerky” in the tests, don't worry, that doesn't mean your computer is slow, it's just how the tests work! :)
4545

0 commit comments

Comments
 (0)