Skip to content

fix(frontend): mCaptchaが動作しない問題を修正#17127

Merged
syuilo merged 3 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-17107
Jan 28, 2026
Merged

fix(frontend): mCaptchaが動作しない問題を修正#17127
syuilo merged 3 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-17107

Conversation

@kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 27, 2026

What

mCaptchaとのやり取りをより低レベルなライブラリを使用するようにし、描画自体(iframeを出すの自体)はVueで行うように

Why

Fix #17107

Additional info (optional)

demo.mcaptcha.org (v0.1.0-b215a411) で動作することを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 27, 2026
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 27, 2026
@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft January 27, 2026 10:21
@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review January 27, 2026 10:23
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.84%. Comparing base (cdb958c) to head (d7a40d6).
⚠️ Report is 53 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17127      +/-   ##
===========================================
- Coverage    14.03%   13.84%   -0.19%     
===========================================
  Files          238      241       +3     
  Lines        11296    11663     +367     
  Branches      3736     3945     +209     
===========================================
+ Hits          1585     1615      +30     
- Misses        7586     7883     +297     
- Partials      2125     2165      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@syuilo syuilo merged commit 4910fff into misskey-dev:develop Jan 28, 2026
22 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Jan 28, 2026
@syuilo
Copy link
Member

syuilo commented Jan 28, 2026

🙏🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-17107 branch January 28, 2026 03:04
m10i-0nyx pushed a commit to foundation0-link/misskey that referenced this pull request Feb 7, 2026
* fix(frontend): mCaptchaが動作しない問題を修正

* Update Changelog

* remove mcaptcha vanila glue
m10i-0nyx pushed a commit to foundation0-link/misskey that referenced this pull request Feb 7, 2026
* fix(frontend): mCaptchaが動作しない問題を修正

* Update Changelog

* remove mcaptcha vanila glue
m10i-0nyx pushed a commit to foundation0-link/misskey that referenced this pull request Feb 7, 2026
* fix(frontend): mCaptchaが動作しない問題を修正

* Update Changelog

* remove mcaptcha vanila glue
m10i-0nyx pushed a commit to foundation0-link/misskey that referenced this pull request Feb 7, 2026
* fix(frontend): mCaptchaが動作しない問題を修正

* Update Changelog

* remove mcaptcha vanila glue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

cannot login anymore with mcaptcha

2 participants