-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(backend): inconsistent permissions for /admin/get-user-ips #17136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kakkokari-gtyih
merged 2 commits into
misskey-dev:develop
from
KenCir:fix/admin-get-user-ips-permissions
Jan 31, 2026
Merged
fix(backend): inconsistent permissions for /admin/get-user-ips #17136
kakkokari-gtyih
merged 2 commits into
misskey-dev:develop
from
KenCir:fix/admin-get-user-ips-permissions
Jan 31, 2026
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
このPRによるapi.jsonの差分 |
Contributor
Backend memory usage comparisonBefore GC
After GC
After Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17136 +/- ##
===========================================
- Coverage 63.52% 63.49% -0.04%
===========================================
Files 1161 1161
Lines 115939 115939
Branches 7684 8351 +667
===========================================
- Hits 73655 73618 -37
- Misses 40078 40114 +36
- Partials 2206 2207 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
🙏 |
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 31, 2026
commit 3c0356c Author: fruitriin <[email protected]> Date: Sun Feb 1 00:36:38 2026 +0900 デフォルト無効 commit c29f172 Author: fruitriin <[email protected]> Date: Sun Feb 1 00:33:15 2026 +0900 バージョンの変更を戻す commit 9627567 Author: fruitriin <[email protected]> Date: Sun Feb 1 00:32:49 2026 +0900 カレンダーから日付を選択 commit 8225396 Author: fruitriin <[email protected]> Date: Sun Feb 1 00:22:13 2026 +0900 ポリシー commit 014ee99 Author: fruitriin <[email protected]> Date: Sat Jan 31 23:01:02 2026 +0900 遷移の入口を作成 commit 0592b48 Author: fruitriin <[email protected]> Date: Sat Jan 31 22:41:07 2026 +0900 useTimemacine リファクタリング commit 42db5b8 Author: fruitriin <[email protected]> Date: Sat Jan 31 22:20:40 2026 +0900 UI調整 commit 5761c05 Author: fruitriin <[email protected]> Date: Sat Jan 31 22:01:14 2026 +0900 fix scroll position commit b771468 Author: fruitriin <[email protected]> Date: Sat Jan 31 19:48:41 2026 +0900 fix duplicated timemachine commit 9711054 Author: fruitriin <[email protected]> Date: Sat Jan 31 19:36:53 2026 +0900 コンポーネント分割 commit c4e6d17 Author: fruitriin <[email protected]> Date: Sat Jan 31 19:28:03 2026 +0900 perf type commit db0c35d Author: fruitriin <[email protected]> Date: Sat Jan 31 17:54:36 2026 +0900 UI調整 commit 7db7835 Author: fruitriin <[email protected]> Date: Sat Jan 31 15:09:27 2026 +0900 タイムシフトリアーキテクチャ commit f030eaf Author: fruitriin <[email protected]> Date: Sat Jan 31 15:02:05 2026 +0900 perf timeshift commit 78bf5fd Author: fruitriin <[email protected]> Date: Sat Jan 31 15:01:50 2026 +0900 fix MkA commit d3571f1 Author: fruitriin <[email protected]> Date: Sat Jan 31 14:15:09 2026 +0900 タイムフュージョン commit 2841a48 Author: fruitriin <[email protected]> Date: Fri Jan 30 23:58:24 2026 +0900 type safe timemachine commit d54466a Author: fruitriin <[email protected]> Date: Fri Jan 30 23:09:54 2026 +0900 MkTimemachineNoteTimeline commit 8746a43 Author: fruitriin <[email protected]> Date: Fri Jan 30 22:57:42 2026 +0900 TimeshiftPaginator commit 52a9eb9 Author: fruitriin <[email protected]> Date: Fri Jan 30 22:38:07 2026 +0900 /timemachineをログイン必須、タイムマシン中絶対時間 commit e03fa65 Author: FruitRiin <[email protected]> Date: Thu Nov 6 16:18:50 2025 +0900 UI改善、pull to refreash対応、 タイムマシン前に相対時間の確認 commit 7fc223e Author: FruitRiin <[email protected]> Date: Thu Nov 6 13:24:43 2025 +0900 タイムシフト commit 8171ad0 Author: FruitRiin <[email protected]> Date: Thu Nov 6 12:48:03 2025 +0900 タイム回路を開閉するように commit 7cc759d Author: FruitRiin <[email protected]> Date: Thu Nov 6 12:41:08 2025 +0900 タイムラインソースの追加 commit a08b50e Author: FruitRiin <[email protected]> Date: Wed Nov 5 22:46:29 2025 +0900 なんか動いてるような気がする commit 5795406 Author: FruitRiin <[email protected]> Date: Wed Nov 5 22:12:46 2025 +0900 デフォルト値を現在の時刻 commit ab00d7f Author: FruitRiin <[email protected]> Date: Wed Nov 5 22:04:24 2025 +0900 FanoutTimelineがuntilIdを尊重しないバグの修正 commit c440612 Author: FruitRiin <[email protected]> Date: Wed Nov 5 20:48:15 2025 +0900 feat(frontend): add load newer functionality to time machine - Replace i18n strings with plain English text - Add "Load newer notes" button to timeline view - Implement fetchNewer() to load notes from selected time forward - Clean up unused imports (onMounted, useTemplateRef, misskeyApi, withSensitive) - Add state management for loading status and newest note tracking 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> commit ac7aaab Author: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Date: Wed Nov 5 06:41:17 2025 +0000 feat: タイムマシン機能の追加 任意の日時からソーシャルタイムラインを閲覧できる機能を追加しました。 - /timemachine ルートに専用ページを追加 - 日時ピッカーで過去の特定時点を指定可能 - ソーシャルタイムライン(notes/hybrid-timeline)を使用 - PaginatorのinitialDateパラメータで時間指定を実現 Related to #21 Co-authored-by: 果物リン <[email protected]> commit 65e5146 Author: かっこかり <[email protected]> Date: Sat Jan 31 22:38:16 2026 +0900 fix(frontend): CSSの指定が誤っている問題を修正 (misskey-dev#17135) commit 39362f7 Author: Ken_Cir <[email protected]> Date: Sat Jan 31 22:37:48 2026 +0900 fix(backend): inconsistent permissions for /admin/get-user-ips (misskey-dev#17136) * fix(backend): inconsistent permissions for /admin/get-user-ips * Update Changelog
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 31, 2026
Squashed commit of the following: commit 3c0356c Author: fruitriin <[email protected]> Date: Sun Feb 1 00:36:38 2026 +0900 デフォルト無効 commit c29f172 Author: fruitriin <[email protected]> Date: Sun Feb 1 00:33:15 2026 +0900 バージョンの変更を戻す commit 9627567 Author: fruitriin <[email protected]> Date: Sun Feb 1 00:32:49 2026 +0900 カレンダーから日付を選択 commit 8225396 Author: fruitriin <[email protected]> Date: Sun Feb 1 00:22:13 2026 +0900 ポリシー commit 014ee99 Author: fruitriin <[email protected]> Date: Sat Jan 31 23:01:02 2026 +0900 遷移の入口を作成 commit 0592b48 Author: fruitriin <[email protected]> Date: Sat Jan 31 22:41:07 2026 +0900 useTimemacine リファクタリング commit 42db5b8 Author: fruitriin <[email protected]> Date: Sat Jan 31 22:20:40 2026 +0900 UI調整 commit 5761c05 Author: fruitriin <[email protected]> Date: Sat Jan 31 22:01:14 2026 +0900 fix scroll position commit b771468 Author: fruitriin <[email protected]> Date: Sat Jan 31 19:48:41 2026 +0900 fix duplicated timemachine commit 9711054 Author: fruitriin <[email protected]> Date: Sat Jan 31 19:36:53 2026 +0900 コンポーネント分割 commit c4e6d17 Author: fruitriin <[email protected]> Date: Sat Jan 31 19:28:03 2026 +0900 perf type commit db0c35d Author: fruitriin <[email protected]> Date: Sat Jan 31 17:54:36 2026 +0900 UI調整 commit 7db7835 Author: fruitriin <[email protected]> Date: Sat Jan 31 15:09:27 2026 +0900 タイムシフトリアーキテクチャ commit f030eaf Author: fruitriin <[email protected]> Date: Sat Jan 31 15:02:05 2026 +0900 perf timeshift commit 78bf5fd Author: fruitriin <[email protected]> Date: Sat Jan 31 15:01:50 2026 +0900 fix MkA commit d3571f1 Author: fruitriin <[email protected]> Date: Sat Jan 31 14:15:09 2026 +0900 タイムフュージョン commit 2841a48 Author: fruitriin <[email protected]> Date: Fri Jan 30 23:58:24 2026 +0900 type safe timemachine commit d54466a Author: fruitriin <[email protected]> Date: Fri Jan 30 23:09:54 2026 +0900 MkTimemachineNoteTimeline commit 8746a43 Author: fruitriin <[email protected]> Date: Fri Jan 30 22:57:42 2026 +0900 TimeshiftPaginator commit 52a9eb9 Author: fruitriin <[email protected]> Date: Fri Jan 30 22:38:07 2026 +0900 /timemachineをログイン必須、タイムマシン中絶対時間 commit e03fa65 Author: FruitRiin <[email protected]> Date: Thu Nov 6 16:18:50 2025 +0900 UI改善、pull to refreash対応、 タイムマシン前に相対時間の確認 commit 7fc223e Author: FruitRiin <[email protected]> Date: Thu Nov 6 13:24:43 2025 +0900 タイムシフト commit 8171ad0 Author: FruitRiin <[email protected]> Date: Thu Nov 6 12:48:03 2025 +0900 タイム回路を開閉するように commit 7cc759d Author: FruitRiin <[email protected]> Date: Thu Nov 6 12:41:08 2025 +0900 タイムラインソースの追加 commit a08b50e Author: FruitRiin <[email protected]> Date: Wed Nov 5 22:46:29 2025 +0900 なんか動いてるような気がする commit 5795406 Author: FruitRiin <[email protected]> Date: Wed Nov 5 22:12:46 2025 +0900 デフォルト値を現在の時刻 commit ab00d7f Author: FruitRiin <[email protected]> Date: Wed Nov 5 22:04:24 2025 +0900 FanoutTimelineがuntilIdを尊重しないバグの修正 commit c440612 Author: FruitRiin <[email protected]> Date: Wed Nov 5 20:48:15 2025 +0900 feat(frontend): add load newer functionality to time machine - Replace i18n strings with plain English text - Add "Load newer notes" button to timeline view - Implement fetchNewer() to load notes from selected time forward - Clean up unused imports (onMounted, useTemplateRef, misskeyApi, withSensitive) - Add state management for loading status and newest note tracking 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> commit ac7aaab Author: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Date: Wed Nov 5 06:41:17 2025 +0000 feat: タイムマシン機能の追加 任意の日時からソーシャルタイムラインを閲覧できる機能を追加しました。 - /timemachine ルートに専用ページを追加 - 日時ピッカーで過去の特定時点を指定可能 - ソーシャルタイムライン(notes/hybrid-timeline)を使用 - PaginatorのinitialDateパラメータで時間指定を実現 Related to #21 Co-authored-by: 果物リン <[email protected]> commit 65e5146 Author: かっこかり <[email protected]> Date: Sat Jan 31 22:38:16 2026 +0900 fix(frontend): CSSの指定が誤っている問題を修正 (misskey-dev#17135) commit 39362f7 Author: Ken_Cir <[email protected]> Date: Sat Jan 31 22:37:48 2026 +0900 fix(backend): inconsistent permissions for /admin/get-user-ips (misskey-dev#17136) * fix(backend): inconsistent permissions for /admin/get-user-ips * Update Changelog
fruitriin
added a commit
to mistems/mistems
that referenced
this pull request
Jan 31, 2026
commit 3c0356c Author: fruitriin <[email protected]> Date: Sun Feb 1 00:36:38 2026 +0900 デフォルト無効 commit c29f172 Author: fruitriin <[email protected]> Date: Sun Feb 1 00:33:15 2026 +0900 バージョンの変更を戻す commit 9627567 Author: fruitriin <[email protected]> Date: Sun Feb 1 00:32:49 2026 +0900 カレンダーから日付を選択 commit 8225396 Author: fruitriin <[email protected]> Date: Sun Feb 1 00:22:13 2026 +0900 ポリシー commit 014ee99 Author: fruitriin <[email protected]> Date: Sat Jan 31 23:01:02 2026 +0900 遷移の入口を作成 commit 0592b48 Author: fruitriin <[email protected]> Date: Sat Jan 31 22:41:07 2026 +0900 useTimemacine リファクタリング commit 42db5b8 Author: fruitriin <[email protected]> Date: Sat Jan 31 22:20:40 2026 +0900 UI調整 commit 5761c05 Author: fruitriin <[email protected]> Date: Sat Jan 31 22:01:14 2026 +0900 fix scroll position commit b771468 Author: fruitriin <[email protected]> Date: Sat Jan 31 19:48:41 2026 +0900 fix duplicated timemachine commit 9711054 Author: fruitriin <[email protected]> Date: Sat Jan 31 19:36:53 2026 +0900 コンポーネント分割 commit c4e6d17 Author: fruitriin <[email protected]> Date: Sat Jan 31 19:28:03 2026 +0900 perf type commit db0c35d Author: fruitriin <[email protected]> Date: Sat Jan 31 17:54:36 2026 +0900 UI調整 commit 7db7835 Author: fruitriin <[email protected]> Date: Sat Jan 31 15:09:27 2026 +0900 タイムシフトリアーキテクチャ commit f030eaf Author: fruitriin <[email protected]> Date: Sat Jan 31 15:02:05 2026 +0900 perf timeshift commit 78bf5fd Author: fruitriin <[email protected]> Date: Sat Jan 31 15:01:50 2026 +0900 fix MkA commit d3571f1 Author: fruitriin <[email protected]> Date: Sat Jan 31 14:15:09 2026 +0900 タイムフュージョン commit 2841a48 Author: fruitriin <[email protected]> Date: Fri Jan 30 23:58:24 2026 +0900 type safe timemachine commit d54466a Author: fruitriin <[email protected]> Date: Fri Jan 30 23:09:54 2026 +0900 MkTimemachineNoteTimeline commit 8746a43 Author: fruitriin <[email protected]> Date: Fri Jan 30 22:57:42 2026 +0900 TimeshiftPaginator commit 52a9eb9 Author: fruitriin <[email protected]> Date: Fri Jan 30 22:38:07 2026 +0900 /timemachineをログイン必須、タイムマシン中絶対時間 commit e03fa65 Author: FruitRiin <[email protected]> Date: Thu Nov 6 16:18:50 2025 +0900 UI改善、pull to refreash対応、 タイムマシン前に相対時間の確認 commit 7fc223e Author: FruitRiin <[email protected]> Date: Thu Nov 6 13:24:43 2025 +0900 タイムシフト commit 8171ad0 Author: FruitRiin <[email protected]> Date: Thu Nov 6 12:48:03 2025 +0900 タイム回路を開閉するように commit 7cc759d Author: FruitRiin <[email protected]> Date: Thu Nov 6 12:41:08 2025 +0900 タイムラインソースの追加 commit a08b50e Author: FruitRiin <[email protected]> Date: Wed Nov 5 22:46:29 2025 +0900 なんか動いてるような気がする commit 5795406 Author: FruitRiin <[email protected]> Date: Wed Nov 5 22:12:46 2025 +0900 デフォルト値を現在の時刻 commit ab00d7f Author: FruitRiin <[email protected]> Date: Wed Nov 5 22:04:24 2025 +0900 FanoutTimelineがuntilIdを尊重しないバグの修正 commit c440612 Author: FruitRiin <[email protected]> Date: Wed Nov 5 20:48:15 2025 +0900 feat(frontend): add load newer functionality to time machine - Replace i18n strings with plain English text - Add "Load newer notes" button to timeline view - Implement fetchNewer() to load notes from selected time forward - Clean up unused imports (onMounted, useTemplateRef, misskeyApi, withSensitive) - Add state management for loading status and newest note tracking 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> commit ac7aaab Author: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Date: Wed Nov 5 06:41:17 2025 +0000 feat: タイムマシン機能の追加 任意の日時からソーシャルタイムラインを閲覧できる機能を追加しました。 - /timemachine ルートに専用ページを追加 - 日時ピッカーで過去の特定時点を指定可能 - ソーシャルタイムライン(notes/hybrid-timeline)を使用 - PaginatorのinitialDateパラメータで時間指定を実現 Related to #21 Co-authored-by: 果物リン <[email protected]> commit 65e5146 Author: かっこかり <[email protected]> Date: Sat Jan 31 22:38:16 2026 +0900 fix(frontend): CSSの指定が誤っている問題を修正 (misskey-dev#17135) commit 39362f7 Author: Ken_Cir <[email protected]> Date: Sat Jan 31 22:37:48 2026 +0900 fix(backend): inconsistent permissions for /admin/get-user-ips (misskey-dev#17136) * fix(backend): inconsistent permissions for /admin/get-user-ips * Update Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
packages/backend
Server side specific issue/PR
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
/admin/get-user-ipsエンドポイントのAPI Meta定義の権限をrequireModeratorからrequireAdminに修正fixed: #16507
Why
モデレーターはWebUIでユーザーIPアクセスできないため
misskey/packages/frontend/src/pages/admin-user.vue
Lines 116 to 123 in d215421
Additional info (optional)
Checklist