fix(frontend): ノートの詳細表示でリアクション一覧が全件表示されない問題を修正#17137
Merged
syuilo merged 2 commits intomisskey-dev:developfrom Feb 2, 2026
Merged
fix(frontend): ノートの詳細表示でリアクション一覧が全件表示されない問題を修正#17137syuilo merged 2 commits intomisskey-dev:developfrom
syuilo merged 2 commits intomisskey-dev:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17137 +/- ##
============================================
- Coverage 63.62% 13.84% -49.78%
============================================
Files 1161 241 -920
Lines 115939 11663 -104276
Branches 8378 3945 -4433
============================================
- Hits 73762 1615 -72147
+ Misses 39971 7883 -32088
+ Partials 2206 2165 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
書いてあるとおり
Why
もともとは全件表示される仕様だったため
8c2ab25 でこの変更が導入されているが、この際MkReactionViewerの参照がまるごとMkNoteからコピペされているように見受けられる(MkNoteDetailedには存在しないmockUpdateMyReaction eventのリスナーがある)ため、意図的な変更ではないと判断して戻した。
Additional info (optional)
Checklist