chore: execute "tsc" on lint phase

mistic100 · mistic100 · commit 4162ef09c6f0 · 2023-11-23T09:58:29.000+01:00
diff --git a/package.json b/package.json
@@ -52,6 +52,7 @@
     "stylelint-config-standard-scss": "^11.1.0",
     "stylelint-stylistic": "^0.4.3",
     "ts-node": "^10.9.1",
+    "tsc": "^2.0.4",
     "tsup": "^7.3.0",
     "turbo": "^1.10.0",
     "typedoc": "^0.25.0",
diff --git a/packages/autorotate-plugin/package.json b/packages/autorotate-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/compass-plugin/package.json b/packages/compass-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix && stylelint \"src/**/*.scss\" --fix",
+    "lint": "tsc --noEmit && eslint . --fix && stylelint \"src/**/*.scss\" --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/compass-plugin/src/components/CompassComponent.ts b/packages/compass-plugin/src/components/CompassComponent.ts
@@ -93,7 +93,7 @@ export class CompassComponent extends AbstractComponent {
         this.container.className = `psv-compass psv-compass--${this.config.position.join('-')}`;
 
         if (this.config.className) {
-            utils.addClasses(this.container, this.config.className);
+            this.container.classList.add(this.config.className);
         }
 
         this.background.innerHTML = this.config.backgroundSvg;
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix && stylelint \"src/**/*.scss\" --fix",
+    "lint": "tsc --noEmit && eslint . --fix && stylelint \"src/**/*.scss\" --fix",
     "test": "mocha -r ts-node/register \"src/**/*.spec.ts\"",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
diff --git a/packages/core/tsconfig.json b/packages/core/tsconfig.json
@@ -1,5 +1,5 @@
 {
   "extends": "../../tsconfig.json",
   "include": ["src/**/*.ts", "../shared/typings.d.ts"],
-  "exclude": ["dist", "node_modules"]
+  "exclude": ["dist", "node_modules", "src/**/*.spec.ts"]
 }
diff --git a/packages/cubemap-adapter/package.json b/packages/cubemap-adapter/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/cubemap-tiles-adapter/package.json b/packages/cubemap-tiles-adapter/package.json
@@ -13,7 +13,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/cubemap-video-adapter/package.json b/packages/cubemap-video-adapter/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/equirectangular-tiles-adapter/package.json b/packages/equirectangular-tiles-adapter/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/equirectangular-video-adapter/package.json b/packages/equirectangular-video-adapter/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/gallery-plugin/package.json b/packages/gallery-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix && stylelint \"src/**/*.scss\" --fix",
+    "lint": "tsc --noEmit && eslint . --fix && stylelint \"src/**/*.scss\" --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/gyroscope-plugin/package.json b/packages/gyroscope-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/little-planet-adapter/package.json b/packages/little-planet-adapter/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/map-plugin/package.json b/packages/map-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix && stylelint \"src/**/*.scss\" --fix",
+    "lint": "tsc --noEmit && eslint . --fix && stylelint \"src/**/*.scss\" --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/markers-plugin/package.json b/packages/markers-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix && stylelint \"src/**/*.scss\" --fix",
+    "lint": "tsc --noEmit && eslint . --fix && stylelint \"src/**/*.scss\" --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/overlays-plugin/package.json b/packages/overlays-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/resolution-plugin/package.json b/packages/resolution-plugin/package.json
@@ -13,7 +13,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/settings-plugin/package.json b/packages/settings-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix && stylelint \"src/**/*.scss\" --fix",
+    "lint": "tsc --noEmit && eslint . --fix && stylelint \"src/**/*.scss\" --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -9,7 +9,7 @@
   },
   "scripts": {
     "build:test": "tsup --define.dts=off",
-    "lint": "eslint . --fix && stylelint \"*.scss\" --fix",
+    "lint": "tsc --noEmit && eslint . --fix && stylelint \"*.scss\" --fix",
     "test": "mocha -r ts-node/register \"*.spec.ts\""
   },
   "psv": {
diff --git a/packages/shared/tsconfig.json b/packages/shared/tsconfig.json
@@ -1,5 +1,5 @@
 {
   "extends": "../../tsconfig.json",
   "include": ["*.ts"],
-  "exclude": ["dist", "node_modules"]
+  "exclude": ["dist", "node_modules", "**/*.spec.ts"]
 }
diff --git a/packages/stereo-plugin/package.json b/packages/stereo-plugin/package.json
@@ -13,7 +13,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/video-plugin/package.json b/packages/video-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix && stylelint \"src/**/*.scss\" --fix",
+    "lint": "tsc --noEmit && eslint . --fix && stylelint \"src/**/*.scss\" --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/virtual-tour-plugin/package.json b/packages/virtual-tour-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix && stylelint \"src/**/*.scss\" --fix",
+    "lint": "tsc --noEmit && eslint . --fix && stylelint \"src/**/*.scss\" --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/packages/visible-range-plugin/package.json b/packages/visible-range-plugin/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "build": "tsup",
     "watch": "tsup --watch",
-    "lint": "eslint . --fix",
+    "lint": "tsc --noEmit && eslint . --fix",
     "publish-dist": "cd dist && npm publish --tag=$NPM_TAG --access=public",
     "npm-link": "cd dist && npm link"
   },
diff --git a/yarn.lock b/yarn.lock
@@ -10290,6 +10290,11 @@ ts-node@^10.9.1:
     v8-compile-cache-lib "^3.0.1"
     yn "3.1.1"
 
+tsc@^2.0.4:
+  version "2.0.4"
+  resolved "https://registry.yarnpkg.com/tsc/-/tsc-2.0.4.tgz#5f6499146abea5dca4420b451fa4f2f9345238f5"
+  integrity sha512-fzoSieZI5KKJVBYGvwbVZs/J5za84f2lSTLPYf6AGiIf43tZ3GNrI1QzTLcjtyDDP4aLxd46RTZq1nQxe7+k5Q==
+
 tslib@^1.10.0, tslib@^1.9.3:
   version "1.14.1"
   resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.14.1.tgz#cf2d38bdc34a134bcaf1091c41f6619e2f672d00"

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ export class CompassComponent extends AbstractComponent {`
`93`	`93`	this.container.className = `psv-compass psv-compass--${this.config.position.join('-')}`;
`94`	`94`
`95`	`95`	`if (this.config.className) {`
`96`		`- utils.addClasses(this.container, this.config.className);`
	`96`	`+ this.container.classList.add(this.config.className);`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`this.background.innerHTML = this.config.backgroundSvg;`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "../../tsconfig.json",`
`3`	`3`	`"include": ["src/*/.ts", "../shared/typings.d.ts"],`
`4`		`- "exclude": ["dist", "node_modules"]`
	`4`	`+ "exclude": ["dist", "node_modules", "src/*/.spec.ts"]`
`5`	`5`	`}`