Fix #959 markers: leave-marker event fired when updating a marker

mistic100 · mistic100 · commit 729d54e660e9 · 2023-06-03T09:56:24.000+02:00
diff --git a/packages/markers-plugin/src/Marker.ts b/packages/markers-plugin/src/Marker.ts
@@ -364,18 +364,18 @@ export class Marker {
             } else {
                 element.classList.add('psv-marker--poly');
             }
-
-            // add CSS classes
-            if (this.config.className) {
-                utils.addClasses(element, this.config.className);
+            if (this.state.visible) {
+                element.classList.add('psv-marker--visible');
             }
-
             if (this.config.tooltip) {
                 element.classList.add('psv-marker--has-tooltip');
             }
             if (this.config.content) {
                 element.classList.add('psv-marker--has-content');
             }
+            if (this.config.className) {
+                utils.addClasses(element, this.config.className);
+            }
 
             // apply style
             element.style.opacity = `${this.config.opacity ?? 1}`;

Original file line number	Diff line number	Diff line change
`@@ -364,18 +364,18 @@ export class Marker {`
`364`	`364`	`} else {`
`365`	`365`	`element.classList.add('psv-marker--poly');`
`366`	`366`	`}`
`367`		`-`
`368`		`- // add CSS classes`
`369`		`- if (this.config.className) {`
`370`		`- utils.addClasses(element, this.config.className);`
	`367`	`+ if (this.state.visible) {`
	`368`	`+ element.classList.add('psv-marker--visible');`
`371`	`369`	`}`
`372`		`-`
`373`	`370`	`if (this.config.tooltip) {`
`374`	`371`	`element.classList.add('psv-marker--has-tooltip');`
`375`	`372`	`}`
`376`	`373`	`if (this.config.content) {`
`377`	`374`	`element.classList.add('psv-marker--has-content');`
`378`	`375`	`}`
	`376`	`+ if (this.config.className) {`
	`377`	`+ utils.addClasses(element, this.config.className);`
	`378`	`+ }`
`379`	`379`
`380`	`380`	`// apply style`
`381`	`381`	element.style.opacity = `${this.config.opacity ?? 1}`;