Skip to content

Commit b5acfeb

Browse files
committed
Default enabled "useNewAnglesOrder"
1 parent 5453380 commit b5acfeb

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/core/src/Viewer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ import {
7171
export class Viewer extends TypedEventTarget<ViewerEvents> {
7272
/**
7373
* Change the order in which the panoData and sphereCorrection angles are applied from 'ZXY' to 'YXZ'
74-
* Will default to `true` in version 5.11
74+
* @deprecated Will be removed in version 5.12
7575
*/
76-
static useNewAnglesOrder = false;
76+
static useNewAnglesOrder = true;
7777

7878
readonly state: ViewerState;
7979
readonly config: ParsedViewerConfig;

packages/core/src/services/Renderer.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -290,8 +290,8 @@ export class Renderer extends AbstractService {
290290

291291
const i = (cleanCorrection.pan ? 1 : 0) + (cleanCorrection.tilt ? 1 : 0) + (cleanCorrection.roll ? 1 : 0);
292292
if (!Viewer.useNewAnglesOrder && i > 1) {
293-
logWarn(`'panoData' Euler angles will change in version 5.11.0.`);
294-
logWarn(`Set 'Viewer.useNewAnglesOrder = true;' to remove this warning (you might have to adapt your poseHeading/posePitch/poseRoll parameters).`);
293+
logWarn(`'panoData' Euler angles have changed in version 5.11.0.`);
294+
logWarn(`Remove your 'useNewAnglesOrder' override to remove this warning (you might have to adapt your poseHeading/posePitch/poseRoll parameters).`);
295295
}
296296

297297
if (Viewer.useNewAnglesOrder) {
@@ -310,8 +310,8 @@ export class Renderer extends AbstractService {
310310

311311
const i = (cleanCorrection.pan ? 1 : 0) + (cleanCorrection.tilt ? 1 : 0) + (cleanCorrection.roll ? 1 : 0);
312312
if (!Viewer.useNewAnglesOrder && i > 1) {
313-
logWarn(`'sphereCorrection' Euler angles will change in version 5.11.0.`);
314-
logWarn(`Set 'Viewer.useNewAnglesOrder = true;' to remove this warning (you might have to adapt your pan/tilt/roll parameters).`);
313+
logWarn(`'sphereCorrection' Euler angles have changed in version 5.11.0.`);
314+
logWarn(`Remove your 'useNewAnglesOrder' override to remove this warning (you might have to adapt your poseHeading/posePitch/poseRoll parameters).`);
315315
}
316316

317317
if (Viewer.useNewAnglesOrder) {

0 commit comments

Comments
 (0)