[svc] Remove obsolete functionality at NEXT

Unfortunately these symbols were never removed after API level 10, so
the symbols for these still exist in `libsvc.so` at all API levels since
then. To prevent them from being a part of future SDK releases, we use
an API level guard to prevent them from being generated entirely.

Test: No functional change.
Change-Id: I70994a37524629a659e4693585ee9fafe0a52656
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1234104
Commit-Queue: Brandon Castellano <[email protected]>
Reviewed-by: Adam Barth <[email protected]>
Reviewed-by: James Robinson <[email protected]>
API-Review: Adam Barth <[email protected]>

Author: Breakthrough

sdk/history/NEXT/libsvc.ifs

@@ -2,18 +2,6 @@
 IfsVersion:      3.0
 SoName:          libsvc.so
 Symbols:
-  - { Name: svc_dir_add_directory, Type: Func }
-  - { Name: svc_dir_add_directory_by_path, Type: Func }
-  - { Name: svc_dir_add_service, Type: Func }
-  - { Name: svc_dir_add_service_by_path, Type: Func }
-  - { Name: svc_dir_create, Type: Func }
-  - { Name: svc_dir_create_without_serve, Type: Func }
-  - { Name: svc_dir_destroy, Type: Func }
-  - { Name: svc_dir_remove_directory, Type: Func }
-  - { Name: svc_dir_remove_entry_by_path, Type: Func }
-  - { Name: svc_dir_remove_service, Type: Func }
-  - { Name: svc_dir_remove_service_by_path, Type: Func }
-  - { Name: svc_dir_serve, Type: Func }
   - { Name: svc_directory_add_directory, Type: Func }
   - { Name: svc_directory_add_service, Type: Func }
   - { Name: svc_directory_create, Type: Func }

sdk/lib/svc/dir.cc

@@ -205,6 +205,8 @@ zx_status_t svc_directory_remove_entry(svc_dir_t* dir, const char* path, size_t
   return status;
 }
 
+#if FUCHSIA_API_LEVEL_LESS_THAN(NEXT)
+
 // Deprecated function implementations
 zx_status_t svc_dir_create(async_dispatcher_t* dispatcher, zx_handle_t dir_request,
                            svc_dir_t** result) {
@@ -273,3 +275,5 @@ zx_status_t svc_dir_remove_entry_by_path(svc_dir_t* dir, const char* path, const
 }
 
 zx_status_t svc_dir_destroy(svc_dir_t* dir) { return svc_directory_destroy(dir); }
+
+#endif

sdk/lib/svc/dir.h

@@ -90,9 +90,7 @@ __EXPORT zx_status_t svc_directory_remove_entry(svc_dir_t* dir, const char* path
 // returns ZX_OK.
 __EXPORT zx_status_t svc_directory_destroy(svc_dir_t* dir) ZX_AVAILABLE_SINCE(10);
 
-// All the functions listed below are deprecated as of Fuchsia API level 10. They should not be used
-// by new clients.
-
+#if FUCHSIA_API_LEVEL_LESS_THAN(NEXT)
 __EXPORT zx_status_t svc_dir_create(async_dispatcher_t* dispatcher, zx_handle_t directory_request,
                                     svc_dir_t** out_result)
     ZX_REMOVED_SINCE(
@@ -147,6 +145,7 @@ __EXPORT zx_status_t svc_dir_remove_entry_by_path(svc_dir_t* dir, const char* pa
                                                   const char* name)
     ZX_REMOVED_SINCE(/*added=*/9, /*deprecated=*/10, /*removed=*/10,
                      "Use |svc_directory_remove_entry|");
+#endif
 
 __END_CDECLS
 

sdk/lib/svc/svc.api

@@ -1,3 +1,3 @@
 {
-  "pkg/svc/include/lib/svc/dir.h": "7bc8ab708f65f2b2b612ab764868297a"
+  "pkg/svc/include/lib/svc/dir.h": "592dce9cc5dba81f76a17988862f7123"
 }

sdk/lib/svc/svc.ifs

@@ -2,18 +2,6 @@
 IfsVersion:      3.0
 SoName:          libsvc.so
 Symbols:
-  - { Name: svc_dir_add_directory, Type: Func }
-  - { Name: svc_dir_add_directory_by_path, Type: Func }
-  - { Name: svc_dir_add_service, Type: Func }
-  - { Name: svc_dir_add_service_by_path, Type: Func }
-  - { Name: svc_dir_create, Type: Func }
-  - { Name: svc_dir_create_without_serve, Type: Func }
-  - { Name: svc_dir_destroy, Type: Func }
-  - { Name: svc_dir_remove_directory, Type: Func }
-  - { Name: svc_dir_remove_entry_by_path, Type: Func }
-  - { Name: svc_dir_remove_service, Type: Func }
-  - { Name: svc_dir_remove_service_by_path, Type: Func }
-  - { Name: svc_dir_serve, Type: Func }
   - { Name: svc_directory_add_directory, Type: Func }
   - { Name: svc_directory_add_service, Type: Func }
   - { Name: svc_directory_create, Type: Func }