Commit 2fcda38
[roll] Roll infra/recipes [jiri] Mark failed steps as red
Refactor the Jiri recipe module code to use `try/except` to catch
non-zero retcodes instead of `ok_ret` so that the steps actually get
marked as red if they fail with a non-zero retcode. Every place we were
using `ok_ret` the non-zero retcode was still treated as a failure, but
converted to a different exception, so builds would fail but no steps
would show up as failed, which is a confusing UX.
Original-Fixed: 380921855
Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1164052
Original-Revision: 5af687dd7c457920d2612cef9c5e4287f54e8bae
GitOrigin-RevId: 7529066fb55839c40fe6a7b6618db88f7f26476a
Change-Id: If7ae271fca46b78e9afff486ee1c49e85668f6ab1 parent 9e5b279 commit 2fcda38
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
0 commit comments