Skip to content

Commit 2fcda38

Browse files
Oliver Newmancopybara-github
authored andcommitted
[roll] Roll infra/recipes [jiri] Mark failed steps as red
Refactor the Jiri recipe module code to use `try/except` to catch non-zero retcodes instead of `ok_ret` so that the steps actually get marked as red if they fail with a non-zero retcode. Every place we were using `ok_ret` the non-zero retcode was still treated as a failure, but converted to a different exception, so builds would fail but no steps would show up as failed, which is a confusing UX. Original-Fixed: 380921855 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/infra/recipes/+/1164052 Original-Revision: 5af687dd7c457920d2612cef9c5e4287f54e8bae GitOrigin-RevId: 7529066fb55839c40fe6a7b6618db88f7f26476a Change-Id: If7ae271fca46b78e9afff486ee1c49e85668f6ab
1 parent 9e5b279 commit 2fcda38

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

infra/recipes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@
1111
path="infra/recipes"
1212
remote="https://fuchsia.googlesource.com/infra/recipes"
1313
gerrithost="https://fuchsia-review.googlesource.com"
14-
revision="b7add7037e6fd1272314d43197e208bdf322ce30"/>
14+
revision="5af687dd7c457920d2612cef9c5e4287f54e8bae"/>
1515
</projects>
1616
</manifest>

0 commit comments

Comments
 (0)