Skip to content

Commit c99306e

Browse files
Victor Costancopybara-github
authored andcommitted
[roll] Roll fuchsia [fake-display] Remove FakeDisplayStack from unit tests.
FakeDisplayStack attaches a Display Coordinator to the FakeDisplay driver implementation. This introduces the following problems. 1. Some tests replace the Coordinator's event listener with their own, in order to catch OnCaptureComplete events. This makes the tests difficult to reason about, because the Coordinator does not support having its event listener removed, and the driver does not support having its event listener replaced. 2. This is an unnecessary increase in the test surface area, because FakeDisplay only depends on Sysmem and on the Driver Runtime. This CL replaces the FakeDisplayStack with the parts that are used in the unit test. Original-Bug: 388885807 Test: fx test //src/graphics/display/drivers/fake Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1233747 Original-Revision: 66dbab63930a1d4702d58be39cbb8ab35aa18053 GitOrigin-RevId: a284b69420363638a82ab237f3082fa55e82403b Change-Id: I81fb8db55513f597362e0f8004039b1c11e4f2ed
1 parent 03a0d6e commit c99306e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

stem

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
githooks="integration/git-hooks"
1212
remote="https://fuchsia.googlesource.com/fuchsia"
1313
gerrithost="https://fuchsia-review.googlesource.com"
14-
revision="4932b666cdd6b21ce8c7924ae55bdcacb5ed6991"/>
14+
revision="66dbab63930a1d4702d58be39cbb8ab35aa18053"/>
1515
</projects>
1616
<hooks>
1717
<hook name="install-environment"

0 commit comments

Comments
 (0)