Skip to content

Commit fa302a3

Browse files
Tyler Mandrycopybara-github
authored andcommitted
[roll] Roll fuchsia [fuchsia-async] Add ScopeRef::cancel()
This allows cancelling a scope when it is not owned. This might be useful for cancelling a scope from within a task spawned on that scope, for example. Now Scope only differs from ScopeRef in that it 1. Cancels the scope automatically on drop. 2. Allows joining the scope (waiting for no tasks + closing). Joining the scope could also be allowed from a ScopeRef, but as I explain in the code comment, this seems less of a good idea. Conceptually, the Scope/ScopeRef relationship is aligned with the Task/JoinHandle relationship in that the first "owned" variant cancels the object on drop. We should probably align the naming of these. Original-Bug: 339724492 Original-Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1152812 Original-Revision: eda1014f8bcc09a7f78b4895caec0e0a5c839282 GitOrigin-RevId: 35385458a4be89cad5657076c7215a6ae5e21a8e Change-Id: Ide8f2b1d309cc627564377408ed179b1371c06bd
1 parent f98761f commit fa302a3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

stem

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
githooks="integration/git-hooks"
1212
remote="https://fuchsia.googlesource.com/fuchsia"
1313
gerrithost="https://fuchsia-review.googlesource.com"
14-
revision="08ff2a2ca13439e21fdb64f6e64b910befe25302"/>
14+
revision="eda1014f8bcc09a7f78b4895caec0e0a5c839282"/>
1515
</projects>
1616
<hooks>
1717
<hook name="install-environment"

0 commit comments

Comments
 (0)