Skip to content

Commit 8e80f13

Browse files
antoniolinhartCQ Bot
authored andcommitted
[bug] Update reference from obsolete to active
Update TODOs to link from the obsolete https://fxbug.dev/42177573 to the active https://fxbug.dev/296283299 for optional capability discovery. While modifying these, change the formatting to use the `TODO(https://fxbug.dev/XXX): DESCRIPTION` format. Bug: 296283299 Change-Id: Id51743bad4a8892afc41a1606af9b02dbe522b03 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1190174 Reviewed-by: Sen Jiang <[email protected]> Commit-Queue: Antonio Linhart <[email protected]> Reviewed-by: Bruno Dal Bo <[email protected]> API-Review: Bruno Dal Bo <[email protected]> Reviewed-by: Colin Nelson <[email protected]> Reviewed-by: Claire Gonyeo <[email protected]>
1 parent 2c32eae commit 8e80f13

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

sdk/fidl/fuchsia.net.dhcp/client.fidl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,11 @@ closed protocol ClientProvider {
8686

8787
/// No-op method that allows checking for presence.
8888
///
89-
/// It's not currently possible for a client with an optionally-provided
90-
/// protocol to check whether there's someone on the other end without
91-
/// making a FIDL call (https://fxbug.dev/42177573). This method provides a
92-
/// workaround by giving a client a method that it can call to check for
93-
/// liveness.
89+
/// TODO(https://fxbug.dev/296283299): It's not currently possible for a
90+
/// client with an optionally-provided protocol to check whether there's
91+
/// someone on the other end without making a FIDL call . This method
92+
/// provides a workaround by giving a client a method that it can call to
93+
/// check for liveness.
9494
///
9595
/// TODO(https://fxbug.dev/42076541): Remove this once the DHCP out-of-stack
9696
/// client is always being used.

src/developer/remote-control/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ async fn exec_server(config: &Config) -> Result<(), Error> {
9393
let weak_router = Arc::downgrade(&router);
9494
std::mem::drop(router);
9595
let usb_fut = async move {
96-
// TODO: Change this info! to error! Once we can return normally if USB support is disabled
97-
// (https://fxbug.dev/42177573)
96+
// TODO(https://fxbug.dev/296283299): Change this info! to error! Once
97+
// we can return normally if USB support is disabled
9898
if let Err(e) = usb::run_usb_links(weak_router.clone()).await {
9999
info!("USB scanner failed with error {e:?}");
100100
}

src/sys/tools/component/src/lib.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,11 @@ pub async fn exec() -> Result<()> {
5151
resolve_cmd(args.query, lifecycle_controller, realm_query, writer).await
5252
}
5353
ComponentSubcommand::Explore(args) => {
54-
// TODO(https://fxbug.dev/42177573): Verify that the optional Launcher protocol is available
55-
// before connecting.
54+
// TODO(https://fxbug.dev/296283299): Verify that the optional Launcher protocol is
55+
// available before connecting.
5656
let dash_launcher = connect_to_protocol::<fdash::LauncherMarker>()?;
57-
// TODO(https://fxbug.dev/42077838): Use Stdout::raw instead, when a command is not provided
57+
// TODO(https://fxbug.dev/42077838): Use Stdout::raw instead, when a command is
58+
// not provided.
5859
let stdout = Stdout::buffered();
5960

6061
#[allow(clippy::large_futures)]

src/sys/tools/package/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ pub async fn exec() -> anyhow::Result<()> {
1414

1515
match args.subcommand {
1616
crate::args::PackageSubcommand::Explore(args) => {
17-
// TODO(https://fxbug.dev/42177573): Verify that the optional Launcher protocol is
17+
// TODO(https://fxbug.dev/296283299): Verify that the optional Launcher protocol is
1818
// available before connecting.
1919
let dash_launcher = connect_to_protocol::<fdash::LauncherMarker>()?;
2020
// TODO(https://fxbug.dev/42077838): Use Stdout::raw when a command is not provided.

0 commit comments

Comments
 (0)