[drivers][broadcom] Move temporary into variable

llvm/llvm-project#120223 became more strict
about discarded value expressions. This CL moves the array reference
into a local variable to operate on.

Bug: 385748190
Change-Id: I468bc0e122778a867ea452535be5d4562802264e
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1179632
Reviewed-by: Karl Ward <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
Fuchsia-Auto-Submit: Caslyn Tonelli <[email protected]>

Author: Caslyn

src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/cfg80211.cc

@@ -2853,10 +2853,11 @@ static zx_status_t brcmf_cfg80211_add_key(struct net_device* ndev,
     // IEEE 802.11-2016 3.2 (c.f. "vendor organizationally unique identifier")
     constexpr uint8_t kIeeeOui[] = {0x00, 0x0F, 0xAC};
     constexpr uint8_t kMsftOui[] = {0x00, 0x50, 0xF2};
-    if (!std::equal(req->cipher_oui().begin(), req->cipher_oui().begin() + req->cipher_oui().size(),
-                    kIeeeOui, kIeeeOui + std::size(kIeeeOui)) &&
-        !std::equal(req->cipher_oui().begin(), req->cipher_oui().begin() + req->cipher_oui().size(),
-                    kMsftOui, kMsftOui + std::size(kMsftOui))) {
+    auto cipher_oui = req->cipher_oui();
+    if (!std::equal(cipher_oui.begin(), cipher_oui.begin() + cipher_oui.size(), kIeeeOui,
+                    kIeeeOui + std::size(kIeeeOui)) &&
+        !std::equal(cipher_oui.begin(), cipher_oui.begin() + cipher_oui.size(), kMsftOui,
+                    kMsftOui + std::size(kMsftOui))) {
       BRCMF_ERR("Cipher OUI does not match either IEEE or MSFT OUI, not supported.");
       return ZX_ERR_NOT_SUPPORTED;
     }

src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/sim/test/sim_test.cc

@@ -168,8 +168,9 @@ void SimInterface::RoamConf(RoamConfRequestView request, RoamConfCompleter::Sync
   if (request->status_code() == wlan_ieee80211::StatusCode::kSuccess) {
     ++stats_.roam_successes;
     ZX_ASSERT(request->has_selected_bssid());
-    ZX_ASSERT(request->selected_bssid().size() == ETH_ALEN);
-    memcpy(assoc_ctx_.bssid.byte, request->selected_bssid().data(), ETH_ALEN);
+    auto bssid = request->selected_bssid();
+    ZX_ASSERT(bssid.size() == ETH_ALEN);
+    memcpy(assoc_ctx_.bssid.byte, bssid.data(), ETH_ALEN);
   } else {
     assoc_ctx_.state = AssocContext::kNone;
   }
@@ -189,8 +190,9 @@ void SimInterface::RoamResultInd(RoamResultIndRequestView request,
   if (request->status_code() == wlan_ieee80211::StatusCode::kSuccess) {
     stats_.connect_successes++;
     ZX_ASSERT(request->has_selected_bssid());
-    ZX_ASSERT(request->selected_bssid().size() == ETH_ALEN);
-    memcpy(assoc_ctx_.bssid.byte, request->selected_bssid().data(), ETH_ALEN);
+    auto bssid = request->selected_bssid();
+    ZX_ASSERT(bssid.size() == ETH_ALEN);
+    memcpy(assoc_ctx_.bssid.byte, bssid.data(), ETH_ALEN);
   } else {
     assoc_ctx_.state = AssocContext::kNone;
   }