[ui][escher] Preallocate reused struct in CommandBuffer::Submit

CommandBuffer::Submit has a struct that are allocated and destructed in
each Submit. We should make them static to avoid the extra cost.

Change-Id: I405daab97b94c7143b1d74294d96ab71d35bfaba
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1178498
Reviewed-by: Josh Gargus <[email protected]>
Fuchsia-Auto-Submit: Emircan Uysaler <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>

Author: uysalere

src/ui/lib/escher/impl/command_buffer.cc

@@ -53,17 +53,17 @@ bool CommandBuffer::Submit(vk::Queue queue, CommandBufferFinishedCallback callba
   auto end_command_buffer_result = command_buffer_.end();
   FX_DCHECK(end_command_buffer_result == vk::Result::eSuccess);
 
-  auto protected_submit_info = vk::ProtectedSubmitInfo().setProtectedSubmit(true);
-  vk::SubmitInfo submit_info;
-  submit_info.commandBufferCount = 1;
-  submit_info.pNext = use_protected_memory_ ? &protected_submit_info : nullptr;
-  submit_info.pCommandBuffers = &command_buffer_;
-  submit_info.waitSemaphoreCount = static_cast<uint32_t>(wait_semaphores_for_submit_.size());
-  submit_info.pWaitSemaphores = wait_semaphores_for_submit_.data();
-  submit_info.pWaitDstStageMask = wait_semaphore_stages_.data();
-  submit_info.signalSemaphoreCount = static_cast<uint32_t>(signal_semaphores_for_submit_.size());
-  submit_info.pSignalSemaphores = signal_semaphores_for_submit_.data();
-
+  static constexpr vk::ProtectedSubmitInfo kProtectedSubmitInfo =
+      vk::ProtectedSubmitInfo().setProtectedSubmit(true);
+  const vk::SubmitInfo submit_info(
+      /*waitSemaphoreCount=*/static_cast<uint32_t>(wait_semaphores_for_submit_.size()),
+      /*pWaitSemaphores*/ wait_semaphores_for_submit_.data(),
+      /*pWaitDstStageMask=*/wait_semaphore_stages_.data(),
+      /*commandBufferCount=*/1,
+      /*pCommandBuffers=*/&command_buffer_,
+      /*signalSemaphoreCount=*/static_cast<uint32_t>(signal_semaphores_for_submit_.size()),
+      /*pSignalSemaphores=*/signal_semaphores_for_submit_.data(),
+      /*pNext=*/use_protected_memory_ ? &kProtectedSubmitInfo : nullptr);
   auto submit_result = queue.submit(1, &submit_info, fence_);
   if (submit_result != vk::Result::eSuccess) {
     FX_LOGS(WARNING) << "failed queue submission: " << to_string(submit_result);