Commit b77f3b0
fix: remove incorrect URL encoding from OAuth2 Basic auth credentials
OAuth2 Basic authentication was incorrectly URL-encoding client credentials
before Base64 encoding. This caused characters like '>' and '?' to become
'%3e' and '%3f' respectively, breaking authentication.
According to RFC 7617 (HTTP Basic Authentication) and RFC 6749 (OAuth 2.0)
Section 2.3.1, Basic auth credentials should be:
1. Concatenated as "client_id:client_secret"
2. Base64 encoded directly (no URL encoding first)
3. Sent as "Authorization: Basic <base64>"
URL encoding is for URL parameters, not Basic auth credentials.
This fixes authentication with OAuth2 providers that strictly validate
Basic auth header format, especially when client secrets contain special
characters that would be URL-encoded incorrectly.
Co-Authored-By: Claude (claude-sonnet-4) <noreply@anthropic.com>1 parent 29d9ab5 commit b77f3b0
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
188 | | - | |
| 188 | + | |
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
| |||
0 commit comments