Skip to content

Commit 3bf1843

Browse files
author
Jonathan Kamens
committed
Fix check for valid loggers in debug_callback
The code in `debug_callback` checking if the specified loggers were valid was using a set equals operator when it should have been using a subset operator.
1 parent f34934e commit 3bf1843

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

delete

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def debug_callback(option, opt_str, value, parser):
2222
if value.lower() == 'all':
2323
loggers = all_loggers
2424
else:
25-
if not set(loggers) == set(all_loggers):
25+
if not set(loggers) <= set(all_loggers):
2626
parser.error('Valid debug targets: {0}'.format(
2727
", ".join(all_loggers)))
2828
for l in loggers:

expunge

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def debug_callback(option, opt_str, value, parser):
2828
if value.lower() == 'all':
2929
loggers = all_loggers
3030
else:
31-
if not set(loggers) == set(all_loggers):
31+
if not set(loggers) <= set(all_loggers):
3232
parser.error('Valid debug targets: {0}'.format(
3333
", ".join(all_loggers)))
3434
for l in loggers:

lsdel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def debug_callback(option, opt_str, value, parser):
2121
if value.lower() == 'all':
2222
loggers = all_loggers
2323
else:
24-
if not set(loggers) == set(all_loggers):
24+
if not set(loggers) <= set(all_loggers):
2525
parser.error('Valid debug targets: {0}'.format(
2626
", ".join(all_loggers)))
2727
for l in loggers:

undelete

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def debug_callback(option, opt_str, value, parser):
2222
if value.lower() == 'all':
2323
loggers = all_loggers
2424
else:
25-
if not set(loggers) == set(all_loggers):
25+
if not set(loggers) <= set(all_loggers):
2626
parser.error('Valid debug targets: {0}'.format(
2727
", ".join(all_loggers)))
2828
for l in loggers:

0 commit comments

Comments
 (0)