Skip to content

Commit 1aae3c4

Browse files
committed
Separate Debug and Release deps as required for proper builds
1 parent 1962f1c commit 1aae3c4

File tree

3 files changed

+37
-30
lines changed

3 files changed

+37
-30
lines changed

.github/set_dep_vars.ps1

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Set-StrictMode -version latest;
22
$ErrorActionPreference = "Stop";
33
$VerbosePreference="Continue";
44

5-
$cacheKey=(date +'%m%d')
5+
$cacheKey= $env:Configuration + (date +'%m%d')
66
$arr=($env:DEPS).split()
77
$cnt=1
88
foreach ($dep in $arr) {
@@ -12,4 +12,12 @@ foreach ($dep in $arr) {
1212
$cnt++
1313
}
1414
}
15-
echo "DepsCacheKey=$cacheKey" >> $env:GITHUB_OUTPUT
15+
$failAction="fail"
16+
$postfix=""
17+
if ($env:Configuration -eq "Debug") {
18+
$failAction="ignore"
19+
$postfix="-Debug"
20+
}
21+
echo "DepsCacheKey=$cacheKey" >> $env:GITHUB_OUTPUT
22+
echo "DepsFailAction=$failAction" >> $env:GITHUB_OUTPUT
23+
echo "DepsPostfix=$postfix" >> $env:GITHUB_OUTPUT

.github/workflows/do_build.yml

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ jobs:
4646
strategy:
4747
fail-fast: false
4848
matrix:
49-
#BuildPkg: [patch]
50-
#BuildPkg: [grep]
51-
# BuildPkg: [which,patch,zstd,pcre2,gzip,tar,zlib,findutils,libpsl,coreutils,grep]
5249
BaseImage: [windows-latest]
5350
Configuration: [Debug, Release] #right now the deps downloader always downloads release versions, we could use our debug libs for debug builds
5451
SkipDebugBuild:
@@ -93,24 +90,6 @@ jobs:
9390
echo "BLD_CONFIG_BUILD_DEBUG=1" >> $env:GITHUB_ENV
9491
}
9592
96-
# - uses: actions/[email protected]
97-
# with:
98-
# dotnet-version: ${{env.CI_REQ_DOTNET_SDK_VER}}
99-
100-
101-
102-
#previously we built all in one workflow now with them as individual workflows we download differently
103-
104-
# - name: Download Required Artifacts
105-
# uses: mitchcapper/action-download-artifact@c026c9be4097d153332e6cd0974d140ba22cd6cc
106-
# if: ${{ inputs.RequiredDeps != '' && inputs.BuildPkg != 'script' }}
107-
# with:
108-
# name: ${{ inputs.RequiredDeps }}
109-
# path: d:/artifacts
110-
# name_prefix: WLB-
111-
# run_id: ${{ github.run_id }}
112-
# workflow_conclusion: "success"
113-
11493
- name: Restore Existing Dep Cache
11594
if: ${{ inputs.RequiredDeps != '' && inputs.BuildPkg != 'script' }}
11695
uses: actions/cache/restore@v3

.github/workflows/restore_deps_to_cache.yml

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ on:
1616

1717
jobs:
1818
build:
19+
strategy:
20+
fail-fast: false
21+
matrix:
22+
Configuration: [Debug, Release]
23+
1924
name: DEP Download
2025
runs-on: windows-2022
2126
environment: main
@@ -33,6 +38,7 @@ jobs:
3338
id: vars
3439
env:
3540
DEPS: "${{ inputs.RequiredDeps }}"
41+
Configuration: "${{ matrix.Configuration }}"
3642
run: ${{ github.workspace }}\.github\set_dep_vars.ps1
3743

3844
- name: Check Existing Cache
@@ -45,78 +51,92 @@ jobs:
4551
lookup-only: true
4652

4753
- name: Download Artifact ${{ steps.vars.outputs.Dep1Name }}
48-
uses: mitchcapper/action-download-artifact@ce1b9a1572bf43f4e5e89568e74cb1f2299e6362
54+
uses: mitchcapper/action-download-artifact@e8fcde2d08c6684586e66d4fe22786fd61a6e1a8
4955
if: ${{ steps.vars.outputs.Dep1Name && steps.cachecheck.outputs.cache-hit != 'true' }}
5056
with:
5157
name: ${{ steps.vars.outputs.Dep1Name }}
5258
path: d:/artifacts
5359
name_prefix: WLB-
60+
name_postfix: ${{ steps.vars.outputs.DepsPostfix }}
61+
if_no_artifact_found: ${{ steps.vars.outputs.DepsFailAction }}
5462
workflow_conclusion: "success"
5563
skip_unpack: true
5664
workflow: tool_${{ steps.vars.outputs.Dep1Name }}_build.yml
5765

5866
- name: Download Artifact ${{ steps.vars.outputs.Dep2Name }}
59-
uses: mitchcapper/action-download-artifact@ce1b9a1572bf43f4e5e89568e74cb1f2299e6362
67+
uses: mitchcapper/action-download-artifact@e8fcde2d08c6684586e66d4fe22786fd61a6e1a8
6068
if: ${{ steps.vars.outputs.Dep2Name && steps.cachecheck.outputs.cache-hit != 'true' }}
6169
with:
6270
name: ${{ steps.vars.outputs.Dep2Name }}
6371
path: d:/artifacts
6472
name_prefix: WLB-
6573
workflow_conclusion: "success"
74+
name_postfix: ${{ steps.vars.outputs.DepsPostfix }}
75+
if_no_artifact_found: ${{ steps.vars.outputs.DepsFailAction }}
6676
skip_unpack: true
6777
workflow: tool_${{ steps.vars.outputs.Dep2Name }}_build.yml
6878

6979
- name: Download Artifact ${{ steps.vars.outputs.Dep3Name }}
70-
uses: mitchcapper/action-download-artifact@ce1b9a1572bf43f4e5e89568e74cb1f2299e6362
80+
uses: mitchcapper/action-download-artifact@e8fcde2d08c6684586e66d4fe22786fd61a6e1a8
7181
if: ${{ steps.vars.outputs.Dep3Name && steps.cachecheck.outputs.cache-hit != 'true' }}
7282
with:
7383
name: ${{ steps.vars.outputs.Dep3Name }}
7484
path: d:/artifacts
7585
name_prefix: WLB-
86+
name_postfix: ${{ steps.vars.outputs.DepsPostfix }}
87+
if_no_artifact_found: ${{ steps.vars.outputs.DepsFailAction }}
7688
workflow_conclusion: "success"
7789
skip_unpack: true
7890
workflow: tool_${{ steps.vars.outputs.Dep3Name }}_build.yml
7991

8092
- name: Download Artifact ${{ steps.vars.outputs.Dep4Name }}
81-
uses: mitchcapper/action-download-artifact@ce1b9a1572bf43f4e5e89568e74cb1f2299e6362
93+
uses: mitchcapper/action-download-artifact@e8fcde2d08c6684586e66d4fe22786fd61a6e1a8
8294
if: ${{ steps.vars.outputs.Dep4Name && steps.cachecheck.outputs.cache-hit != 'true' }}
8395
with:
8496
name: ${{ steps.vars.outputs.Dep4Name }}
8597
path: d:/artifacts
8698
name_prefix: WLB-
99+
name_postfix: ${{ steps.vars.outputs.DepsPostfix }}
100+
if_no_artifact_found: ${{ steps.vars.outputs.DepsFailAction }}
87101
workflow_conclusion: "success"
88102
skip_unpack: true
89103
workflow: tool_${{ steps.vars.outputs.Dep4Name }}_build.yml
90104

91105
- name: Download Artifact ${{ steps.vars.outputs.Dep5Name }}
92-
uses: mitchcapper/action-download-artifact@ce1b9a1572bf43f4e5e89568e74cb1f2299e6362
106+
uses: mitchcapper/action-download-artifact@e8fcde2d08c6684586e66d4fe22786fd61a6e1a8
93107
if: ${{ steps.vars.outputs.Dep5Name && steps.cachecheck.outputs.cache-hit != 'true' }}
94108
with:
95109
name: ${{ steps.vars.outputs.Dep5Name }}
96110
path: d:/artifacts
97111
name_prefix: WLB-
112+
name_postfix: ${{ steps.vars.outputs.DepsPostfix }}
113+
if_no_artifact_found: ${{ steps.vars.outputs.DepsFailAction }}
98114
workflow_conclusion: "success"
99115
skip_unpack: true
100116
workflow: tool_${{ steps.vars.outputs.Dep5Name }}_build.yml
101117

102118
- name: Download Artifact ${{ steps.vars.outputs.Dep6Name }}
103-
uses: mitchcapper/action-download-artifact@ce1b9a1572bf43f4e5e89568e74cb1f2299e6362
119+
uses: mitchcapper/action-download-artifact@e8fcde2d08c6684586e66d4fe22786fd61a6e1a8
104120
if: ${{ steps.vars.outputs.Dep6Name && steps.cachecheck.outputs.cache-hit != 'true' }}
105121
with:
106122
name: ${{ steps.vars.outputs.Dep6Name }}
107123
path: d:/artifacts
108124
name_prefix: WLB-
125+
name_postfix: ${{ steps.vars.outputs.DepsPostfix }}
126+
if_no_artifact_found: ${{ steps.vars.outputs.DepsFailAction }}
109127
workflow_conclusion: "success"
110128
skip_unpack: true
111129
workflow: tool_${{ steps.vars.outputs.Dep6Name }}_build.yml
112130

113131
- name: Download Artifact ${{ steps.vars.outputs.Dep7Name }}
114-
uses: mitchcapper/action-download-artifact@ce1b9a1572bf43f4e5e89568e74cb1f2299e6362
132+
uses: mitchcapper/action-download-artifact@e8fcde2d08c6684586e66d4fe22786fd61a6e1a8
115133
if: ${{ steps.vars.outputs.Dep7Name && steps.cachecheck.outputs.cache-hit != 'true' }}
116134
with:
117135
name: ${{ steps.vars.outputs.Dep7Name }}
118136
path: d:/artifacts
119137
name_prefix: WLB-
138+
name_postfix: ${{ steps.vars.outputs.DepsPostfix }}
139+
if_no_artifact_found: ${{ steps.vars.outputs.DepsFailAction }}
120140
workflow_conclusion: "success"
121141
skip_unpack: true
122142
workflow: tool_${{ steps.vars.outputs.Dep7Name }}_build.yml

0 commit comments

Comments
 (0)