make source/bundle_id optional for notarization-only mode

Author: mitchellh

README.md

@@ -185,26 +185,14 @@ Supported configurations:
   * `source` (`array<string>`) - A list of files to sign, package, and
     notarize. If you want to sign multiple files with different identities
     or into different packages, then you should invoke `gon` with separate
-    configurations.
+    configurations. This is optional if you're using the notarization-only
+	mode with the `notarize` block.
 
   * `bundle_id` (`string`) - The [bundle ID](https://cocoacasts.com/what-are-app-ids-and-bundle-identifiers/)
     for your application. You should choose something unique for your application.
     You can also [register these with Apple](https://developer.apple.com/account/resources/identifiers/list).
-
-  * `notarize` (_optional_) - Settings for notarizing an already built files.
-    This is an alternative to using the `source` option.
-
-    * `path` (`string`) - The path to the file to notarize. This must be
-      one of Apple's supported file types for notarization: dmg, pkg, app, or
-      zip.
-
-    * `bundle_id` (`string`) - The bundle ID to use for this notarization.
-      This is used instead of the top-level `bundle_id` (which controls the
-      value for source-based runs).
-
-    * `staple` (`bool` _optional_) - Controls if `stapler staple` should run
-      if notarization succeeds. This should only be set for filetypes that
-      support it (dmg, pkg, or app).
+    This is optional if you're using the notarization-only
+	mode with the `notarize` block.
 
   * `apple_id` - Settings related to the Apple ID to use for notarization.
 
@@ -248,6 +236,25 @@ Supported configurations:
       already exists, it will be overwritten. All files in `source` will be copied
       into the root of the zip archive.
 
+Notarization-only mode:
+
+  * `notarize` (_optional_) - Settings for notarizing an already built files.
+    This is an alternative to using the `source` option. This option can be
+    repeated to notarize multiple files.
+
+    * `path` (`string`) - The path to the file to notarize. This must be
+      one of Apple's supported file types for notarization: dmg, pkg, app, or
+      zip.
+
+    * `bundle_id` (`string`) - The bundle ID to use for this notarization.
+      This is used instead of the top-level `bundle_id` (which controls the
+      value for source-based runs).
+
+    * `staple` (`bool` _optional_) - Controls if `stapler staple` should run
+      if notarization succeeds. This should only be set for filetypes that
+      support it (dmg, pkg, or app).
+
+
 ### Notarization-Only Configuration
 
 You can configure `gon` to notarize already-signed files. This is useful
@@ -267,9 +274,6 @@ those results as well as those in `notarize` blocks.
 Example in HCL and then the identical configuration in JSON:
 
 ```hcl
-sources = []
-bundle_id = ""
-
 notarize {
   path = "/path/to/terraform.pkg"
   bundle_id = "com.mitchellh.example.terraform"
@@ -284,9 +288,6 @@ apple_id {
 
 ```json
 {
-  "sources": [],
-  "bundle_id": "",
-
   "notarize": [{
     "path": "/path/to/terraform.pkg",
     "bundle_id": "com.mitchellh.example.terraform",

cmd/gon/main.go

@@ -81,6 +81,15 @@ func realMain() int {
 
 	// A bunch of validation
 	if len(cfg.Source) > 0 {
+		if cfg.BundleId == "" {
+			color.New(color.Bold, color.FgRed).Fprintf(os.Stdout,
+				"❗️ `bundle_id` configuration required with `source` set\n")
+			color.New(color.FgRed).Fprintf(os.Stdout,
+				"When you set the `source` configuration, you must also specify the\n"+
+					"`bundle_id` that will be used for packaging and notarization.\n")
+			return 1
+		}
+
 		if cfg.Sign == nil {
 			color.New(color.Bold, color.FgRed).Fprintf(os.Stdout,
 				"❗️ `sign` configuration required with `source` set\n")

internal/config/config.go

@@ -3,12 +3,12 @@ package config
 // Config is the configuration structure for gon.
 type Config struct {
 	// Source is the list of binary files to sign.
-	Source []string `hcl:"source"`
+	Source []string `hcl:"source,optional"`
 
 	// BundleId is the bundle ID to use for the package that is created.
 	// This should be in a format such as "com.example.app". The value can
 	// be anything, this is required by Apple.
-	BundleId string `hcl:"bundle_id"`
+	BundleId string `hcl:"bundle_id,optional"`
 
 	// Notarize is a single file (usually a .pkg installer or zip)
 	// that is ready for notarization as-is