Correctly handle permissions and clean up assertions

Author: mitchspano

docs/README.md

@@ -101,7 +101,7 @@ trigger AccountTrigger on Account (
   after delete,
   after undelete
 ) {
-    new MetadataTriggerHandler.execute();
+    new MetadataTriggerHandler.run();
 }
 ```
 

docs/index.md

@@ -110,7 +110,7 @@ public static void clearAllBypasses()
 
 ### `handleDynamicFinalizers()`
 
-Handle dynamic finalizers.nstantiates and executes finalizers based on metadata.
+Handle dynamic finalizers. Instantiates and executes finalizers based on metadata.
 
 #### Signature
 ```apex

docs/trigger-actions-framework/FinalizerHandler.md

@@ -53,7 +53,7 @@ trigger AccountTrigger on Account (
   after delete,
   after undelete
 ) {
-    new MetadataTriggerHandler.execute();
+    new MetadataTriggerHandler.run();
 }
 ```
 

docs/trigger-actions-framework/MetadataTriggerHandler.md

@@ -94,7 +94,7 @@ public with sharing virtual class FinalizerHandler {
 	}
 
 	/**
-	 * @description Handle dynamic finalizers.nstantiates and executes finalizers based on metadata.
+	 * @description Handle dynamic finalizers. Instantiates and executes finalizers based on metadata.
 	 */
 	public virtual void handleDynamicFinalizers() {
 		Context context = new Context();
@@ -106,7 +106,7 @@ public with sharing virtual class FinalizerHandler {
 			populatePermissionMap(finalizerMetadata.Bypass_Permission__c);
 			populatePermissionMap(finalizerMetadata.Required_Permission__c);
 			if (
-				isNotBypassed(
+				!isBypassed(
 					finalizerMetadata.Bypass_Permission__c,
 					finalizerMetadata.Required_Permission__c
 				)
@@ -172,18 +172,18 @@ public with sharing virtual class FinalizerHandler {
 	}
 
 	/**
-	 * @description Check if the finalizer is not bypassed.
-	 * @param requiredPermission The required permission.
-	 * @param bypassPermission The bypass permission.
-	 * @return True if the finalizer is not bypassed, false otherwise.
+	 * @description Check if the finalizer is bypassed.
+	 *
+	 * @param bypassPermission The bypass permission for the finalizer.
+	 * @param requiredPermission The required permission for the finalizer.
+	 * @return True if bypassed, false otherwise.
 	 */
-	private boolean isNotBypassed(
-		String requiredPermission,
-		String bypassPermission
+	private boolean isBypassed(
+		String bypassPermission,
+		String requiredPermission
 	) {
-		return !((requiredPermission != null &&
-		permissionMap.get(requiredPermission)) ||
-		(bypassPermission != null && !permissionMap.get(bypassPermission)));
+		return (bypassPermission != null && permissionMap.get(bypassPermission)) ||
+			(requiredPermission != null && !permissionMap.get(requiredPermission));
 	}
 
 	/**

trigger-actions-framework/main/default/classes/FinalizerHandler.cls

@@ -23,12 +23,15 @@ private with sharing class FlowChangeEventHeaderTest {
 
 	@IsTest
 	private static void shouldBeAbleToConstruct() {
-		Assert.isNotNull(header, 'Unable to construct a FlowChangeEventHeader');
+		System.Assert.isNotNull(
+			header,
+			'Unable to construct a FlowChangeEventHeader'
+		);
 	}
 
 	@IsTest
 	private static void shouldBeAbleToGenerateHashCode() {
-		Assert.isNotNull(header.hashCode(), 'Hash code was not generated');
+		System.Assert.isNotNull(header.hashCode(), 'Hash code was not generated');
 	}
 
 	@IsTest
@@ -38,17 +41,17 @@ private with sharing class FlowChangeEventHeaderTest {
 		);
 		other.changeType = 'CREATE';
 
-		Assert.areEqual(
+		System.Assert.areEqual(
 			new FlowChangeEventHeader(new EventBus.ChangeEventHeader()),
 			header,
 			'Unable to detect identical FlowChangeEventHeader objects'
 		);
-		Assert.areNotEqual(
+		System.Assert.areNotEqual(
 			header,
 			other,
 			'Unable to detect different FlowChangeEventHeader objects'
 		);
-		Assert.areNotEqual(
+		System.Assert.areNotEqual(
 			header,
 			null,
 			'Unable to detect difference between FlowChangeEventHeader and null'