Simplify the check for permission based bypass. (#165)

Fix the order of declaration and make the method easier to understand.

Author: mitchspano

.prettierrc

@@ -1,14 +1,15 @@
 {
-  "trailingComma": "none",
-  "useTabs": true,
-  "overrides": [
-    {
-      "files": "**/lwc/**/*.html",
-      "options": { "parser": "lwc" }
-    },
-    {
-      "files": "*.{cmp,page,component}",
-      "options": { "parser": "html" }
-    }
-  ]
+	"plugins": ["prettier-plugin-apex"],
+	"trailingComma": "none",
+	"useTabs": true,
+	"overrides": [
+		{
+			"files": "**/lwc/**/*.html",
+			"options": { "parser": "lwc" }
+		},
+		{
+			"files": "*.{cmp,page,component}",
+			"options": { "parser": "html" }
+		}
+	]
 }

sfdx-project.json

@@ -37,6 +37,7 @@
 		"Trigger Actions [email protected]": "04tKY000000Pb8ZYAS",
 		"Trigger Actions [email protected]": "04tKY000000Pd90YAC",
 		"Trigger Actions [email protected]": "04tKY000000Pd95YAC",
-		"Trigger Actions [email protected]": "04tKY000000Pd9AYAS"
+		"Trigger Actions [email protected]": "04tKY000000Pd9AYAS",
+		"Trigger Actions [email protected]": "04tKY000000PdYBYA0"
 	}
 }

trigger-actions-framework/main/default/classes/MetadataTriggerHandler.cls

@@ -325,27 +325,26 @@ public inherited sharing class MetadataTriggerHandler extends TriggerBase implem
 			populatePermissionMap(permissionName);
 		}
 
-		return isNotBypassed(
+		return !isBypassed(
 				actionMetadata.Bypass_Permission__c,
 				actionMetadata.Required_Permission__c
 			) &&
-			isNotBypassed(sObjectBypassPermissionName, sObjectRequiredPermissionName);
+			!isBypassed(sObjectBypassPermissionName, sObjectRequiredPermissionName);
 	}
 
 	/**
-	 * @description Check if the Trigger Action is not bypassed.
+	 * @description Check if the Trigger Action or SObject is bypassed.
 	 *
-	 * @param requiredPermission The required permission for the Trigger Action.
 	 * @param bypassPermission The bypass permission for the Trigger Action.
-	 * @return True if the Trigger Action is not bypassed, false otherwise.
+	 * @param requiredPermission The required permission for the Trigger Action.
+	 * @return True if bypassed, false otherwise.
 	 */
-	private static boolean isNotBypassed(
-		String requiredPermission,
-		String bypassPermission
+	private static boolean isBypassed(
+		String bypassPermission,
+		String requiredPermission
 	) {
-		return !((requiredPermission != null &&
-		permissionMap.get(requiredPermission)) ||
-		(bypassPermission != null && !permissionMap.get(bypassPermission)));
+		return (bypassPermission != null && permissionMap.get(bypassPermission)) ||
+			(requiredPermission != null && !permissionMap.get(requiredPermission));
 	}
 
 	/**