Code review feedback from @mitchspano to continue to support decimal-based orderings for finalizers

jamessimone · jamessimone · commit fa15339ced9f · 2025-11-13T11:37:30.000-05:00
diff --git a/trigger-actions-framework/main/default/classes/FinalizerHandler.cls b/trigger-actions-framework/main/default/classes/FinalizerHandler.cls
@@ -202,8 +202,8 @@ public with sharing virtual class FinalizerHandler {
 			DML_Finalizer__mdt first,
 			DML_Finalizer__mdt second
 		) {
-			Integer difference = (first.Order__c - second.Order__c).intValue();
-			return difference < 0 ? difference : difference == 0 ? 0 : 1;
+			Decimal difference = (first.Order__c - second.Order__c);
+			return difference < 0 ? -1 : difference == 0 ? 0 : 1;
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -202,8 +202,8 @@ public with sharing virtual class FinalizerHandler {`
`202`	`202`	`DML_Finalizer__mdt first,`
`203`	`203`	`DML_Finalizer__mdt second`
`204`	`204`	`) {`
`205`		`- Integer difference = (first.Order__c - second.Order__c).intValue();`
`206`		`- return difference < 0 ? difference : difference == 0 ? 0 : 1;`
	`205`	`+ Decimal difference = (first.Order__c - second.Order__c);`
	`206`	`+ return difference < 0 ? -1 : difference == 0 ? 0 : 1;`
`207`	`207`	`}`
`208`	`208`	`}`
`209`	`209`