Help with the finalizer

[justin-lyon]

Overview

I was just trying to demo the DMLFinalizer functionality. Below is my code and cmdt for the Opportunity. I'm expecting the Finalizer to simply call System.debug but I don't see my USER_DEBUG line in the debug logs. This is in a new Developer Edition sandbox with TAF, Apex-rollup, and Nebula Logger installed as unlocked packages.

Trigger

trigger OpportunityTrigger on Opportunity (
  before insert,
  before update,
  after insert,
  after update
) {
  new MetadataTriggerHandler().run();
}

Trigger Action

public with sharing class Opportunity_SalesRules implements TriggerAction.BeforeInsert, TriggerAction.BeforeUpdate {
  public static final String PROSPECTING_STAGE = 'Prospecting';
  public static final String INVALID_STAGE_INSERT_ERROR = 'New Opportunities must start in the Prospecting stage.';

  public void beforeInsert(List<Opportunity> newOpportunities) {
    for (Opportunity newOpp : newOpportunities) {
      if (newOpp.StageName != 'Prospecting') {
        Logger.debug(INVALID_STAGE_INSERT_ERROR, newOpp);
        newOpp.addError(INVALID_STAGE_INSERT_ERROR);
      }
    }
  }

  public static final String CLOSED_WON_STAGE = 'Closed Won';
  public static final String INVALID_STAGE_UPDATE_ERROR = 'Closed Won Opportunities cannot be moved to another stage.';

  public void beforeUpdate(List<Opportunity> newOpps, List<Opportunity> oldOpps) {
    Map<Id, Opportunity> oldOppMap = new Map<Id, Opportunity>(oldOpps);
    for (Opportunity newOpp : newOpps) {
      Opportunity oldOpp = oldOppMap.get(newOpp.Id);
      if (oldOpp.StageName == CLOSED_WON_STAGE && newOpp.StageName != CLOSED_WON_STAGE) {
        Logger.debug(INVALID_STAGE_UPDATE_ERROR, newOpp);
        newOpp.addError(INVALID_STAGE_UPDATE_ERROR);
      }
    }
  }
}

Account Finalizer

public with sharing class Account_DmlFinalizer implements TriggerAction.DmlFinalizer {
  public void execute(FinalizerHandler.Context context) {
    System.debug('Account DML Finalizer executed.');
    Logger.saveLog();
  }
}

Opp Finalizer

public with sharing class Opportunity_DmlFinalizer implements TriggerAction.DmlFinalizer {
  public void execute(FinalizerHandler.Context context) {
    System.debug('Opportunity DML Finalizer executed.');
    Logger.saveLog();
  }
}

Opportunity Trigger Setting

Finalizer Config

Account Finalizer Config

Opp Finalizer Config

Two Finalizers

[mitchspano]

This setup works fine for me. I did not use Nebula Logger or anything else - pure TAF.

Keep in mind that finalizers are very fragile. There are many events on the platform which can prevent the system from being able to detect when to finalize. If you have another trigger on the sObject, or even a record triggered flow which performs DML, then all bets are off.

System.Savepoint sp = Database.setSavepoint();
TriggerBase.offsetExistingDmlRows();

insert new Opportunity(
  Name = 'Demo',
  StageName = 'Prospecting',
  CloseDate = Date.Today()
);

Database.rollback(sp);

20:13:12.4 (926125978)|USER_DEBUG|[3]|DEBUG|Account DML Finalizer executed.
20:13:12.4 (941311773)|USER_DEBUG|[3]|DEBUG|Opportunity DML Finalizer executed.

trigger OpportunityTrigger on Opportunity(
	before insert,
	before update,
	after insert,
	after update
) {
	new MetadataTriggerHandler().run();
}

<?xml version="1.0" encoding="UTF-8"?>
<CustomMetadata xmlns="http://soap.sforce.com/2006/04/metadata" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <label>Opportunity</label>
    <protected>false</protected>
    <values>
        <field>Bypass_Execution__c</field>
        <value xsi:type="xsd:boolean">false</value>
    </values>
    <values>
        <field>Bypass_Permission__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Object_API_Name__c</field>
        <value xsi:type="xsd:string">Opportunity</value>
    </values>
    <values>
        <field>Object_Namespace__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Required_Permission__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>TriggerRecord_Class_Name__c</field>
        <value xsi:nil="true"/>
    </values>
</CustomMetadata>

public with sharing class Opportunity_StageRules implements TriggerAction.BeforeInsert, TriggerAction.BeforeUpdate {
	public static final String PROSPECTING_STAGE = 'Prospecting';
	public static final String INVALID_STAGE_INSERT_ERROR = 'New Opportunities must start in the Prospecting stage.';

	public void beforeInsert(List<Opportunity> newOpportunities) {
		for (Opportunity newOpp : newOpportunities) {
			if (newOpp.StageName != 'Prospecting') {
				newOpp.addError(INVALID_STAGE_INSERT_ERROR);
			}
		}
	}

	public static final String CLOSED_WON_STAGE = 'Closed Won';
	public static final String INVALID_STAGE_UPDATE_ERROR = 'Closed Won Opportunities cannot be moved to another stage.';

	public void beforeUpdate(
		List<Opportunity> newOpps,
		List<Opportunity> oldOpps
	) {
		Map<Id, Opportunity> oldOppMap = new Map<Id, Opportunity>(oldOpps);
		for (Opportunity newOpp : newOpps) {
			Opportunity oldOpp = oldOppMap.get(newOpp.Id);
			if (
				oldOpp.StageName == CLOSED_WON_STAGE &&
				newOpp.StageName != CLOSED_WON_STAGE
			) {
				newOpp.addError(INVALID_STAGE_UPDATE_ERROR);
			}
		}
	}
}

<?xml version="1.0" encoding="UTF-8"?>
<CustomMetadata xmlns="http://soap.sforce.com/2006/04/metadata" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <label>Opportunity_StageRules_BI</label>
    <protected>false</protected>
    <values>
        <field>After_Delete__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>After_Insert__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>After_Undelete__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>After_Update__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Allow_Flow_Recursion__c</field>
        <value xsi:type="xsd:boolean">false</value>
    </values>
    <values>
        <field>Apex_Class_Name__c</field>
        <value xsi:type="xsd:string">Opportunity_StageRules</value>
    </values>
    <values>
        <field>Before_Delete__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Before_Insert__c</field>
        <value xsi:type="xsd:string">Opportunity</value>
    </values>
    <values>
        <field>Before_Update__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Bypass_Execution__c</field>
        <value xsi:type="xsd:boolean">false</value>
    </values>
    <values>
        <field>Bypass_Permission__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Description__c</field>
        <value xsi:type="xsd:string">Demo</value>
    </values>
    <values>
        <field>Entry_Criteria__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Flow_Name__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Order__c</field>
        <value xsi:type="xsd:double">1.0</value>
    </values>
    <values>
        <field>Required_Permission__c</field>
        <value xsi:nil="true"/>
    </values>
</CustomMetadata>

<?xml version="1.0" encoding="UTF-8"?>
<CustomMetadata xmlns="http://soap.sforce.com/2006/04/metadata" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <label>Opportunity_StageRules_BU</label>
    <protected>false</protected>
    <values>
        <field>After_Delete__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>After_Insert__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>After_Undelete__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>After_Update__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Allow_Flow_Recursion__c</field>
        <value xsi:type="xsd:boolean">false</value>
    </values>
    <values>
        <field>Apex_Class_Name__c</field>
        <value xsi:type="xsd:string">Opportunity_StageRules</value>
    </values>
    <values>
        <field>Before_Delete__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Before_Insert__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Before_Update__c</field>
        <value xsi:type="xsd:string">Opportunity</value>
    </values>
    <values>
        <field>Bypass_Execution__c</field>
        <value xsi:type="xsd:boolean">false</value>
    </values>
    <values>
        <field>Bypass_Permission__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Description__c</field>
        <value xsi:type="xsd:string">demo</value>
    </values>
    <values>
        <field>Entry_Criteria__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Flow_Name__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Order__c</field>
        <value xsi:type="xsd:double">1.0</value>
    </values>
    <values>
        <field>Required_Permission__c</field>
        <value xsi:nil="true"/>
    </values>
</CustomMetadata>

public with sharing class Opportunity_Finalizer implements TriggerAction.DmlFinalizer {
	public void execute(FinalizerHandler.Context context) {
		System.debug('Opportunity DML Finalizer executed.');
	}
}

<?xml version="1.0" encoding="UTF-8"?>
<CustomMetadata xmlns="http://soap.sforce.com/2006/04/metadata" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <label>Opportunity_Finalizer</label>
    <protected>false</protected>
    <values>
        <field>Apex_Class_Name__c</field>
        <value xsi:type="xsd:string">Opportunity_Finalizer</value>
    </values>
    <values>
        <field>Bypass_Execution__c</field>
        <value xsi:type="xsd:boolean">false</value>
    </values>
    <values>
        <field>Bypass_Permission__c</field>
        <value xsi:nil="true"/>
    </values>
    <values>
        <field>Order__c</field>
        <value xsi:type="xsd:double">1.0</value>
    </values>
    <values>
        <field>Required_Permission__c</field>
        <value xsi:nil="true"/>
    </values>
</CustomMetadata>

public with sharing class Account_Finalizer implements TriggerAction.DmlFinalizer {
	public void execute(FinalizerHandler.Context context) {
		System.debug('Account DML Finalizer executed.');
	}
}

<?xml version="1.0" encoding="UTF-8"?>
<CustomMetadata xmlns="http://soap.sforce.com/2006/04/metadata"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <label>Opportunity_Finalizer</label>
    <protected>false</protected>
    <values>
        <field>Apex_Class_Name__c</field>
        <value xsi:type="xsd:string">Account_Finalizer</value>
    </values>
    <values>
        <field>Bypass_Execution__c</field>
        <value xsi:type="xsd:boolean">false</value>
    </values>
    <values>
        <field>Bypass_Permission__c</field>
        <value xsi:nil="true" />
    </values>
    <values>
        <field>Order__c</field>
        <value xsi:type="xsd:double">0.0</value>
    </values>
    <values>
        <field>Required_Permission__c</field>
        <value xsi:nil="true" />
    </values>
</CustomMetadata>