Evals moved to external loader as before. internal functions are injected in function parameters without deending on eval to induce dynamic scopes

Author: mithunsatheesh

test/rules.js

@@ -35,15 +35,14 @@ var rules = [
 	"priority": 3,
 	"on":1,
 	"condition":
-		function(cb) {
-			cb(this && (this.transactionTotal < 500));
+		function(R) {
+			R.when(this && (this.transactionTotal < 500));
 		},
 	"consequence":
-		function(cb) {
+		function(R) {
 			console.log("Rule 1 matched for "+this.name+": blocks transactions below value 500. Rejecting payment.");
 			this.result = false;
-			this.complete = true;
-            cb();
+			R.stop();
 		}
   },
   /**** Rule 2 ****/
@@ -53,15 +52,14 @@ var rules = [
 	"priority":2,
 	"on":1, 
 	"condition":
-		function(cb) {
-			cb(this && this.userCredibility && (this.userCredibility > 5));
+		function(R) {
+			R.when(this && this.userCredibility && (this.userCredibility > 5));
 		},
 	"consequence":
-		function(cb) {
+		function(R) {
 			console.log("Rule 2 matched for "+this.name+": if the users credibility value is more, then avoid checking further. Accepting payment. ");
 			this.result = true; 
-			this.complete = true;
-            cb();
+			R.stop();
 		}
   },
   /**** Rule 3 ****/
@@ -71,15 +69,14 @@ var rules = [
 	"priority": 4,
 	"on":1,
 	"condition":
-		function(cb) {
-			cb(this && (this.cardType == "Credit Card") && (this.cardIssuer == "American Express") && (this.transactionTotal > 1000));
+		function(R) {
+			R.when(this && (this.cardType == "Credit Card") && (this.cardIssuer == "American Express") && (this.transactionTotal > 1000));
 		},
 	"consequence":
-		function(cb) {
+		function(R) {
 			console.log("Rule 3 matched for "+this.name+": filter American Express credit cards for payment above 10000. Rejecting payment.");
 			this.result = false;
-			this.complete = true;
-            cb();
+			R.stop();
 		}
   },
   /**** Rule 4 ****/
@@ -89,18 +86,17 @@ var rules = [
 	"priority":8,
 	"on":1,
 	"condition":
-		function(cb) {
+		function(R) {
 
-			cb(this && (this.cardType == "Cash Card"));
+			R.when(this && (this.cardType == "Cash Card"));
 
 		},
 	"consequence":
-		function(cb) {
+		function(R) {
 
 			console.log("Rule 4 matched for "+this.name+": reject the payment if the payment type belong to cash card. Rejecting payment.");
 			this.result = false; 
-			this.complete = true;
-            cb();
+			R.stop();
 
 		}
   },
@@ -111,15 +107,14 @@ var rules = [
 	"priority":6,
 	"on":1,
 	"condition":
-		function(cb) {
-			cb(this && this.customerType && (this.transactionTotal > 10000) && (this.customerType == "guest"));
+		function(R) {
+			R.when(this && this.customerType && (this.transactionTotal > 10000) && (this.customerType == "guest"));
 		},
 	"consequence":
-		function(cb) {
+		function(R) {
 			console.log("Rule 5 matched for "+this.name+": reject the payment if the payment above 10000 and customer type is guest. Rejecting payment.");
 			this.result = false; 
-			this.complete = true;
-            cb();
+			R.stop();
 		}
   },
   /**** Rule 6 ****/
@@ -129,14 +124,14 @@ var rules = [
 	"priority":7,
 	"on":1,
 	"condition":
-		function(cb) {
-			cb(this && !this.userLoggedIn);
+		function(R) {
+			R.when(this && !this.userLoggedIn);
 		},
 	"consequence":
-		function(cb) {
+		function(R) {
 			console.log("Rule 6 matched for "+this.name+": support rule written for blocking payment above 10000 from guests. complete left to chain with rule 6.");
 			this.customerType = "guest"; 
-            cb();
+            R.next();
 		}  
   },
   /**** Rule 7 ****/
@@ -146,15 +141,14 @@ var rules = [
 	"priority":5,
 	"on":1, 
 	"condition":
-		function(cb) {
-			cb(this && this.appCode && (this.appCode == "MOBI4"));
+		function(R) {
+			R.when(this && this.appCode && (this.appCode == "MOBI4"));
 		},
 	"consequence":
-		function(cb) {
+		function(R) {
 			console.log("Rule 7 matched for "+this.name+": turn on this rule to block the payment from a specific app. Reject Paymant.");
 			this.result = false; 
-			this.complete = true;
-            cb();
+			R.stop();
 		}
   },
   /**** Rule 8 ****/
@@ -164,15 +158,14 @@ var rules = [
 	"priority":2,
 	"on":1, 
 	"condition":
-		function(cb) {
-			cb(this && this.eventRiskFactor && (this.eventRiskFactor < 5));
+		function(R) {
+			R.when(this && this.eventRiskFactor && (this.eventRiskFactor < 5));
 		},
 	"consequence":
-		function(cb) {
+		function(R) {
 			console.log("Rule 8 matched for "+this.name+": if the event is top priority event, then do further checks else leave. Accept payment as low priority event.");
 			this.result = true; 
-			this.complete = true;
-            cb();
+			R.stop();
 		}
   },
   /**** Rule 9 ****/
@@ -182,7 +175,7 @@ var rules = [
 	"priority":3,
 	"on":1, 
 	"condition":
-		function(cb) {
+		function(R) {
 			 var allowedRegexp = new RegExp('^(?:' + 
 			  [ 
 			  "10.X.X.X", 
@@ -193,17 +186,20 @@ var rules = [
 			  "74.23.211.92"
 			].join('|').replace(/\./g, '\\.').replace(/X/g, '[^.]+') + 
 			')$');
-			cb(this && this.userIP && this.userIP.match(allowedRegexp));
+			R.when(this && this.userIP && this.userIP.match(allowedRegexp));
 		},
 	"consequence":
-		function(cb) {
+		function(R) {
 			console.log("Rule 9 matched for "+this.name+": if the ip fall in the given list of formats, then block the transaction. Rejecting payment.");
 			this.result = false; 
-			this.complete = true;
-            cb();
+			R.stop();
 		}
   },
   /**** Rule 10 * fails 
+  
+  This rule has to be rewritten. Because the rules defined should not have closures which prevent its 
+  export-ability. Pass the details as fact.
+  
   {
 	"name" : "check if user's name is blacklisted in db",
 	"description" : "if the user's name is found then block transaction.",