setup.py -> pyproject.toml migration

[snoopy-coder]

When I try to install according to the documentation, I get this warning:

C:\Users\1\Downloads\android-unpinner>pip install -e .
Obtaining file:///C:/Users/1/Downloads/android-unpinner
  Preparing metadata (setup.py) ... done
Requirement already satisfied: rich_click in c:\users\1\downloads\python-3.10.18\lib\site-packages (from android-unpinner==1.0) (1.8.9)
Requirement already satisfied: click>=7 in c:\users\1\downloads\python-3.10.18\lib\site-packages (from rich_click->android-unpinner==1.0) (8.2.1)
Requirement already satisfied: rich>=10.7 in c:\users\1\downloads\python-3.10.18\lib\site-packages (from rich_click->android-unpinner==1.0) (14.0.0)
Requirement already satisfied: typing_extensions>=4 in c:\users\1\downloads\python-3.10.18\lib\site-packages (from rich_click->android-unpinner==1.0) (4.14.1)
Requirement already satisfied: colorama in c:\users\1\downloads\python-3.10.18\lib\site-packages (from click>=7->rich_click->android-unpinner==1.0) (0.4.6)
Requirement already satisfied: markdown-it-py>=2.2.0 in c:\users\1\downloads\python-3.10.18\lib\site-packages (from rich>=10.7->rich_click->android-unpinner==1.0) (3.0.0)
Requirement already satisfied: pygments<3.0.0,>=2.13.0 in c:\users\1\downloads\python-3.10.18\lib\site-packages (from rich>=10.7->rich_click->android-unpinner==1.0) (2.19.2)
Requirement already satisfied: mdurl~=0.1 in c:\users\1\downloads\python-3.10.18\lib\site-packages (from markdown-it-py>=2.2.0->rich>=10.7->rich_click->android-unpinner==1.0) (0.1.2)
Installing collected packages: android-unpinner
@@   DEPRECATION: Legacy editable install of android-unpinner==1.0 from file:///C:/Users/1/Downloads/android-unpinner (setup.py develop) is deprecated. pip 25.3 will enforce this behaviour change. @@
@@ A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings @@
@@ editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at https://github.com/pypa/pip/issues/11457 @@
  Running setup.py develop for android-unpinner
Successfully installed android-unpinner-1.0

C:\Users\1\Downloads\android-unpinner>

Is it possible to add pyproject.toml instead of setup.py and how difficult is it to do this? Can anyone help? Thanks a lot.

[Davis-3450]

Will look up into this :)

[Davis-3450]

#48 just did :) try it out @snoopy-coder

[snoopy-coder]

@Davis-3450, thank you so much for your work, it's a pity these changes were not approved.
I agree with @mhils - any tools for automatic migration are still not good enough to fully trust them. Unfortunately, I don't know how to do PR by all the rules, but let me show you my hand-made version of pyproject.toml:

[project]
name = "android-unpinner"
version = "1.0"
description = "Android Certificate Pinning Unpinner"
authors = [
    {name = "Maximilian Hils", email = "[email protected]"},
]

dependencies = [
    "setuptools >= 64.0.0",
    "rich_click",
]

requires-python = ">=3.10"
readme = "README.md"

classifiers = [
    "Development Status :: 5 - Production/Stable",
    "Environment :: Console",
    "Intended Audience :: Developers",
    "Operating System :: MacOS",
    "Operating System :: Microsoft :: Windows",
    "Operating System :: POSIX",
    "Programming Language :: Python :: 3.10",
    "Topic :: Internet :: Proxy Servers",
    "Topic :: Internet :: WWW/HTTP",
    "Topic :: Security",
    "Topic :: Software Development :: Testing",
    "Topic :: System :: Networking :: Monitoring",
    "Typing :: Typed",
]

[project.urls]
Homepage = "https://github.com/mitmproxy/android-unpinner"
Source = "https://github.com/mitmproxy/android-unpinner"
Documentation = "https://github.com/mitmproxy/android-unpinner"
Issues = "https://github.com/mitmproxy/android-unpinner/issues"

[project.scripts]
android-unpinner = "android_unpinner.__main__:cli"
aup = "android_unpinner.__main__:cli"

[tool.setuptools]
include-package-data = true

[tool.setuptools.packages.find]
include = [
    "android_unpinner",
    "android_unpinner.*",
]

PS. I assume that this is not an ideal solution and there may be problems, for example, with MANIFEST.in.

[mhils]

Feel free to open a PR if you have something that you personally reviewed and tested, I appreciate contributions. I also don't mind people use AI. But I do mind finding hallucinated URLs in PRs and similar obvious issues. That just shows disregard for the maintainer.

[snoopy-coder]

To be honest, I haven't tested this configuration well enough. Firstly, I did not have the opportunity to test it on Linux and macOS, but no installation errors were found on Windows.
I have moved all the settings from setup.py manually and some sections (such as classifiers = [ ... ]) were simply shamelessly copied. But, in my opinion, the most important thing is to add and use all the necessary dependencies correctly, and this is exactly what AI failed to do.

PS. I don't really feel the difference between words disregard and disrespect in English very well, but I assure you that I didn't want to demonstrate either at all.