Merge pull request #2166 from mito-ds/improve-verify

improve cursor validation commands

Author: aarondr77

.cursor/commands/verify.md

@@ -1,31 +1,42 @@
 # Verify Feature Command
 
-When invoked, automatically test and fix the feature that you just created using the Browser tool to access JupyterLab. Continue correcting and verifying the feature until it works. 
+When invoked, automatically verify a feature or change by launching the appropriate app (JupyterLab or trymito.io), testing baseline functionality, and fixing issues until the feature works correctly.
+
+## App Detection
+
+Automatically determine which app to verify based on:
+- Files in `mito-ai/` → Verify in JupyterLab
+- Files in `trymito.io/` → Verify in trymito.io website
+- User specification or plan context if provided
 
 ## Execution Steps
 
 ### 0. Setting up Environment
 
 Make sure that the code passes linting first. Check the typescript terminal that is running for errors. You must resolve those first to ensure you are testing the most up to date version of the code.
 
-### 1. Check JupyterLab Status
+### 1. Determine Target App and Check Status
 
-First, verify JupyterLab is running on port 8888. Navigate to:
-```
-http://localhost:8888/lab?token=dev-token-for-cursor-testing-12345
-```
+**For JupyterLab:**
+- Verify JupyterLab is running on port 8888
+- Navigate to: `http://localhost:8888/lab?token=dev-token-for-cursor-testing-12345`
+
+**For trymito.io:**
+- Verify Next.js dev server is running on port 3000
+- If not running, provide instructions: `cd trymito.io && npm run dev`
+- Navigate to: `http://localhost:3000`
 
 ### 2. Navigate and Load
 
-Use browser to navigate to JupyterLab URL above. Wait 3-5 seconds for full page load, then take a snapshot to understand current state.
+Use browser to navigate to the appropriate URL. Wait 3-5 seconds for full page load, then take a snapshot to understand current state.
 
 ### 3. Identify Feature to Test
 
-Use the conversation history to identify the feature to test. Your goal is to QA the new feature that was just created.
+Use the conversation history to identify the feature to test. Your goal is to validate the feature that was just created or changed.
 
 ### 4. Test the Feature
 
-Interact with the feature using browser tools:
+Interact with the feature using browser tools and test baseline functionality to ensure no regressions.
 
 ### 5. Check for Issues
 
@@ -37,29 +48,25 @@ After each interaction:
 
 ### 6. Fix Issues Found
 
-- Fix the issues you found if if they are related to the feature you are testing
-- Document any additional issues you found that are not related to the feature you are testing
+Fix the issues you found if they are related to the feature you are testing. Document any additional issues you found that are not related to the feature you are testing.
 
 ### 7. Rebuild and Re-test
 
 After making code changes and before testing again:
 
 1. **For Frontend Changes** (TypeScript/React/CSS/JavaScript):
    - Wait a few seconds for the build to complete (check the TypeScript terminal)
-   - **Refresh the browser** to load the updated code:
-     - Use browser navigation to reload the page, or
-     - Use browser refresh functionality
+   - **Refresh the browser** to load the updated code
    - Retest the feature
 
-
 2. **For Backend Changes** (Python/server code):
-   - **Shut down the Jupyter server** (stop the running JupyterLab process)
-   - **Relaunch the Jupyter server** to load the updated backend code
-   - Navigate to the JupyterLab URL again
+   - **Shut down the server** (stop the running process)
+   - **Relaunch the server** to load the updated backend code
+   - Navigate to the app URL again
    - Wait 3-5 seconds for full page load
    - Take a new snapshot
    - Re-test the feature
 
 ### 8. Iterate Until Complete
 
-Repeat steps 4-7 until the feature works correctly. 
+Repeat steps 4-7 until the feature works correctly.

.cursorrules

@@ -1,5 +1,34 @@
 # Cursor Rules for Mito Project
 
-## Virtual Environment
-- ALWAYS activate the virtual environment before running any Python commands: `cd mito-ai && source venv/bin/activate`
-- For other components: check for venv directories and activate appropriately
+## Verify Mode
+
+When creating plans or implementing features, use verify mode to ensure quality:
+
+### Automatic Validation Step Insertion
+- After each implementation task in a plan, automatically insert a validation step
+- Validation steps should specify which app to verify (JupyterLab or trymito.io) based on:
+  - Files being modified: `mito-ai/` → JupyterLab, `trymito.io/` → trymito.io website
+  - Context from the implementation task
+  - User specification if provided
+
+### Validation Workflow
+When executing validation steps:
+1. **App Detection**: Determine target app (JupyterLab: localhost:8888, trymito.io: localhost:3000)
+2. **Baseline Validation**: Ensure existing functionality still works
+3. **Improvement Analysis**: Identify potential improvements (bugs, UX, code quality)
+4. **Prioritization**: Create prioritized list (P0 Critical → P1 High → P2 Medium → P3 Low)
+5. **Decision**: Decide if improvements are worth implementing now
+6. **Implementation Loop**: If yes, implement highest priority, rebuild, re-validate (repeat)
+7. **Completion**: Mark validation complete and move to next task
+
+### Validation Command
+- Use the `verify` command (`.cursor/commands/verify.md`) for manual validation
+- The command automatically detects which app to use based on file paths
+- Follow the verify workflow: baseline → improvements → prioritize → implement → verify
+
+### App-Specific Notes
+- **JupyterLab**: Runs on `localhost:8888`, token: `dev-token-for-cursor-testing-12345`
+- **trymito.io**: Next.js app runs on `localhost:3000`, start with `cd trymito.io && npm run dev`
+- Always check app is running before validation
+- For frontend changes: wait for build, refresh browser
+- For backend changes: restart server if needed, reload page

agent.md

@@ -0,0 +1,14 @@
+## Virtual Environment
+- ALWAYS activate the virtual environment before running any Python commands: `cd mito-ai && source venv/bin/activate`
+- For other components: check for venv directories and activate appropriately
+
+## Engineering practices
+
+We're a startup. You're probably used to writing enterprise code -- code that tries to handle every possible edge case and has fallbacks for everything. That's not how we do things around here: our number one rule is to keep things simple. We handle ONLY the most important cases.
+
+We try to only add new functionality that is small (that is, simple and few lines of code) or absolutely necessary. If a change is not small or absolutely necessary, don't make it.
+
+**Backwards-compatibility**: Since our app runs locally on a user's machine, we think about backwards compatibility very differently than enterprise code.
+- For things like updating the environment variables structure, we don't need to worry about backwards compatibility because if the enterprise opts in to upgrading, they can update the enviornment variables at the same time. 
+- For things like adding new tool options, we don't need to worry about backwards compatibility because only users on the newest version of the tool are going to have access to the new options.
+- For things like changing how we read in old chat histories, we DO need to worry about backwards compatibility because the chat histories live on the user's machine, so we don't have a way to migrate them to the new format without adding that migration step into the tool.