Fix issues with course certificate generation (#3106)

Author: jkachel

courses/api.py

@@ -845,9 +845,14 @@ def generate_course_run_certificates():
             0,
         )
         for edx_grade, user in edx_grade_user_iter:
-            course_run_grade, created, updated = ensure_course_run_grade(
-                user=user, course_run=run, edx_grade=edx_grade, should_update=True
-            )
+            try:
+                course_run_grade, created, updated = ensure_course_run_grade(
+                    user=user, course_run=run, edx_grade=edx_grade, should_update=True
+                )
+            except ValidationError:
+                msg = f"Can't save grade {edx_grade} for {user} in {run}, skipping certificate generation"
+                log.exception(msg)
+                continue
 
             if created:
                 created_grades_count += 1

courses/migrations/0075_update_course_run_grade_allow_extra_credit.py

@@ -0,0 +1,23 @@
+# Generated by Django 4.2.25 on 2025-11-24 15:31
+
+import django.core.validators
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("courses", "0074_populate_issue_date"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="courserungrade",
+            name="grade",
+            field=models.FloatField(
+                validators=[
+                    django.core.validators.MinValueValidator(0.0),
+                    django.core.validators.MaxValueValidator(2.0),
+                ]
+            ),
+        ),
+    ]

courses/models.py

@@ -1710,7 +1710,7 @@ class CourseRunGrade(TimestampedModel, AuditableModel, ValidateOnSaveMixin):
     user = models.ForeignKey(User, null=False, on_delete=models.CASCADE)
     course_run = models.ForeignKey(CourseRun, null=False, on_delete=models.CASCADE)
     grade = models.FloatField(
-        null=False, validators=[MinValueValidator(0.0), MaxValueValidator(1.0)]
+        null=False, validators=[MinValueValidator(0.0), MaxValueValidator(2.0)]
     )
     letter_grade = models.CharField(max_length=6, blank=True, null=True)  # noqa: DJ001
     passed = models.BooleanField(default=False)
@@ -1728,11 +1728,11 @@ def to_dict(self):
 
     @property
     def grade_percent(self) -> Decimal:
-        """Returns the grade field value as a number out of 100 (or None if the value is None)"""
+        """Returns the grade field value as a number out of 100 (or Decimal(0) if the value is None)"""
         return (
             Decimal(self.grade * 100).quantize(exp=Decimal(1), rounding=ROUND_HALF_EVEN)
             if self.grade is not None
-            else None
+            else Decimal(0)
         )
 
     @property

courses/serializers/v1/base.py

@@ -116,6 +116,8 @@ class Meta:
 class CourseRunGradeSerializer(serializers.ModelSerializer):
     """CourseRunGrade serializer"""
 
+    grade = serializers.FloatField(min_value=0.0, max_value=1.0)
+
     class Meta:
         model = models.CourseRunGrade
         fields = ["grade", "letter_grade", "passed", "set_by_admin", "grade_percent"]