Fix updating of global_id (#262)

Author: rhysyngsun

src/scim/mitol/scim/api.py

@@ -255,13 +255,13 @@ def _perform_sync_operations(
 
 def _update_users(states: StateGenerator):
     """Update the users to store the scim ids"""
-    updates = []
-
-    for state in states:
-        user = state.user
-        user.scim_id = str(user.id)  # normally done in User.save()
-        user.scim_external_id = state.external_id
-        user.global_id = state.external_id
-        updates.append(user)
-
-    User.objects.bulk_update(updates, ["scim_id", "scim_external_id"])
+    for batch in chunked(states, settings.MITOL_SCIM_KEYCLOAK_BULK_OPERATIONS_COUNT):
+        updates = []
+        for state in batch:
+            user = state.user
+            user.scim_id = str(user.id)  # normally done in User.save()
+            user.scim_external_id = state.external_id
+            user.global_id = state.external_id
+            updates.append(user)
+
+        User.objects.bulk_update(updates, ["global_id", "scim_id", "scim_external_id"])

tests/scim/test_api.py

@@ -230,6 +230,7 @@ def _callback(request):
 def test_sync_users_to_scim_remote(users: Users):
     for user in users.users:
         assert user.scim_external_id is None
+        assert user.global_id == ""
 
     api.sync_users_to_scim_remote(users.users)
 
@@ -240,3 +241,4 @@ def test_sync_users_to_scim_remote(users: Users):
             assert user.scim_external_id is None
         else:
             assert user.scim_external_id == users.external_ids_by_user_id[user.id]
+            assert user.global_id == users.external_ids_by_user_id[user.id]