Skip to content

Commit 21cb4a3

Browse files
committed
CI: Remove faulthandler fallback requirement
faulthandler is a stdlib module in Python 3.3+. For a long time a PyPI package of the same name was available for earlier Python releases. That package has since been removed from PyPI, and the source respoitory archived. So we should not rely on it. fixes #983 refs #970
1 parent 1871f2a commit 21cb4a3

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

docs/ansible_detailed.rst

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1248,18 +1248,17 @@ with ``-vvv``.
12481248

12491249
However, certain controller hangs may render ``MITOGEN_DUMP_THREAD_STACKS``
12501250
ineffective, or occur too infrequently for interactive reproduction. In these
1251-
cases `faulthandler <https://faulthandler.readthedocs.io/>`_ may be used:
1251+
cases :py:mod:`faulthandler` may be used with Python >= 3.3:
12521252

1253-
1. For Python 2, ``pip install faulthandler``. This is unnecessary on Python 3.
1254-
2. Once the hang occurs, observe the process tree using ``pstree`` or ``ps
1253+
1. Once the hang occurs, observe the process tree using ``pstree`` or ``ps
12551254
--forest``.
1256-
3. The most likely process to be hung is the connection multiplexer, which can
1255+
2. The most likely process to be hung is the connection multiplexer, which can
12571256
easily be identified as the parent of all SSH client processes.
1258-
4. Send ``kill -SEGV <pid>`` to the multiplexer PID, causing it to print all
1257+
3. Send ``kill -SEGV <pid>`` to the multiplexer PID, causing it to print all
12591258
thread stacks.
1260-
5. `File a bug <https://github.com/dw/mitogen/issues/new/>`_ including a copy
1261-
of the stacks, along with a description of the last task executing prior to
1262-
the hang.
1259+
4. `File a bug <https://github.com/mitogen-hq/mitogen/issues/new/>`_
1260+
including a copy of the stacks and a description of the last task executing
1261+
before the hang
12631262

12641263
It is possible the hang occurred in a process on a target. If ``strace`` is
12651264
available, look for the host name not listed in Ansible output as reporting a

docs/changelog.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ v0.3.4.dev0
2727
was made to enqueue a message with a Broker that has already exitted`. However it may result in
2828
resource leaks.
2929
* :gh:issue:`659` Removed :mod:`mitogen.compat.simplejson`, not needed with Python 2.7+, contained Python 3.x syntax errors
30+
* :gh:issue:`983` CI: Removed PyPI faulthandler requirement from tests
3031

3132
v0.3.3 (2022-06-03)
3233
-------------------

tests/requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ psutil==5.4.8
22
coverage==5.5; python_version < '3.7'
33
coverage==6.4.4; python_version >= '3.7'
44
Django==1.6.11 # Last version supporting 2.6.
5-
faulthandler==3.2; python_version < '3.3'
65
mock==2.0.0
76
pytz==2018.5
87
cffi==1.14.3 # Random pin to try and fix pyparser==2.18 not having effect

0 commit comments

Comments
 (0)