Merge remote-tracking branch 'origin/dmw'

* origin/dmw:
  issue #613: must await 'exit' and 'disconnect' in wait=False test
  Import LGTM config to disable some stuff
  Fix up another handful of LGTM errors.
  tests: work around AnsibleModule.run_command() race.
  docs: mention another __main__ safeguard
  docs: tweaks
  formatting error
  docs: make Sphinx install soft fail on Python 2.
  issue #598: allow disabling preempt in terraform
  issue #598: update Changelog.

Author: dw

ansible_mitogen/loaders.py

@@ -32,6 +32,15 @@
 
 from __future__ import absolute_import
 
+__all__ = [
+    'action_loader',
+    'connection_loader',
+    'module_loader',
+    'module_utils_loader',
+    'shell_loader',
+    'strategy_loader',
+]
+
 try:
     from ansible.plugins.loader import action_loader
     from ansible.plugins.loader import connection_loader

ansible_mitogen/process.py

@@ -32,7 +32,6 @@
 import multiprocessing
 import os
 import resource
-import signal
 import socket
 import sys
 

ansible_mitogen/runner.py

@@ -37,7 +37,6 @@
 """
 
 import atexit
-import codecs
 import imp
 import os
 import re

docs/ansible_detailed.rst

@@ -82,8 +82,7 @@ Installation
     <form action="https://networkgenomics.com/save-email/" method="post" id="emailform">
         <input type=hidden name="list_name" value="mitogen-announce">
 
-        Releases occur frequently and often include important fixes. Subscribe
-        to the mitogen-announce list to stay updated.
+        Get notified of new releases and important fixes.
 
         <p>
         <input type="email" placeholder="E-mail Address" name="email" style="font-size: 105%;">

docs/changelog.rst

@@ -72,15 +72,21 @@ Mitogen for Ansible
   detected, to work around a broken heuristic in popular SELinux policies that
   prevents inheriting ``AF_UNIX`` sockets across privilege domains.
 
-* `#467 <https://github.com/dw/mitogen/issues/467>`_: an incompatibility
+* `#467 <httpe://github.com/dw/mitogen/issues/467>`_: an incompatibility
   running Mitogen under Molecule was resolved.
 
-* `#547 <https://github.com/dw/mitogen/issues/547>`_: fix a serious deadlock
-  possible during initialization of any task executed by forking, such as
-  ``async`` tasks, tasks using custom :mod:`ansible.module_utils`,
+* `#547 <https://github.com/dw/mitogen/issues/547>`_,
+  `#598 <https://github.com/dw/mitogen/issues/598>`_: fix a serious deadlock
+  possible while initializing the service pool of any child, such as during
+  connection, ``async`` tasks, tasks using custom :mod:`module_utils`,
   ``mitogen_task_isolation: fork`` modules, and those present on an internal
   blacklist of misbehaving modules.
 
+  This deadlock is relatively easy hit, has been present since 0.2.0, and is
+  likely to have impacted many users. For new connections it could manifest as
+  a *Connection timed out* error, for forked tasks it could manifest as a
+  timeout or an apparent hang.
+
 * `#549 <https://github.com/dw/mitogen/issues/549>`_: the open file descriptor
   limit for the Ansible process is increased to the available hard limit. It is
   common for distributions to ship with a much higher hard limit than their
@@ -114,7 +120,8 @@ Mitogen for Ansible
   is more accurately inferred for `meta: reset_connection`, the `synchronize`
   module, and for any action plug-ins that establish additional connections.
 
-* `#605 <https://github.com/dw/mitogen/issues/605>`_: fix a deadlock managing a
+* `#598 <https://github.com/dw/mitogen/issues/598>`_,
+  `#605 <https://github.com/dw/mitogen/issues/605>`_: fix a deadlock managing a
   shared counter used for load balancing.
 
 * `#615 <https://github.com/dw/mitogen/issues/615>`_: streaming file transfer
@@ -224,6 +231,7 @@ bug reports, testing, features and fixes in this release contributed by
 `Stefane Fermigier <https://github.com/sfermigier>`_,
 `Szabó Dániel Ernő <https://github.com/r3ap3rpy>`_,
 `Ulrich Schreiner <https://github.com/ulrichSchreiner>`_,
+`yen <https://github.com/antigenius0910>`_,
 `Yuki Nishida <https://github.com/yuki-nishida-exa>`_,
 `@alexhexabeam <https://github.com/alexhexabeam>`_,
 `@DavidVentura <https://github.com/DavidVentura>`_,

docs/howitworks.rst

@@ -673,8 +673,12 @@ code occurring after the first conditional that looks like a standard
     if __name__ == '__main__':
         run_some_code()
 
-This is a hack, but it's the least annoying hack I've found for the problem
-yet.
+To further avoid accidental execution, Mitogen will refuse to serve
+:mod:`__main__` to children if no execution guard is found, as it is common
+that no guard is present during early script prototyping.
+
+These are hacks, but they are the safest and least annoying found to solve the
+problem.
 
 
 Avoiding Negative Imports

docs/requirements.txt

@@ -1,3 +1,3 @@
-Sphinx==2.1.2
-sphinxcontrib-programoutput==0.14
-alabaster==0.7.10
+Sphinx==2.1.2; python_version > '3.0'
+sphinxcontrib-programoutput==0.14; python_version > '3.0'
+alabaster==0.7.10; python_version > '3.0'

examples/mitogen-fuse.py

@@ -245,7 +245,7 @@ def main(router):
     if sys.platform == 'darwin':
         kwargs['volname'] = '%s (Mitogen)' % (sys.argv[1],)
 
-    f = fuse.FUSE(
+    fuse.FUSE(
         operations=Operations(sys.argv[1]),
         mountpoint=sys.argv[2],
         foreground=True,