ansible_mitogen: De-duplicate sys.path manipulations by Ansible plugins

moreati · moreati · commit 6145508312d9 · 2025-10-29T13:14:08.000Z
diff --git a/ansible_mitogen/plugins/connection/__init__.py b/ansible_mitogen/plugins/connection/__init__.py
@@ -0,0 +1,11 @@
+# SPDX-FileCopyrightText: 2025 Mitogen authors <https://github.com/mitogen-hq>
+# SPDX-License-Identifier: BSD-3-Clause
+# !mitogen: minify_safe
+
+import os
+import sys
+
+try:
+    import ansible_mitogen
+except ImportError:
+    sys.path.insert(0, os.path.abspath(os.path.join(__file__, '../../../..')))
diff --git a/ansible_mitogen/plugins/connection/mitogen_buildah.py b/ansible_mitogen/plugins/connection/mitogen_buildah.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_doas.py b/ansible_mitogen/plugins/connection/mitogen_doas.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen.connection
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_docker.py b/ansible_mitogen/plugins/connection/mitogen_docker.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_jail.py b/ansible_mitogen/plugins/connection/mitogen_jail.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_kubectl.py b/ansible_mitogen/plugins/connection/mitogen_kubectl.py
@@ -30,18 +30,8 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
 import ansible.errors
 
-try:
-    import ansible_mitogen
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 import ansible_mitogen.loaders
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_local.py b/ansible_mitogen/plugins/connection/mitogen_local.py
@@ -29,15 +29,7 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen.connection
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
+import os
 
 import ansible_mitogen.connection
 import ansible_mitogen.process
diff --git a/ansible_mitogen/plugins/connection/mitogen_lxc.py b/ansible_mitogen/plugins/connection/mitogen_lxc.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_lxd.py b/ansible_mitogen/plugins/connection/mitogen_lxd.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_machinectl.py b/ansible_mitogen/plugins/connection/mitogen_machinectl.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen.connection
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_podman.py b/ansible_mitogen/plugins/connection/mitogen_podman.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_setns.py b/ansible_mitogen/plugins/connection/mitogen_setns.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen.connection
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_ssh.py b/ansible_mitogen/plugins/connection/mitogen_ssh.py
@@ -29,9 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
 from ansible.plugins.connection.ssh import (
     DOCUMENTATION as _ansible_ssh_DOCUMENTATION,
 )
@@ -47,12 +44,6 @@
     options:
 """ + _ansible_ssh_DOCUMENTATION.partition('options:\n')[2]
 
-try:
-    import ansible_mitogen
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
 
 import ansible_mitogen.connection
 import ansible_mitogen.loaders
diff --git a/ansible_mitogen/plugins/connection/mitogen_su.py b/ansible_mitogen/plugins/connection/mitogen_su.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen.connection
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/connection/mitogen_sudo.py b/ansible_mitogen/plugins/connection/mitogen_sudo.py
@@ -29,16 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
-
-try:
-    import ansible_mitogen.connection
-except ImportError:
-    base_dir = os.path.dirname(__file__)
-    sys.path.insert(0, os.path.abspath(os.path.join(base_dir, '../../..')))
-    del base_dir
-
 import ansible_mitogen.connection
 
 
diff --git a/ansible_mitogen/plugins/strategy/__init__.py b/ansible_mitogen/plugins/strategy/__init__.py
@@ -0,0 +1,11 @@
+# SPDX-FileCopyrightText: 2025 Mitogen authors <https://github.com/mitogen-hq>
+# SPDX-License-Identifier: BSD-3-Clause
+# !mitogen: minify_safe
+
+import os
+import sys
+
+try:
+    import ansible_mitogen
+except ImportError:
+    sys.path.insert(0, os.path.abspath(os.path.join(__file__, '../../../..')))
diff --git a/ansible_mitogen/plugins/strategy/mitogen.py b/ansible_mitogen/plugins/strategy/mitogen.py
@@ -29,8 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
 
 #
 # This is not the real Strategy implementation module, it simply exists as a
@@ -47,13 +45,6 @@
 # debuggers and isinstance() work predictably.
 #
 
-BASE_DIR = os.path.abspath(
-    os.path.join(os.path.dirname(__file__), '../../..')
-)
-
-if BASE_DIR not in sys.path:
-    sys.path.insert(0, BASE_DIR)
-
 import ansible_mitogen.strategy
 import ansible.plugins.strategy.linear
 
diff --git a/ansible_mitogen/plugins/strategy/mitogen_free.py b/ansible_mitogen/plugins/strategy/mitogen_free.py
@@ -29,8 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
 
 #
 # This is not the real Strategy implementation module, it simply exists as a
@@ -47,13 +45,6 @@
 # debuggers and isinstance() work predictably.
 #
 
-BASE_DIR = os.path.abspath(
-    os.path.join(os.path.dirname(__file__), '../../..')
-)
-
-if BASE_DIR not in sys.path:
-    sys.path.insert(0, BASE_DIR)
-
 import ansible_mitogen.loaders
 import ansible_mitogen.strategy
 
diff --git a/ansible_mitogen/plugins/strategy/mitogen_host_pinned.py b/ansible_mitogen/plugins/strategy/mitogen_host_pinned.py
@@ -29,8 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
 
 #
 # This is not the real Strategy implementation module, it simply exists as a
@@ -47,13 +45,6 @@
 # debuggers and isinstance() work predictably.
 #
 
-BASE_DIR = os.path.abspath(
-    os.path.join(os.path.dirname(__file__), '../../..')
-)
-
-if BASE_DIR not in sys.path:
-    sys.path.insert(0, BASE_DIR)
-
 import ansible_mitogen.loaders
 import ansible_mitogen.strategy
 
diff --git a/ansible_mitogen/plugins/strategy/mitogen_linear.py b/ansible_mitogen/plugins/strategy/mitogen_linear.py
@@ -29,8 +29,6 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
-import os.path
-import sys
 
 #
 # This is not the real Strategy implementation module, it simply exists as a
@@ -47,13 +45,6 @@
 # debuggers and isinstance() work predictably.
 #
 
-BASE_DIR = os.path.abspath(
-    os.path.join(os.path.dirname(__file__), '../../..')
-)
-
-if BASE_DIR not in sys.path:
-    sys.path.insert(0, BASE_DIR)
-
 import ansible_mitogen.loaders
 import ansible_mitogen.strategy
 
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -22,6 +22,7 @@ In progress (unreleased)
 ------------------------
 
 * :gh:issue:`1266` Import cleanups
+* :gh:issue:`1266` :mod:`ansible_mitogen`: De-duplicate sys.path manipulations
 
 
 v0.3.29 (2025-09-18)
