Skip to content

Commit c6c8bfb

Browse files
committed
tests: Skip vanilla Ansible on Linux unpriviliged -> unprivileged become
CI containers lack the necessary `setfacl` command. This has not previously been noticed because no vanilla Ansible jobs were being run on Linux, only on macOS. refs #1118
1 parent 8b92e09 commit c6c8bfb

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

tests/ansible/integration/become/su_password.yml

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,22 @@
5353
vars:
5454
ansible_become_pass: user1_password
5555
when:
56-
# https://github.com/ansible/ansible/pull/70785
57-
- ansible_facts.distribution not in ["MacOSX"]
58-
or ansible_version.full is version("2.11", ">=", strict=True)
59-
or is_mitogen
56+
# CI containers lack `setfacl` for unpriv -> unpriv
57+
# https://github.com/mitogen-hq/mitogen/issues/1118
58+
- is_mitogen
59+
or (ansible_facts.distribution in ["MacOSX"]
60+
and ansible_version.full is version("2.11", ">=", strict=True))
6061

6162
- assert:
6263
that:
6364
- out.stdout == 'mitogen__user1'
6465
fail_msg: out={{out}}
6566
when:
66-
# https://github.com/ansible/ansible/pull/70785
67-
- ansible_facts.distribution not in ["MacOSX"]
68-
or ansible_version.full is version("2.11", ">=", strict=True)
69-
or is_mitogen
67+
# CI containers lack `setfacl` for unpriv -> unpriv
68+
# https://github.com/mitogen-hq/mitogen/issues/1118
69+
- is_mitogen
70+
or (ansible_facts.distribution in ["MacOSX"]
71+
and ansible_version.full is version("2.11", ">=", strict=True))
7072

7173
- name: Ensure password su without chdir succeeds
7274
shell: whoami
@@ -76,20 +78,22 @@
7678
vars:
7779
ansible_become_pass: user1_password
7880
when:
79-
# https://github.com/ansible/ansible/pull/70785
80-
- ansible_facts.distribution not in ["MacOSX"]
81-
or ansible_version.full is version("2.11", ">=", strict=True)
82-
or is_mitogen
81+
# CI containers lack `setfacl` for unpriv -> unpriv
82+
# https://github.com/mitogen-hq/mitogen/issues/1118
83+
- is_mitogen
84+
or (ansible_facts.distribution in ["MacOSX"]
85+
and ansible_version.full is version("2.11", ">=", strict=True))
8386

8487
- assert:
8588
that:
8689
- out.stdout == 'mitogen__user1'
8790
fail_msg: out={{out}}
8891
when:
89-
# https://github.com/ansible/ansible/pull/70785
90-
- ansible_facts.distribution not in ["MacOSX"]
91-
or ansible_version.full is version("2.11", ">=", strict=True)
92-
or is_mitogen
92+
# CI containers lack `setfacl` for unpriv -> unpriv
93+
# https://github.com/mitogen-hq/mitogen/issues/1118
94+
- is_mitogen
95+
or (ansible_facts.distribution in ["MacOSX"]
96+
and ansible_version.full is version("2.11", ">=", strict=True))
9397

9498
tags:
9599
- su

0 commit comments

Comments
 (0)