tests: Enable stricter error handling, fix resulting failures

Author: moreati

tests/ansible/ansible.cfg

@@ -1,4 +1,5 @@
 [defaults]
+any_errors_fatal = true
 inventory = hosts
 gathering = explicit
 strategy_plugins = ../../ansible_mitogen/plugins/strategy
@@ -35,6 +36,10 @@ timeout = 10
 # On Travis, paramiko check fails due to host key checking enabled.
 host_key_checking = False
 
+[inventory]
+any_unparsed_is_failed = true
+host_pattern_mismatch = error
+
 [callback_profile_tasks]
 task_output_limit = 10
 

tests/ansible/bench/file_transfer.yml

@@ -1,7 +1,6 @@
 
 - name: bench/file_transfer.yml
   hosts: test-targets
-  any_errors_fatal: true
   tasks:
 
   - name: Make 32MiB file

tests/ansible/bench/loop-100-copies.yml

@@ -1,6 +1,5 @@
 - name: bench/loop-100-copies.yml
   hosts: all
-  any_errors_fatal: true
   tasks:
 
   - name: Create file tree

tests/ansible/hosts/transport_config.hosts

@@ -22,9 +22,15 @@ tc-remote-addr-explicit-both ansible_ssh_host=a.b.c ansible_host=b.c.d
 # password()
 tc-password-unset
 tc-password-explicit-ssh  ansible_ssh_pass=ansi-ssh-pass
-tc-password-explicit-user ansible_password=ansi-pass
+tc-password-explicit-pass ansible_password=ansi-pass
 tc-password-explicit-both ansible_password=a.b.c ansible_ssh_pass=c.b.a
 
+# remote_user()
+tc-remote-user-unset  # defaults to C.DEFAULT_REMOTE_USER
+tc-remote-user-explicit-ssh  ansible_ssh_user=ansi-ssh-user
+tc-remote-user-explicit-user ansible_user=ansi-user
+tc-remote-user-explicit-both ansible_user=a.b.c ansible_ssh_user=c.b.a
+
 # become()
 tc-become-unset
 tc-become-set

tests/ansible/integration/action/copy.yml

@@ -2,7 +2,6 @@
 
 - name: integration/action/copy.yml
   hosts: test-targets
-  any_errors_fatal: true
   tasks:
     - copy:
         dest: /tmp/copy-tiny-file

tests/ansible/integration/action/fixup_perms2__copy.yml

@@ -5,7 +5,6 @@
 
 - name: integration/action/fixup_perms2__copy.yml
   hosts: test-targets
-  any_errors_fatal: true
   tasks:
     #
     # copy module (no mode).

tests/ansible/integration/action/low_level_execute_command.yml

@@ -2,7 +2,6 @@
 
 - name: integration/action/low_level_execute_command.yml
   hosts: test-targets
-  any_errors_fatal: true
   tasks:
 
     # "echo -en" to test we actually hit bash shell too.

tests/ansible/integration/action/make_tmp_path.yml

@@ -9,7 +9,6 @@
 
 - name: integration/action/make_tmp_path.yml
   hosts: test-targets
-  any_errors_fatal: true
   tasks:
     - meta: end_play
       when: not is_mitogen

tests/ansible/integration/action/make_tmp_path__double.yml

@@ -2,7 +2,7 @@
 # they succeed and are cleaned up correctly.
 
 - name: integration/action/make_tmp_path__double.yml
-  hosts: targets
+  hosts: test-targets
   tasks:
   - mitogen_action_script:
       script: |

tests/ansible/integration/action/remote_expand_user.yml

@@ -3,7 +3,6 @@
 
 - name: integration/action/remote_expand_user.yml
   hosts: test-targets
-  any_errors_fatal: true
   tasks:
     - name: "Find out root's homedir."
       # Runs first because it blats regular Ansible facts with junk, so