CI: Fix ci_lib and test_lib have_<cmd>() when <cmd> exits abnormally

moreati · moreati · commit dc7fae973b7e · 2025-08-20T23:44:13.000+01:00
We were not raising CalledProcessError when exit status != 0.
diff --git a/.ci/ci_lib.py b/.ci/ci_lib.py
@@ -58,6 +58,7 @@ def _have_cmd(args):
     try:
         subprocess.run(
             args, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,
+            check=True,
         )
     except OSError as exc:
         if exc.errno == errno.ENOENT:
diff --git a/tests/testlib.py b/tests/testlib.py
@@ -160,6 +160,7 @@ def _have_cmd(args):
     try:
         subprocess.run(
             args, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,
+            check=True,
         )
     except OSError as exc:
         if exc.errno == errno.ENOENT:

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ def _have_cmd(args):`
`58`	`58`	`try:`
`59`	`59`	`subprocess.run(`
`60`	`60`	`args, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,`
	`61`	`+ check=True,`
`61`	`62`	`)`
`62`	`63`	`except OSError as exc:`
`63`	`64`	`if exc.errno == errno.ENOENT:`
Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,7 @@ def _have_cmd(args):`
`160`	`160`	`try:`
`161`	`161`	`subprocess.run(`
`162`	`162`	`args, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,`
	`163`	`+ check=True,`
`163`	`164`	`)`
`164`	`165`	`except OSError as exc:`
`165`	`166`	`if exc.errno == errno.ENOENT:`