tests: Use meaningful play names

moreati · moreati · commit f070767dada0 · 2022-07-17T13:44:05.000+01:00
diff --git a/tests/ansible/bench/includes.yml b/tests/ansible/bench/includes.yml
@@ -1,4 +1,5 @@
-- hosts: test-targets
+- name: bench/includes.yml
+  hosts: test-targets
   tasks:
   - include_tasks: _includes.yml
     with_sequence: start=1 end=1000
diff --git a/tests/ansible/bench/loop-100-copies.yml b/tests/ansible/bench/loop-100-copies.yml
@@ -1,5 +1,5 @@
-
-- hosts: all
+- name: bench/loop-100-copies.yml
+  hosts: all
   any_errors_fatal: true
   tasks:
 
diff --git a/tests/ansible/bench/loop-100-items.yml b/tests/ansible/bench/loop-100-items.yml
@@ -4,7 +4,8 @@
 #
 # See also: loop-100-tasks.yml
 #
-- hosts: all
+- name: bench/loop-100-items.yml
+  hosts: all
   tasks:
     - command: hostname
       with_sequence: start=1 end="{{end|default(100)}}"
diff --git a/tests/ansible/bench/loop-100-tasks.yml b/tests/ansible/bench/loop-100-tasks.yml
@@ -8,7 +8,8 @@
 #
 # See also: loop-100-items.yml
 #
-- hosts: all
+- name: bench/loop-100-tasks.yml
+  hosts: all
   tasks:
     - command: hostname
     - command: hostname
diff --git a/tests/ansible/bench/loop-20-templates.yml b/tests/ansible/bench/loop-20-templates.yml
@@ -1,5 +1,5 @@
-
-- hosts: all
+- name: bench/loop-20-templates.yml
+  hosts: all
   tasks:
   - file:
       dest: /tmp/templates
diff --git a/tests/ansible/integration/action/make_tmp_path__double.yml b/tests/ansible/integration/action/make_tmp_path__double.yml
@@ -1,7 +1,8 @@
 # issue #554: double calls to make_tmp_path() fail with assertion error. Ensure
 # they succeed and are cleaned up correctly.
 
-- hosts: target
+- name: integration/action/make_tmp_path__double.yml
+  hosts: target
   tasks:
   - mitogen_action_script:
       script: |
diff --git a/tests/ansible/integration/connection/reset_become.yml b/tests/ansible/integration/connection/reset_become.yml
@@ -1,7 +1,8 @@
 # issue #633: Connection.reset() should ignore "become", and apply to the login
 # account.
 
-- hosts: test-targets
+- name: integration/connection/reset_become.yml
+  hosts: test-targets
   become: true
   gather_facts: false
   tasks:
diff --git a/tests/ansible/integration/connection_delegation/local_action.yml b/tests/ansible/integration/connection_delegation/local_action.yml
@@ -1,7 +1,7 @@
-
 # issue #251: local_action with mitogen_via= builds wrong stack.
 
-- hosts: cd-newuser-normal-normal
+- name: integration/connection_delegation/local_action.yml
+  hosts: cd-newuser-normal-normal
   tasks:
     - meta: end_play
       when: not is_mitogen
diff --git a/tests/ansible/integration/local/env_preserved.yml b/tests/ansible/integration/local/env_preserved.yml
@@ -1,8 +1,8 @@
-
 # Execution environment should be that of WorkerProcess --
 # https://github.com/dw/mitogen/issues/297
 
-- hosts: localhost
+- name: integration/local/env_preserved.yml
+  hosts: localhost
   connection: local
   tasks:
     - shell: "env | grep EVIL_VARS_PLUGIN"
diff --git a/tests/ansible/integration/process/unix_socket_cleanup.yml b/tests/ansible/integration/process/unix_socket_cleanup.yml
@@ -1,5 +1,5 @@
-
-- hosts: test-targets[0]
+- name: integration/process/unix_socket_cleanup.yml
+  hosts: test-targets[0]
   tasks:
   - mitogen_action_script:
       script: |
diff --git a/tests/ansible/integration/transport_config/become_method.yml b/tests/ansible/integration/transport_config/become_method.yml
@@ -2,7 +2,7 @@
 
 
 # No become-method set.
-- name: integration/transport_config/become-method.yml
+- name: integration/transport_config/become_method.yml
   hosts: tc-become-method-unset
   become: true
   tasks:
diff --git a/tests/ansible/integration/transport_config/become_pass.yml b/tests/ansible/integration/transport_config/become_pass.yml
@@ -2,7 +2,7 @@
 
 
 # No become-pass set, defaults to "root"
-- name: integration/transport_config/become-pass.yml
+- name: integration/transport_config/become_pass.yml
   hosts: tc-become-pass-unset
   become: true
   tasks:
diff --git a/tests/ansible/integration/transport_config/become_user.yml b/tests/ansible/integration/transport_config/become_user.yml
@@ -2,7 +2,7 @@
 
 
 # No become-user set, defaults to "root"
-- name: integration/transport_config/become-user.yml
+- name: integration/transport_config/become_user.yml
   hosts: tc-become-user-unset
   become: true
   tasks:
diff --git a/tests/ansible/integration/transport_config/transport__smart.yml b/tests/ansible/integration/transport_config/transport__smart.yml
@@ -4,7 +4,7 @@
 
 # When no ansible_connection= is set, transport comes via ansible.cfg ("smart"
 # is parsed away to either paramiko or ssh).
-- name: integration/transport_config/transport.yml
+- name: integration/transport_config/transport__smart.yml
   hosts: tc-transport-smart
   tasks:
   - include: ../_mitogen_only.yml
diff --git a/tests/ansible/regression/issue_590__sys_modules_crap.yml b/tests/ansible/regression/issue_590__sys_modules_crap.yml
@@ -1,5 +1,5 @@
-
-- hosts: test-targets
+- name: regression/iss590__sys_modules_crap.yml
+  hosts: test-targets
   tasks:
   - meta: end_play
     when:
diff --git a/tests/ansible/regression/issue_591__setuptools_cwd_crash.yml b/tests/ansible/regression/issue_591__setuptools_cwd_crash.yml
@@ -3,7 +3,8 @@
 # to call getcwd() before AnsibleModule has had a chance to clean up the
 # process environment.
 
-- hosts: test-targets
+- name: regression/issue_591__setuptools_cwd_crash.yml
+  hosts: test-targets
   tasks:
   - meta: end_play
     when: not is_mitogen
diff --git a/tests/ansible/regression/issue_615__streaming_transfer.yml b/tests/ansible/regression/issue_615__streaming_transfer.yml
@@ -1,6 +1,7 @@
 # issue #615: 'fetch' with become: was internally using slurp.
 
-- hosts: test-targets
+- name: regression/issue_615_streaming_transfer.yml
+  hosts: test-targets
   any_errors_fatal: True
   gather_facts: no
   # Without Mitogen this causes Ansible to use the slurp module, which is *slow*
diff --git a/tests/ansible/regression/issue_655__wait_for_connection_error.yml b/tests/ansible/regression/issue_655__wait_for_connection_error.yml
@@ -5,7 +5,8 @@
 # TODO: do we want to install docker a different way to be able to do this for other tests too
 ---
 # this should only run on our Mac hosts
-- hosts: target
+- name: regression/issue_655_wait_for_connection_error.yml
+  hosts: target
   any_errors_fatal: True
   gather_facts: yes
   become: no
diff --git a/tests/ansible/soak/file_service.yml b/tests/ansible/soak/file_service.yml
@@ -1,4 +1,5 @@
-- hosts: all
+- name: soak/file_service.yml
+  hosts: all
   tasks:
   - set_fact:
       content: "{% for x in range(126977) %}x{% endfor %}"

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,8 @@`
`4`	`4`	`#`
`5`	`5`	`# See also: loop-100-tasks.yml`
`6`	`6`	`#`
`7`		`-- hosts: all`
	`7`	`+- name: bench/loop-100-items.yml`
	`8`	`+ hosts: all`
`8`	`9`	`tasks:`
`9`	`10`	`- command: hostname`
`10`	`11`	`with_sequence: start=1 end="{{end\|default(100)}}"`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,8 @@`
`8`	`8`	`#`
`9`	`9`	`# See also: loop-100-items.yml`
`10`	`10`	`#`
`11`		`-- hosts: all`
	`11`	`+- name: bench/loop-100-tasks.yml`
	`12`	`+ hosts: all`
`12`	`13`	`tasks:`
`13`	`14`	`- command: hostname`
`14`	`15`	`- command: hostname`