hide error details from serialization when debug is off (#109)

Author: cnizzardini

plugins/exception-render/src/MixerApiExceptionRenderer.php

@@ -75,8 +75,8 @@ public function render(): ResponseInterface
             'exception' => (new ReflectionClass($exception))->getShortName(),
             'message' => $message,
             'url' => h($url),
-            'error' => $exception,
             'code' => $code,
+            'error' => $exception,
         ];
 
         if ($this->error instanceof ValidationException) {
@@ -128,6 +128,8 @@ public function getError(): Throwable
     private function debugViewVars($exception, array $viewVars): array
     {
         if (!Configure::read('debug')) {
+            unset($viewVars['error']);
+
             return $viewVars;
         }
 

plugins/exception-render/tests/TestCase/ControllerTest.php

@@ -60,6 +60,9 @@ public function test_validation_exception(): void
         $message = reset($violation->messages);
         $this->assertEquals('_empty', $message->rule);
         $this->assertEquals('This field cannot be left empty', $message->message);
+
+        $this->assertTrue(isset($object->trace));
+        $this->assertTrue(isset($object->error));
     }
 
     public function test_validation_exception_with_cakephp_debug_off(): void
@@ -77,5 +80,6 @@ public function test_validation_exception_with_cakephp_debug_off(): void
         $object = json_decode($body);
 
         $this->assertFalse(isset($object->trace));
+        $this->assertFalse(isset($object->error));
     }
 }

plugins/exception-render/tests/test_app/src/Controller/ActorsController.php

@@ -3,6 +3,8 @@
 
 namespace MixerApi\ExceptionRender\Test\App\Controller;
 
+use Cake\Http\Exception\InternalErrorException;
+
 class ActorsController extends AppController
 {
     /**
@@ -106,4 +108,9 @@ public function delete($id = null)
         }
         throw new \Exception("Record not deleted");
     }
+
+    public function exception()
+    {
+        throw new InternalErrorException('testing');
+    }
 }