Skip to content

Commit e08ef1a

Browse files
ankitkhushwahagregkh
authored andcommitted
selftests/user_events: fix type cast for write_index packed member in perf_test
commit 216158f upstream. Accessing 'reg.write_index' directly triggers a -Waddress-of-packed-member warning due to potential unaligned pointer access: perf_test.c:239:38: warning: taking address of packed member 'write_index' of class or structure 'user_reg' may result in an unaligned pointer value [-Waddress-of-packed-member] 239 | ASSERT_NE(-1, write(self->data_fd, &reg.write_index, | ^~~~~~~~~~~~~~~ Since write(2) works with any alignment. Casting '&reg.write_index' explicitly to 'void *' to suppress this warning. Link: https://lkml.kernel.org/r/[email protected] Fixes: 42187bd ("selftests/user_events: Add perf self-test for empty arguments events") Signed-off-by: Ankit Khushwaha <[email protected]> Cc: Beau Belgrave <[email protected]> Cc: "Masami Hiramatsu (Google)" <[email protected]> Cc: Steven Rostedt <[email protected]> Cc: sunliming <[email protected]> Cc: Wei Yang <[email protected]> Cc: Shuah Khan <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent efebcf7 commit e08ef1a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/testing/selftests/user_events/perf_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ TEST_F(user, perf_empty_events) {
236236
ASSERT_EQ(1 << reg.enable_bit, self->check);
237237

238238
/* Ensure write shows up at correct offset */
239-
ASSERT_NE(-1, write(self->data_fd, &reg.write_index,
239+
ASSERT_NE(-1, write(self->data_fd, (void *)&reg.write_index,
240240
sizeof(reg.write_index)));
241241
val = (void *)(((char *)perf_page) + perf_page->data_offset);
242242
ASSERT_EQ(PERF_RECORD_SAMPLE, *val);

0 commit comments

Comments
 (0)