Skip to content

Commit a4d5ca3

Browse files
committed
update site webpack config for webpack4, change win dl link
1 parent 5c75060 commit a4d5ca3

File tree

4 files changed

+39
-13
lines changed

4 files changed

+39
-13
lines changed

package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
},
2020
"electronWebpack": {
2121
"title": true,
22-
"whiteListedModules": [ "react-redux" ],
22+
"whiteListedModules": [
23+
"react-redux"
24+
],
2325
"renderer": {
2426
"webpackConfig": "./webpack/renderer.js"
2527
}
@@ -85,6 +87,7 @@
8587
"eslint-plugin-import": "^2.18.2",
8688
"eslint-plugin-jsx-a11y": "^6.2.3",
8789
"eslint-plugin-react": "^7.16.0",
90+
"extract-text-webpack-plugin": "3.0.2",
8891
"node-sass": "^4.13.0",
8992
"prettier": "^1.13.5",
9093
"redux-logger": "^3.0.6",

site/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ fetch(REL_URL)
2727
const { name, assets } = lastVersion
2828

2929
const linuxName = `mjml-app-${name}-linux-x64.tar.gz`
30-
const winName = `mjml-app-win-x64_${name}.exe`
30+
const winName = `mjml-app-${name}-win.exe`
3131
const osxName = `mjml-app-${name}-mac.dmg`
3232

3333
let linuxUrl, winUrl, osxUrl

webpack/site.js

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,28 +11,34 @@ module.exports = {
1111
filename: 'bundle-[hash].js',
1212
},
1313
module: {
14-
loaders: [
14+
rules: [
1515
{
1616
test: /\.jsx?$/,
17-
loaders: ['babel-loader'],
17+
use: [{ loader: 'babel-loader' }],
1818
exclude: /node_modules/,
1919
},
2020
{
2121
test: /\.svg(\?v=\d+\.\d+\.\d+)?$/,
22-
loader: 'url-loader?limit=10000&mimetype=image/svg+xml',
22+
use: { loader: 'url-loader?limit=10000&mimetype=image/svg+xml' },
2323
},
2424
{ test: /\.mp4$/, loader: 'file-loader' },
2525
isProd
2626
? {
2727
test: /\.scss$/,
28-
loader: ExtractTextPlugin.extract({
29-
fallback: 'style-loader',
30-
use: 'css-loader!sass-loader',
31-
}),
28+
use: {
29+
loader: ExtractTextPlugin.extract({
30+
fallback: 'style-loader',
31+
use: 'css-loader!sass-loader',
32+
}),
33+
},
3234
}
3335
: {
3436
test: /\.scss$/,
35-
loaders: ['style-loader', 'css-loader', 'sass-loader'],
37+
use: [
38+
{ loader: 'style-loader' },
39+
{ loader: 'css-loader' },
40+
{ loader: 'sass-loader' },
41+
],
3642
},
3743
],
3844
},

yarn.lock

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,7 @@ ajv-keywords@^3.1.0, ajv-keywords@^3.4.1:
11121112
resolved "https://registry.yarnpkg.com/ajv-keywords/-/ajv-keywords-3.4.1.tgz#ef916e271c64ac12171fd8384eaae6b2345854da"
11131113
integrity sha512-RO1ibKvd27e6FEShVFfPALuHI3WjSVNeK5FIsmme/LYRNxjKuNj+Dt7bucLa6NdSv3JcVTyMlm9kGR84z1XpaQ==
11141114

1115-
ajv@^5.1.0:
1115+
ajv@^5.0.0, ajv@^5.1.0:
11161116
version "5.5.2"
11171117
resolved "https://registry.yarnpkg.com/ajv/-/ajv-5.5.2.tgz#73b5eeca3fab653e3d3f9422b341ad42205dc965"
11181118
dependencies:
@@ -1427,7 +1427,7 @@ async@^2.0.0:
14271427
dependencies:
14281428
lodash "^4.14.0"
14291429

1430-
async@^2.6.2:
1430+
async@^2.4.1, async@^2.6.2:
14311431
version "2.6.3"
14321432
resolved "https://registry.yarnpkg.com/async/-/async-2.6.3.tgz#d72625e2344a3656e3a3ad4fa749fa83299d82ff"
14331433
integrity sha512-zflvls11DCy+dQWzTW2dzuilv8Z5X/pjfmZOWba6TNIVDm+2UDaJmXSOXlasHKfNBs8oo3M0aT50fDEWfKZjXg==
@@ -3904,6 +3904,16 @@ extglob@^2.0.4:
39043904
snapdragon "^0.8.1"
39053905
to-regex "^3.0.1"
39063906

3907+
extract-text-webpack-plugin@3.0.2:
3908+
version "3.0.2"
3909+
resolved "https://registry.yarnpkg.com/extract-text-webpack-plugin/-/extract-text-webpack-plugin-3.0.2.tgz#5f043eaa02f9750a9258b78c0a6e0dc1408fb2f7"
3910+
integrity sha512-bt/LZ4m5Rqt/Crl2HiKuAl/oqg0psx1tsTLkvWbJen1CtD+fftkZhMaQ9HOtY2gWsl2Wq+sABmMVi9z3DhKWQQ==
3911+
dependencies:
3912+
async "^2.4.1"
3913+
loader-utils "^1.1.0"
3914+
schema-utils "^0.3.0"
3915+
webpack-sources "^1.0.1"
3916+
39073917
extract-zip@^1.0.3:
39083918
version "1.6.6"
39093919
resolved "https://registry.yarnpkg.com/extract-zip/-/extract-zip-1.6.6.tgz#1290ede8d20d0872b429fd3f351ca128ec5ef85c"
@@ -8712,6 +8722,13 @@ scheduler@^0.17.0:
87128722
loose-envify "^1.1.0"
87138723
object-assign "^4.1.1"
87148724

8725+
schema-utils@^0.3.0:
8726+
version "0.3.0"
8727+
resolved "https://registry.yarnpkg.com/schema-utils/-/schema-utils-0.3.0.tgz#f5877222ce3e931edae039f17eb3716e7137f8cf"
8728+
integrity sha1-9YdyIs4+kx7a4DnxfrNxbnE3+M8=
8729+
dependencies:
8730+
ajv "^5.0.0"
8731+
87158732
schema-utils@^0.4.3:
87168733
version "0.4.5"
87178734
resolved "https://registry.yarnpkg.com/schema-utils/-/schema-utils-0.4.5.tgz#21836f0608aac17b78f9e3e24daff14a5ca13a3e"
@@ -10164,7 +10181,7 @@ webpack-merge@^4.2.1:
1016410181
dependencies:
1016510182
lodash "^4.17.15"
1016610183

10167-
webpack-sources@1.0.1, webpack-sources@^1.1.0, webpack-sources@^1.4.0, webpack-sources@^1.4.1:
10184+
webpack-sources@1.0.1, webpack-sources@^1.0.1, webpack-sources@^1.1.0, webpack-sources@^1.4.0, webpack-sources@^1.4.1:
1016810185
version "1.0.1"
1016910186
resolved "https://registry.yarnpkg.com/webpack-sources/-/webpack-sources-1.0.1.tgz#c7356436a4d13123be2e2426a05d1dad9cbe65cf"
1017010187
dependencies:

0 commit comments

Comments
 (0)