shortPress action to toggle nightmode

[winxi01]

Hi , I would like the shortPress action of a button of type hold to (permanently) toggle Night mode.
I'm not sure if this is possible at the moment, because the shortPress feature in combination with an action of type nightmode would activate the Night mode only for the amount of time which is specified by actionTime. Is there another way to configure this?

[mjrgh]

You should be able to do it just like that. The "nightmode" button action is actually a toggler - each time the action is invoked, it toggles the current night mode state. So the nightmode update will persist even after the short press pulse ends.

[winxi01]

I've tried this, but it currently works as described above. In fact, also with a regular button of type "push", Night mode is only activated as long as the button is pressed. When releasing the button, Night mode will be deactivated again. One has to use a button of type "toggle" to permanently toggle the Night mode.

[mjrgh]

Ah, I see you're right - I documented it wrong. I guess I was only thinking of the toggle-button use case when implementing it. I'll look at adding an option to make the action a toggle for this case.

[winxi01]

Thank you!
To be honest, I can only think of use cases where somebody wants to toggle the Night mode but not where somebody wants to activate it only for a short time. Maybe it would be simpler to make the action a toggler by default as you have described above and as it is already documented.
On the other hand, I think that for both the long press and the short press parts of hold buttons there would be other button types useful. I could think of defining "subtypes" for a hold button. For the short press part this would be "toggle" and "pulse" (actually, it partly resembles a "pulse" button at the moment") and for the long press part it would be "push", "pulse", "toggle", and "shift" (at the moment it resembles "push"). But this would add quite some complexity I think...

[mjrgh]

The v1.0.0 release adds a toggle option for the 'nightmode' action.

[winxi01]

Works great, thank you for the additional nightmode action modes!

[ErnieBall]

The v1.0.0 release adds a toggle option for the 'nightmode' action.

I'm struggling to understand how to set this option.
My Nightmode button is currently set up as a longpress action:

         // button #5 Extra Ball / Nightmode
         {
             type: "hold",
	     holdTime: 1500,
	     shortPress: { action: { type: "key", key: "2" }, actionTime: 25,},
             source: { type: "gpio", gp: 5 },        
             action: { type: "nightmode"},  
         },

The general long press / short press setup for this button is working, but nightmode is only active as long as i keep holding the button.
I want the long press action to toggle nightmode on and off.

As always, any help is much appreciated!

[mjrgh]

In the action, you just need to add mode: "toggle". The default mode is still "follow". which means that the Night Mode state follows (matches) the button-press state, which is why it only stays on as long as you're pushing the button. Changing the mode to "toggle" makes Night Mode flip between ON and OFF each time the button is pressed, so it's the one to use for a time-based button like this. So just change your action section to:

action: { type: "nightmode", mode: "toggle" },