-
Notifications
You must be signed in to change notification settings - Fork 30
Description
Hello, We've been running R CMD check for packages for our package registry manager PRISM (Home | PRISM) and noticed that ggdist is failing during tests with 34 visual snapshot failures. We found the root cause to be newer versions of ggplot2 and svglite, 28 failures are resolved by downgrading to ggplot2 3.5.2, and the remaining 6 are resolved by downgrading to svglite 2.1.3.
checking tests Running testthat.R
Running the tests in tests/testthat.R failed.
Last 13 lines of output:
1. vdiffr::expect_doppelganger(...) at test.stat_sample_slabinterval.R:56:3
2. base::withCallingHandlers(...)
3. testthat::expect_snapshot_file(...)
Snapshots
To review and process snapshots locally:
* Locate check directory.
* Copy 'tests/testthat/_snaps' to local package.
* Run `testthat::snapshot_accept()` to accept all changes.
* Run `testthat::snapshot_review()` to review all changes.
[ FAIL 34 | WARN 6 | SKIP 0 | PASS 979 ]
Error:
! Test failures.
Execution halted
All 34 failures are vdiffr::expect_doppelganger visual snapshot mismatches.
ggplot2 related failures (28): test.curve_interval.R, test.geom_interval.R, test.geom_lineribbon.R, test.geom_pointinterval.R, test.scale_.R, test.scale_colour_ramp.R, test.stat_dist_slabinterval.R, test.stat_eye.R
svglite related failures (6): test.geom_blur_dots.R, test.stat_dist_slabinterval.R, test.stat_sample_slabinterval.R
We've attached a zip of the visual diffs for reference:
Happy to provide any more details or clarity if needed.