Fix linter issues

ntnn · ntnn · commit 2792a7e5b0a4 · 2026-03-02T22:46:17.000+01:00
Signed-off-by: Nelo-T. Wallus &lt;red.brush9525@fastmail.com&gt;
Signed-off-by: Nelo-T. Wallus &lt;n.wallus@sap.com&gt;
diff --git a/cmd/kcp-front-proxy/options/options.go b/cmd/kcp-front-proxy/options/options.go
@@ -58,9 +58,5 @@ func (o *Options) Complete() error {
 }
 
 func (o *Options) Validate() []error {
-	var errs []error
-
-	errs = append(errs, o.Proxy.Validate()...)
-
-	return errs
+	return o.Proxy.Validate()
 }
diff --git a/pkg/authentication/index.go b/pkg/authentication/index.go
@@ -76,7 +76,7 @@ func (c *state) UpsertWorkspaceType(shard string, wst *tenancyv1alpha1.Workspace
 
 	clusterName := logicalcluster.From(wst)
 
-	authenticators := []authenticatorKey{}
+	authenticators := make([]authenticatorKey, 0, len(wst.Spec.AuthenticationConfigurations))
 	for _, authConfig := range wst.Spec.AuthenticationConfigurations {
 		authenticators = append(authenticators, authenticatorKey{
 			cluster: clusterName,
diff --git a/pkg/authorization/workspace_content_authorizer_test.go b/pkg/authorization/workspace_content_authorizer_test.go
@@ -329,13 +329,14 @@ func TestWorkspaceContentAuthorizer(t *testing.T) {
 			globalKubeClient := kcpfakeclient.NewSimpleClientset() // TODO(sttts): add some global fixtures
 			local := kcpkubernetesinformers.NewSharedInformerFactory(localKubeClient, controller.NoResyncPeriodFunc())
 			global := kcpkubernetesinformers.NewSharedInformerFactory(globalKubeClient, controller.NoResyncPeriodFunc())
-			var syncs []cache.InformerSynced
-			for _, inf := range []cache.SharedIndexInformer{
+			informers := []cache.SharedIndexInformer{
 				local.Rbac().V1().ClusterRoles().Informer(),
 				local.Rbac().V1().ClusterRoleBindings().Informer(),
 				global.Rbac().V1().ClusterRoles().Informer(),
 				global.Rbac().V1().ClusterRoleBindings().Informer(),
-			} {
+			}
+			syncs := make([]cache.InformerSynced, 0, len(informers))
+			for _, inf := range informers {
 				go inf.Run(ctx.Done())
 				syncs = append(syncs, inf.HasSynced)
 			}
diff --git a/pkg/features/kcp_features.go b/pkg/features/kcp_features.go
@@ -106,7 +106,7 @@ func featureSpecAtEmulationVersion(v featuregate.VersionedSpecs, emulationVersio
 }
 
 func (f *kcpFeatureGate) String() string {
-	pairs := []string{}
+	pairs := make([]string, 0, len(defaultVersionedGenericControlPlaneFeatureGates))
 	emulatedVersion := utilfeature.DefaultMutableFeatureGate.EmulationVersion()
 
 	for featureName, versionedSpecs := range defaultVersionedGenericControlPlaneFeatureGates {
diff --git a/pkg/informer/informer.go b/pkg/informer/informer.go
@@ -19,6 +19,7 @@ package informer
 import (
 	"context"
 	"fmt"
+	"slices"
 	"sort"
 	"strings"
 	"sync"
@@ -427,9 +428,7 @@ func (d *GenericDiscoveringDynamicSharedInformerFactory[Informer, Lister, Generi
 
 	handlers := d.handlers.Load().([]GVREventHandler)
 
-	newHandlers := make([]GVREventHandler, len(handlers))
-	copy(newHandlers, handlers)
-
+	newHandlers := slices.Clone(handlers)
 	newHandlers = append(newHandlers, handler)
 
 	d.handlers.Store(newHandlers)
@@ -616,7 +615,7 @@ func gvrsToDiscoveryData(gvrs map[schema.GroupVersionResource]GVRPartialMetadata
 	}
 
 	for group, resources := range gvResources {
-		var versions []metav1.GroupVersionForDiscovery
+		versions := make([]metav1.GroupVersionForDiscovery, 0, len(resources))
 		versionedResources := make(map[string][]metav1.APIResource)
 
 		for version, apiResource := range resources {
diff --git a/pkg/reconciler/apis/logicalclustercleanup/logicalclustercleanup_controller_test.go b/pkg/reconciler/apis/logicalclustercleanup/logicalclustercleanup_controller_test.go
@@ -164,8 +164,11 @@ func (b *bindingBuilder) WithName(name string) *bindingBuilder {
 }
 
 func (b *bindingBuilder) WithBoundResources(boundResources ...string) *bindingBuilder {
+	if len(boundResources)%2 != 0 {
+		panic("bound resources slice of unexpected length")
+	}
 	for i := 0; i < len(boundResources); i += 2 {
-		group, resource := boundResources[i], boundResources[i+1]
+		group, resource := boundResources[i], boundResources[i+1] //nolint:gosec // Bounds is checked with the modulo above
 		b.Status.BoundResources = append(b.Status.BoundResources, apisv1alpha2.BoundAPIResource{
 			Group:    group,
 			Resource: resource,
diff --git a/pkg/virtual/framework/dynamic/apiserver/openapi.go b/pkg/virtual/framework/dynamic/apiserver/openapi.go
@@ -355,7 +355,7 @@ func addSpecs(service *handler3.OpenAPIService, routeSpecs map[string][]*spec3.O
 }
 
 func apiConfigurationKey(apiDefs apidefinition.APIDefinitionSet) (string, error) {
-	var buf bytes.Buffer
+	buf := &bytes.Buffer{}
 
 	keys := make([]schema.GroupVersionResource, 0, len(apiDefs))
 	for k := range apiDefs {
@@ -375,12 +375,12 @@ func apiConfigurationKey(apiDefs apidefinition.APIDefinitionSet) (string, error)
 		}
 
 		if !firstAPIDef {
-			buf.WriteRune(';')
+			buf.WriteByte(';')
 		}
 
 		buf.WriteString(apiDefSchema.Name)
-		buf.WriteRune(':')
-		buf.WriteString(fmt.Sprintf("%X", sha512.Sum512(bs)))
+		buf.WriteByte(':')
+		fmt.Fprintf(buf, "%X", sha512.Sum512(bs))
 
 		firstAPIDef = false
 	}
diff --git a/pkg/virtual/framework/wrappers/rbac/merging.go b/pkg/virtual/framework/wrappers/rbac/merging.go
@@ -130,7 +130,7 @@ func (l *mergedRoleLister) List(selector labels.Selector) (ret []*rbacv1.Role, e
 }
 
 func (l *mergedRoleLister) Roles(namespace string) rbaclisters.RoleNamespaceLister {
-	aggregatedListers := make([]rbaclisters.RoleNamespaceLister, 0)
+	aggregatedListers := make([]rbaclisters.RoleNamespaceLister, 0, len(l.listers))
 	for _, inf := range l.listers {
 		aggregatedListers = append(aggregatedListers, inf.Roles(namespace))
 	}
@@ -207,7 +207,7 @@ func (l *mergedRoleBindingLister) Get(name string) (*rbacv1.RoleBinding, error)
 }
 
 func (l *mergedRoleBindingLister) RoleBindings(namespace string) rbaclisters.RoleBindingNamespaceLister {
-	aggregatedListers := make([]rbaclisters.RoleBindingNamespaceLister, 0)
+	aggregatedListers := make([]rbaclisters.RoleBindingNamespaceLister, 0, len(l.listers))
 	for _, inf := range l.listers {
 		aggregatedListers = append(aggregatedListers, inf.RoleBindings(namespace))
 	}
diff --git a/staging/src/github.com/kcp-dev/cli/pkg/bind/plugin/bind.go b/staging/src/github.com/kcp-dev/cli/pkg/bind/plugin/bind.go
@@ -243,7 +243,7 @@ func (b *BindOptions) newAPIBinding(preferredAPIBindingVersion string) (apishelp
 		return nil, fmt.Errorf("%s is not supported by this plugin", preferredAPIBindingVersion)
 	}
 
-	claims := []apisv1alpha2.AcceptablePermissionClaim{}
+	claims := make([]apisv1alpha2.AcceptablePermissionClaim, 0, len(b.acceptedPermissionClaims)+len(b.rejectedPermissionClaims))
 	claims = append(claims, b.acceptedPermissionClaims...)
 	claims = append(claims, b.rejectedPermissionClaims...)
 
diff --git a/staging/src/github.com/kcp-dev/code-generator/cmd/cluster-informer-gen/generators/generic.go b/staging/src/github.com/kcp-dev/code-generator/cmd/cluster-informer-gen/generators/generic.go
@@ -90,7 +90,7 @@ func (v *version) Compare(other *version) int {
 func (g *genericGenerator) GenerateType(c *generator.Context, t *types.Type, w io.Writer) error {
 	sw := generator.NewSnippetWriter(w, c, "{{", "}}")
 
-	groups := []group{}
+	groups := make([]group, 0, len(g.groupVersions))
 	schemeGVs := make(map[*version]*types.Type)
 
 	orderer := namer.Orderer{Namer: namer.NewPrivateNamer(0)}
diff --git a/staging/src/github.com/kcp-dev/sdk/apis/apis/fuzzer/fuzzer.go b/staging/src/github.com/kcp-dev/sdk/apis/apis/fuzzer/fuzzer.go
@@ -76,8 +76,8 @@ func Funcs(codecs runtimeserializer.CodecFactory) []any {
 				group := nonEmptyString(c.String)
 				resource := nonEmptyString(c.String)
 				identityHash := nonEmptyString(c.String)
-				verbs := []string{}
 				numVerbs := c.Intn(5) + 1 // the lower bound is 0, but 0 verbs is not a valid combination
+				verbs := make([]string, 0, numVerbs)
 				for range numVerbs {
 					verbs = append(verbs, nonEmptyString(c.String))
 				}
@@ -190,8 +190,8 @@ func Funcs(codecs runtimeserializer.CodecFactory) []any {
 				group := nonEmptyString(c.String)
 				resource := nonEmptyString(c.String)
 				identityHash := nonEmptyString(c.String)
-				verbs := []string{}
 				numVerbs := c.Intn(5) + 1 // the lower bound is 0, but 0 verbs is not a valid combination
+				verbs := make([]string, 0, numVerbs)
 				for range numVerbs {
 					verbs = append(verbs, nonEmptyString(c.String))
 				}
@@ -210,7 +210,7 @@ func Funcs(codecs runtimeserializer.CodecFactory) []any {
 					selector.MatchLabels = labels
 				default:
 					numExpressions := c.Intn(5) + 1
-					expressions := make([]metav1.LabelSelectorRequirement, numExpressions)
+					expressions := make([]metav1.LabelSelectorRequirement, 0, numExpressions)
 					for range numExpressions {
 						expressions = append(expressions, metav1.LabelSelectorRequirement{
 							Key:      nonEmptyString(c.String),
@@ -246,8 +246,8 @@ func Funcs(codecs runtimeserializer.CodecFactory) []any {
 				group := nonEmptyString(c.String)
 				resource := nonEmptyString(c.String)
 				identityHash := nonEmptyString(c.String)
-				verbs := []string{}
 				numVerbs := c.Intn(5) + 1 // the lower bound is 0, but 0 verbs is not a valid combination
+				verbs := make([]string, 0, numVerbs)
 				for range numVerbs {
 					verbs = append(verbs, nonEmptyString(c.String))
 				}
@@ -266,7 +266,7 @@ func Funcs(codecs runtimeserializer.CodecFactory) []any {
 					selector.MatchLabels = labels
 				default:
 					numExpressions := c.Intn(5) + 1
-					expressions := make([]metav1.LabelSelectorRequirement, numExpressions)
+					expressions := make([]metav1.LabelSelectorRequirement, 0, numExpressions)
 					for range numExpressions {
 						expressions = append(expressions, metav1.LabelSelectorRequirement{
 							Key:      nonEmptyString(c.String),
@@ -296,8 +296,8 @@ func Funcs(codecs runtimeserializer.CodecFactory) []any {
 				group := nonEmptyString(c.String)
 				resource := nonEmptyString(c.String)
 				identityHash := nonEmptyString(c.String)
-				verbs := []string{}
 				numVerbs := c.Intn(5) + 1 // the lower bound is 0, but 0 verbs is not a valid combination
+				verbs := make([]string, 0, numVerbs)
 				for range numVerbs {
 					verbs = append(verbs, nonEmptyString(c.String))
 				}
diff --git a/staging/src/github.com/kcp-dev/sdk/apis/apis/v1alpha1/crd_to_apiresourceschema.go b/staging/src/github.com/kcp-dev/sdk/apis/apis/v1alpha1/crd_to_apiresourceschema.go
@@ -33,7 +33,7 @@ func CRDToAPIResourceSchema(crd *apiextensionsv1.CustomResourceDefinition, prefi
 	name := prefix + "." + crd.Name
 
 	if msgs := validation.IsDNS1123Subdomain(name); len(msgs) > 0 {
-		var errs []error
+		errs := make([]error, 0, len(msgs))
 
 		for _, msg := range msgs {
 			errs = append(errs, field.Invalid(field.NewPath("metadata", "name"), name, msg))
diff --git a/staging/src/github.com/kcp-dev/sdk/apis/apis/v1alpha2/validation_test.go b/staging/src/github.com/kcp-dev/sdk/apis/apis/v1alpha2/validation_test.go
@@ -168,7 +168,7 @@ func TestValidateAPIBindingPermissionClaims(t *testing.T) {
 			got := ValidateAPIBindingPermissionClaims(tc.permissionClaims, field.NewPath("spec", "permissionClaims"))
 
 			// Convert FieldErrors into a string slice
-			errs := []string{}
+			errs := make([]string, 0, len(got))
 			for _, err := range got {
 				errs = append(errs, err.Error())
 			}
diff --git a/staging/src/github.com/kcp-dev/sdk/testing/server/metrics.go b/staging/src/github.com/kcp-dev/sdk/testing/server/metrics.go
@@ -128,8 +128,9 @@ func ScrapeMetrics(ctx context.Context, cfg *rest.Config, promUrl, promCfgDir, j
 			return err
 		}
 		defer f.Close()
+		fd := int(f.Fd()) //nolint:gosec // the conversion uintpr -> int is fine here
 		// lock config file exclusively, blocks all other producers until unlocked or process (test) exits
-		err = syscall.Flock(int(f.Fd()), syscall.LOCK_EX)
+		err = syscall.Flock(fd, syscall.LOCK_EX)
 		if err != nil {
 			return err
 		}
@@ -165,7 +166,7 @@ func ScrapeMetrics(ctx context.Context, cfg *rest.Config, promUrl, promCfgDir, j
 		if err != nil {
 			return err
 		}
-		return syscall.Flock(int(f.Fd()), syscall.LOCK_UN)
+		return syscall.Flock(fd, syscall.LOCK_UN)
 	}()
 	if err != nil {
 		return err
@@ -217,12 +218,13 @@ func CleanupScrapeMetrics(ctx context.Context, promUrl, promCfgDir, jobNamePrefi
 		defer f.Close()
 
 		// lock config file exclusively
-		err = syscall.Flock(int(f.Fd()), syscall.LOCK_EX)
+		fd := int(f.Fd()) //nolint:gosec // the conversion uintpr -> int is fine here
+		err = syscall.Flock(fd, syscall.LOCK_EX)
 		if err != nil {
 			return err
 		}
 		defer func() {
-			_ = syscall.Flock(int(f.Fd()), syscall.LOCK_UN)
+			_ = syscall.Flock(fd, syscall.LOCK_UN)
 		}()
 
 		promCfg := config{}
diff --git a/test/e2e/apibinding/apibinding_test.go b/test/e2e/apibinding/apibinding_test.go
@@ -377,7 +377,7 @@ func TestAPIBinding(t *testing.T) {
 	}
 
 	verifyVirtualWorkspaceURLs := func(serviceProviderClusterName logicalcluster.Name) {
-		var expectedURLs []string
+		expectedURLs := make([]string, 0, len(shardVirtualWorkspaceURLs))
 		for _, urlString := range sets.List[string](shardVirtualWorkspaceURLs) {
 			u, err := url.Parse(urlString)
 			require.NoError(t, err, "error parsing %q", urlString)
@@ -392,7 +392,7 @@ func TestAPIBinding(t *testing.T) {
 				t.Logf("Unexpected error getting APIExportEndpointSlice %s|%s: %v", serviceProviderClusterName.Path(), exportName, err)
 			}
 
-			var actualURLs []string
+			actualURLs := make([]string, 0, len(apiExportEndpointSlice.Status.APIExportEndpoints))
 			for _, u := range apiExportEndpointSlice.Status.APIExportEndpoints {
 				actualURLs = append(actualURLs, u.URL)
 			}
diff --git a/test/e2e/fixtures/authfixtures/authfixtures.go b/test/e2e/fixtures/authfixtures/authfixtures.go
@@ -32,7 +32,7 @@ import (
 )
 
 func CreateWorkspaceType(t *testing.T, ctx context.Context, client kcpclientset.ClusterInterface, workspace logicalcluster.Path, name string, authConfigNames ...string) string {
-	configs := []tenancyv1alpha1.AuthenticationConfigurationReference{}
+	configs := make([]tenancyv1alpha1.AuthenticationConfigurationReference, 0, len(authConfigNames))
 	for _, name := range authConfigNames {
 		configs = append(configs, tenancyv1alpha1.AuthenticationConfigurationReference{
 			Name: name,
diff --git a/test/e2e/framework/kcp.go b/test/e2e/framework/kcp.go
@@ -35,9 +35,8 @@ func init() {
 
 	DefaultTokenAuthFile = filepath.Join(repo, "test", "e2e", "framework", "auth-tokens.csv")
 
-	var args []string
-	args = append(args, "--token-auth-file", DefaultTokenAuthFile) //nolint:gocritic // no.
-	args = append(args, "--feature-gates=WorkspaceMounts=true,CacheAPIs=true,WorkspaceAuthentication=true")
-
-	kcptesting.InitSharedKcpServer(kcptestingserver.WithCustomArguments(args...))
+	kcptesting.InitSharedKcpServer(kcptestingserver.WithCustomArguments(
+		"--token-auth-file", DefaultTokenAuthFile,
+		"--feature-gates=WorkspaceMounts=true,CacheAPIs=true,WorkspaceAuthentication=true",
+	))
 }
diff --git a/test/e2e/homeworkspaces/home_workspaces_test.go b/test/e2e/homeworkspaces/home_workspaces_test.go
@@ -39,10 +39,10 @@ func TestUserHomeWorkspaces(t *testing.T) {
 	t.Parallel()
 	framework.Suite(t, "control-plane")
 
-	var serverArgs []string
-	serverArgs = append(serverArgs, "--token-auth-file", framework.DefaultTokenAuthFile) //nolint:gocritic // no.
-	serverArgs = append(serverArgs, "--home-workspaces-home-creator-groups=team-1")
-	server := kcptesting.PrivateKcpServer(t, kcptestingserver.WithCustomArguments(serverArgs...))
+	server := kcptesting.PrivateKcpServer(t, kcptestingserver.WithCustomArguments(
+		"--token-auth-file", framework.DefaultTokenAuthFile,
+		"--home-workspaces-home-creator-groups=team-1",
+	))
 
 	ctx, cancelFunc := context.WithCancel(context.Background())
 	t.Cleanup(cancelFunc)
diff --git a/test/e2e/virtual/apiexport/binding_test.go b/test/e2e/virtual/apiexport/binding_test.go
@@ -1059,7 +1059,7 @@ func testSecretMapWithLabels(num int, labels map[string]string) *corev1.Secret {
 }
 
 func permissionClaimsToAcceptable(permissionClaims []apisv1alpha2.PermissionClaim, modifiers ...func([]apisv1alpha2.AcceptablePermissionClaim)) []apisv1alpha2.AcceptablePermissionClaim {
-	acceptablePermissionClaims := []apisv1alpha2.AcceptablePermissionClaim{}
+	acceptablePermissionClaims := make([]apisv1alpha2.AcceptablePermissionClaim, 0, len(permissionClaims))
 	for _, pc := range permissionClaims {
 		acceptablePermissionClaims = append(acceptablePermissionClaims, apisv1alpha2.AcceptablePermissionClaim{
 			ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
diff --git a/test/e2e/virtualresources/cachedresources/vr_cachedresources_test.go b/test/e2e/virtualresources/cachedresources/vr_cachedresources_test.go
@@ -293,7 +293,7 @@ func TestCachedResources(t *testing.T) {
 	resourceCounters := map[string]*int32{
 		"sheriffs": ptr.To[int32](0),
 	}
-	var watchStopFuncs []func()
+	watchStopFuncs := make([]func(), 0, len(apiExportVWClientConfigs)*len(resourceCounters))
 	defer func() {
 		for _, stop := range watchStopFuncs {
 			stop()

Original file line number	Diff line number	Diff line change
`@@ -58,9 +58,5 @@ func (o *Options) Complete() error {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`func (o *Options) Validate() []error {`
`61`		`- var errs []error`
`62`		`-`
`63`		`- errs = append(errs, o.Proxy.Validate()...)`
`64`		`-`
`65`		`- return errs`
	`61`	`+ return o.Proxy.Validate()`
`66`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ func featureSpecAtEmulationVersion(v featuregate.VersionedSpecs, emulationVersio`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`func (f *kcpFeatureGate) String() string {`
`109`		`- pairs := []string{}`
	`109`	`+ pairs := make([]string, 0, len(defaultVersionedGenericControlPlaneFeatureGates))`
`110`	`110`	`emulatedVersion := utilfeature.DefaultMutableFeatureGate.EmulationVersion()`
`111`	`111`
`112`	`112`	`for featureName, versionedSpecs := range defaultVersionedGenericControlPlaneFeatureGates {`
Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ func addSpecs(service handler3.OpenAPIService, routeSpecs map[string][]spec3.O`
`355`	`355`	`}`
`356`	`356`
`357`	`357`	`func apiConfigurationKey(apiDefs apidefinition.APIDefinitionSet) (string, error) {`
`358`		`- var buf bytes.Buffer`
	`358`	`+ buf := &bytes.Buffer{}`
`359`	`359`
`360`	`360`	`keys := make([]schema.GroupVersionResource, 0, len(apiDefs))`
`361`	`361`	`for k := range apiDefs {`
`@@ -375,12 +375,12 @@ func apiConfigurationKey(apiDefs apidefinition.APIDefinitionSet) (string, error)`
`375`	`375`	`}`
`376`	`376`
`377`	`377`	`if !firstAPIDef {`
`378`		`- buf.WriteRune(';')`
	`378`	`+ buf.WriteByte(';')`
`379`	`379`	`}`
`380`	`380`
`381`	`381`	`buf.WriteString(apiDefSchema.Name)`
`382`		`- buf.WriteRune(':')`
`383`		`- buf.WriteString(fmt.Sprintf("%X", sha512.Sum512(bs)))`
	`382`	`+ buf.WriteByte(':')`
	`383`	`+ fmt.Fprintf(buf, "%X", sha512.Sum512(bs))`
`384`	`384`
`385`	`385`	`firstAPIDef = false`
`386`	`386`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ func (l mergedRoleLister) List(selector labels.Selector) (ret []rbacv1.Role, e`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`func (l *mergedRoleLister) Roles(namespace string) rbaclisters.RoleNamespaceLister {`
`133`		`- aggregatedListers := make([]rbaclisters.RoleNamespaceLister, 0)`
	`133`	`+ aggregatedListers := make([]rbaclisters.RoleNamespaceLister, 0, len(l.listers))`
`134`	`134`	`for _, inf := range l.listers {`
`135`	`135`	`aggregatedListers = append(aggregatedListers, inf.Roles(namespace))`
`136`	`136`	`}`
`@@ -207,7 +207,7 @@ func (l mergedRoleBindingLister) Get(name string) (rbacv1.RoleBinding, error)`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`func (l *mergedRoleBindingLister) RoleBindings(namespace string) rbaclisters.RoleBindingNamespaceLister {`
`210`		`- aggregatedListers := make([]rbaclisters.RoleBindingNamespaceLister, 0)`
	`210`	`+ aggregatedListers := make([]rbaclisters.RoleBindingNamespaceLister, 0, len(l.listers))`
`211`	`211`	`for _, inf := range l.listers {`
`212`	`212`	`aggregatedListers = append(aggregatedListers, inf.RoleBindings(namespace))`
`213`	`213`	`}`
Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ func (b *BindOptions) newAPIBinding(preferredAPIBindingVersion string) (apishelp`
`243`	`243`	`return nil, fmt.Errorf("%s is not supported by this plugin", preferredAPIBindingVersion)`
`244`	`244`	`}`
`245`	`245`
`246`		`- claims := []apisv1alpha2.AcceptablePermissionClaim{}`
	`246`	`+ claims := make([]apisv1alpha2.AcceptablePermissionClaim, 0, len(b.acceptedPermissionClaims)+len(b.rejectedPermissionClaims))`
`247`	`247`	`claims = append(claims, b.acceptedPermissionClaims...)`
`248`	`248`	`claims = append(claims, b.rejectedPermissionClaims...)`
`249`	`249`