fix: 修正

Author: mk2

dist/index.js

@@ -8,18 +8,24 @@ import fetch from 'node-fetch';
 
 import { qiitaApiUrl } from '../config';
 import { QiitaArticle, RawQiitaArticle } from '../data-transfer-types';
+import { logger } from '../logger';
 
 export async function fetchArticles(userName: string, qiitaAccessToken: string): Promise<QiitaArticle[]> {
-  const response = await fetch(qiitaApiUrl(userName), {
-    headers: {
-      'content-type': 'application/json',
-      charset: 'utf-8',
-      ...(qiitaAccessToken ? { Authorization: `Bearer ${qiitaAccessToken}` } : undefined),
-    },
-  });
-  if (response.status !== 200) {
+  try {
+    const response = await fetch(qiitaApiUrl(userName), {
+      headers: {
+        'content-type': 'application/json',
+        charset: 'utf-8',
+        ...(qiitaAccessToken ? { Authorization: `Bearer ${qiitaAccessToken}` } : undefined),
+      },
+    });
+    if (response.status !== 200) {
+      return [];
+    }
+    const result: RawQiitaArticle[] = await response.json();
+    return result.map(article => QiitaArticle.from(article));
+  } catch (e) {
+    logger.error(`Error at qiita fetching: ${JSON.stringify(e)}`);
     return [];
   }
-  const result: RawQiitaArticle[] = await response.json();
-  return result.map(article => QiitaArticle.from(article));
 }

dist/index.js.map

@@ -46,19 +46,31 @@ import fetch from 'node-fetch';
 
 import { zennRssUrl } from '../config';
 import { RawZennArticle, ZennArticle } from '../data-transfer-types';
+import { logger } from '../logger';
 
 export async function fetchArticles(userId: string): Promise<ZennArticle[]> {
-  const response = await fetch(zennRssUrl(userId));
-  if (response.status !== 200) {
-    return [];
-  }
+  try {
+    const response = await fetch(zennRssUrl(userId));
+    if (response.status !== 200) {
+      return [];
+    }
+
+    const result = await response.text();
+    if (!parser.validate(result)) {
+      return [];
+    }
 
-  const result = await response.text();
-  if (!parser.validate(result)) {
+    const xml = parser.parse(result);
+
+    if (!xml.rss.channel.item) {
+      logger.info(`User (${userId}) has no zenn artiles.`);
+      return [];
+    }
+
+    const items: RawZennArticle[] = [xml.rss.channel.item].flat();
+    return items.map(article => ZennArticle.from(article));
+  } catch (e) {
+    logger.error(`Error at zenn fetching: ${JSON.stringify(e)}`);
     return [];
   }
-
-  const xml = parser.parse(result);
-  const items: RawZennArticle[] = [xml.rss.channel.item].flat();
-  return items.map(article => ZennArticle.from(article));
 }

src/adapters/qiita.ts

@@ -21,8 +21,8 @@ export const QiitaArticle = {
   from(article: RawQiitaArticle): QiitaArticle {
     return {
       ...article,
-      created_at: DateTime.fromISO(article.created_at),
-      updated_at: DateTime.fromISO(article.updated_at),
+      created_at: DateTime.fromISO(article.created_at).setZone('utc'),
+      updated_at: DateTime.fromISO(article.updated_at).setZone('utc'),
     };
   },
 };

src/adapters/zenn.ts

@@ -15,7 +15,7 @@ export const ZennArticle = {
   from(article: RawZennArticle): ZennArticle {
     return {
       ...article,
-      pubDate: DateTime.fromHTTP(article.pubDate),
+      pubDate: DateTime.fromHTTP(article.pubDate).setZone('utc'),
     };
   },
 };