Add an indexing option to delete persistent path exclusions

* README.md: Mention new `delete_persistent_exclusions' indexing opt.
* bdx/cli.py (IndexingOptionParamType.CONVERTERS): Add
`delete_persistent_exclusions'.
* bdx/index.py (IndexingOptions): Add `delete_persistent_exclusions'
option.
(index_binary_directory): Use it.
* tests/test_index.py (test_indexing_delete_persistent_exclusions):
New test.

Author: mkcms

README.md

@@ -91,6 +91,9 @@ Available options:
 - `persist_exclusions` - if True (False by default), then exclusions provided
   with `--exclude` option are saved for future runs.
 
+- `delete_persistent_exclusions` - if True (False by default), then delete all
+  previous `--exclude` exclusions saved with `persist_exclusions` option.
+
 ### Disassembling ###
 
 After a directory is indexed, you can disassemble symbols matching a search

bdx/cli.py

@@ -240,6 +240,7 @@ class IndexingOptionParamType(click.ParamType):
         "min_symbol_size": IntRange(min=0),
         "use_dwarfdump": BoolParamType(),
         "persist_exclusions": BoolParamType(),
+        "delete_persistent_exclusions": BoolParamType(),
     }
 
     def convert(self, value, param, ctx):

bdx/index.py

@@ -58,6 +58,7 @@ class IndexingOptions:
     min_symbol_size: int = 1
     use_dwarfdump: bool = True
     persist_exclusions: bool = False
+    delete_persistent_exclusions: bool = False
 
 
 @dataclass(frozen=True)
@@ -1069,7 +1070,12 @@ def index_binary_directory(
         if index.binary_dir() is None and not dry_run:
             index.set_binary_dir(bindir_path)
 
-        saved_exclusions = list(index.exclusions())
+        if options.delete_persistent_exclusions:
+            if not dry_run:
+                index.set_exclusions([])
+            saved_exclusions = []
+        else:
+            saved_exclusions = list(index.exclusions())
         for excl in saved_exclusions:
             debug("Loading saved exclusion: {}", excl)
             if excl not in exclusions:

tests/test_index.py

@@ -380,6 +380,26 @@ def test_indexing_uses_persistent_exclusions(fixture_path, tmp_path):
         assert all([not p.name.endswith(".cpp.o") for p in paths])
 
 
+def test_indexing_delete_persistent_exclusions(fixture_path, tmp_path):
+    index_path = tmp_path / "index"
+    index_binary_directory(
+        fixture_path,
+        index_path,
+        IndexingOptions(persist_exclusions=True),
+        exclusions=[Exclusion("**/*.cpp.o")],
+    )
+    index_binary_directory(
+        fixture_path,
+        index_path,
+        IndexingOptions(delete_persistent_exclusions=True),
+        exclusions=[],
+    )
+    with SymbolIndex.open(index_path, readonly=True) as index:
+        symbols = list(index.search("*:*"))
+        paths = [s.path for s in symbols]
+        assert any([p.name.endswith(".cpp.o") for p in paths])
+
+
 def test_searching_by_wildcard(readonly_index):
     symbols = set(readonly_index.search("name:a_*"))
     assert symbols